Korbs/electron-tabs
1
Fork 0
Code Issues Pull requests Activity

Added closing event

Browse source
This commit is contained in:
Robin Riclet 2017-04-04 10:55:44 +02:00
parent a2a5ae7f3c
commit 98bd8edd4d
2 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
README.md
View file

@ -123,6 +123,10 @@ Toggle the "flash" class on the tab. `tab.unflash()` is an alias to `tab.flash(f
Close the tab (and activate another tab if relevant). When `force` is set to `true` the tab will be closed even if it is not `closable`.
#### Prevent a tab from closing after it was created
Use the `closing` event and set the `closable` property to false
### Access webview element
You can access the webview element and use its methods with through the `Tab.webview` attribute. See [webview documentation](http://electron.atom.io/docs/api/web-view-tag/#methods).
@ -148,6 +152,7 @@ The following events are available:
* `tab.on("flash", (tab) => { ... });`
* `tab.on("unflash", (tab) => { ... });`
* `tab.on("close", (tab) => { ... });`
* `tab.on("closing", (tab) => { ... });`
## Drag and drop support
@ -182,4 +187,4 @@ var tabGroup = new TabGroup({
## License
The MIT License (MIT) - Copyright (c) 2016 Thomas Brouard
The MIT License (MIT) - Copyright (c) 2016 Thomas Brouard

10
index.js
View file

@ -225,6 +225,8 @@ class Tab extends EventEmitter {
}
close (force) {
this.emit("closing", this);
if (typeof force !== 'boolean') force = false;
if (this.isClosed || (!this.closable && !force)) return;
this.isClosed = true;
let tabGroup = this.tabGroup;
@ -294,13 +296,13 @@ const TabPrivate = {
initWebview: function () {
this.webview = document.createElement("webview");
const tabWebviewDidFinishLoadHandler = function (e) {
this.emit("webview-ready", this);
};
this.webview.addEventListener("did-finish-load", tabWebviewDidFinishLoadHandler.bind(this), false);
this.webview.classList.add(this.tabGroup.options.viewClass);
if (this.webviewAttributes) {
let attrs = this.webviewAttributes;
@ -308,9 +310,9 @@ const TabPrivate = {
this.webview.setAttribute(key, attrs[key]);
}
}
this.tabGroup.viewContainer.appendChild(this.webview);
}
};
module.exports = TabGroup;
module.exports = TabGroup;