Korbs/electron-tabs
1
Fork 0
Code Issues Pull requests Activity

Fixed force when calling tab.close()

Browse source
This commit is contained in:
Robin Riclet 2017-04-04 14:33:57 +02:00
parent a2a5ae7f3c
commit 58258cbc65
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
index.js
View file

@ -268,7 +268,7 @@ const TabPrivate = {
let button = container.appendChild(document.createElement("button")); let button = container.appendChild(document.createElement("button"));
button.classList.add(`${tabClass}-button-close`); button.classList.add(`${tabClass}-button-close`);
button.innerHTML = this.tabGroup.options.closeButtonText; button.innerHTML = this.tabGroup.options.closeButtonText;
button.addEventListener("click", this.close.bind(this), false); button.addEventListener("click", this.close.bind(this, false), false);
} }
}, },
@ -294,13 +294,13 @@ const TabPrivate = {
initWebview: function () { initWebview: function () {
this.webview = document.createElement("webview"); this.webview = document.createElement("webview");
const tabWebviewDidFinishLoadHandler = function (e) { const tabWebviewDidFinishLoadHandler = function (e) {
this.emit("webview-ready", this); this.emit("webview-ready", this);
}; };
this.webview.addEventListener("did-finish-load", tabWebviewDidFinishLoadHandler.bind(this), false); this.webview.addEventListener("did-finish-load", tabWebviewDidFinishLoadHandler.bind(this), false);
this.webview.classList.add(this.tabGroup.options.viewClass); this.webview.classList.add(this.tabGroup.options.viewClass);
if (this.webviewAttributes) { if (this.webviewAttributes) {
let attrs = this.webviewAttributes; let attrs = this.webviewAttributes;
@ -308,9 +308,9 @@ const TabPrivate = {
this.webview.setAttribute(key, attrs[key]); this.webview.setAttribute(key, attrs[key]);
} }
} }
this.tabGroup.viewContainer.appendChild(this.webview); this.tabGroup.viewContainer.appendChild(this.webview);
} }
}; };
module.exports = TabGroup; module.exports = TabGroup;