Korbs/Squire
0
Fork 0
mirror of https://github.com/fastmail/Squire.git synced 2024-12-22 15:23:29 -05:00
Code Issues Activity

Fix multiple firing of updatePathOnEvent

Browse source
This commit is contained in:
Neil Jenkins 2016-06-27 13:17:18 +10:00
parent 267085e8c1
commit db09921d7b
3 changed files with 26 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
build/squire-raw.js
View file

@ -2324,6 +2324,7 @@ function Squire ( root, config ) {
this._lastAnchorNode = null; this._lastAnchorNode = null;
this._lastFocusNode = null; this._lastFocusNode = null;
this._path = ''; this._path = '';
this._willUpdatePath = false;
if ( 'onselectionchange' in doc ) { if ( 'onselectionchange' in doc ) {
this.addEventListener( 'selectionchange', this._updatePathOnEvent ); this.addEventListener( 'selectionchange', this._updatePathOnEvent );
@ -2859,8 +2860,18 @@ proto._updatePath = function ( range, force ) {
} }
}; };
// selectionchange is fired synchronously in IE when removing current selection
// and when setting new selection; keyup/mouseup may have processing we want
// to do first. Either way, send to next event loop.
proto._updatePathOnEvent = function () { proto._updatePathOnEvent = function () {
this._updatePath( this.getSelection() ); var self = this;
if ( !self._willUpdatePath ) {
self._willUpdatePath = true;
setTimeout( function () {
self._willUpdatePath = false;
self._updatePath( self.getSelection() );
}, 0 );
}
}; };
// --- Focus --- // --- Focus ---

4
build/squire.js
View file

File diff suppressed because one or more lines are too long

13
source/Editor.js
View file

@ -56,6 +56,7 @@ function Squire ( root, config ) {
this._lastAnchorNode = null; this._lastAnchorNode = null;
this._lastFocusNode = null; this._lastFocusNode = null;
this._path = ''; this._path = '';
this._willUpdatePath = false;
if ( 'onselectionchange' in doc ) { if ( 'onselectionchange' in doc ) {
this.addEventListener( 'selectionchange', this._updatePathOnEvent ); this.addEventListener( 'selectionchange', this._updatePathOnEvent );
@ -591,8 +592,18 @@ proto._updatePath = function ( range, force ) {
} }
}; };
// selectionchange is fired synchronously in IE when removing current selection
// and when setting new selection; keyup/mouseup may have processing we want
// to do first. Either way, send to next event loop.
proto._updatePathOnEvent = function () { proto._updatePathOnEvent = function () {
this._updatePath( this.getSelection() ); var self = this;
if ( !self._willUpdatePath ) {
self._willUpdatePath = true;
setTimeout( function () {
self._willUpdatePath = false;
self._updatePath( self.getSelection() );
}, 0 );
}
}; };
// --- Focus --- // --- Focus ---