Korbs/Squire
0
Fork 0
mirror of https://github.com/fastmail/Squire.git synced 2025-01-03 05:00:13 -05:00
Code Issues Activity

Handle all cases of overwriting content

Browse source 
Modern browsers tell you which character will be inserted with event.key, so
we can make sure we handle content deletion ourselves in these cases too.
This commit is contained in:
Neil Jenkins 2018-03-18 10:40:03 +00:00
parent 9dda7cc845
commit b0ac7d32d0
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
build/squire-raw.js
View file

@ -1330,7 +1330,7 @@ var onKey = function ( event ) {
if ( this._keyHandlers[ key ] ) { if ( this._keyHandlers[ key ] ) {
this._keyHandlers[ key ]( this, event, range ); this._keyHandlers[ key ]( this, event, range );
} else if ( key.length === 1 && !range.collapsed ) { } else if ( !range.collapsed && ( event.key || key ).length === 1 ) {
// Record undo checkpoint. // Record undo checkpoint.
this.saveUndoState( range ); this.saveUndoState( range );
// Delete the selection // Delete the selection

2
build/squire.js
View file

File diff suppressed because one or more lines are too long

2
source/KeyHandlers.js
View file

@ -59,7 +59,7 @@ var onKey = function ( event ) {
if ( this._keyHandlers[ key ] ) { if ( this._keyHandlers[ key ] ) {
this._keyHandlers[ key ]( this, event, range ); this._keyHandlers[ key ]( this, event, range );
} else if ( key.length === 1 && !range.collapsed ) { } else if ( !range.collapsed && ( event.key || key ).length === 1 ) {
// Record undo checkpoint. // Record undo checkpoint.
this.saveUndoState( range ); this.saveUndoState( range );
// Delete the selection // Delete the selection