Korbs/Squire
0
Fork 0
mirror of https://github.com/fastmail/Squire.git synced 2025-01-03 05:00:13 -05:00
Code Issues Activity

Fix pasting multiple lines into a blockquote.

Browse source 
Pasting is hard to get right in the general case, not least because the
browsers give so little control over the process, leaving you to resort to
crappy hacks. But we can special case the pasting to a blockquote case fairly
easily, and I can't see any particular regression it should cause.

Fixes #59.
This commit is contained in:
Neil Jenkins 2015-04-09 20:16:04 +07:00
parent 62e2f5aa95
commit 73ca65edb5
3 changed files with 16 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
build/squire-raw.js
View file

@ -776,11 +776,14 @@ var insertTreeFragmentIntoRange = function ( range, frag ) {
insertNodeInRange( range, frag ); insertNodeInRange( range, frag );
range.collapse( false ); range.collapse( false );
} }
// Otherwise, split up to body, insert inline before and after split // Otherwise, split up to blockquote (if a parent) or body, insert inline
// and insert block in between split, then merge containers. // before and after split and insert block in between split, then merge
// containers.
else { else {
var nodeAfterSplit = split( range.startContainer, range.startOffset, var splitPoint = range.startContainer,
range.startContainer.ownerDocument.body ), nodeAfterSplit = split( splitPoint, range.startOffset,
getNearest( splitPoint.parentNode, 'BLOCKQUOTE' ) ||
splitPoint.ownerDocument.body ),
nodeBeforeSplit = nodeAfterSplit.previousSibling, nodeBeforeSplit = nodeAfterSplit.previousSibling,
startContainer = nodeBeforeSplit, startContainer = nodeBeforeSplit,
startOffset = startContainer.childNodes.length, startOffset = startContainer.childNodes.length,

4
build/squire.js
View file

File diff suppressed because one or more lines are too long

11
source/Range.js
View file

@ -192,11 +192,14 @@ var insertTreeFragmentIntoRange = function ( range, frag ) {
insertNodeInRange( range, frag ); insertNodeInRange( range, frag );
range.collapse( false ); range.collapse( false );
} }
// Otherwise, split up to body, insert inline before and after split // Otherwise, split up to blockquote (if a parent) or body, insert inline
// and insert block in between split, then merge containers. // before and after split and insert block in between split, then merge
// containers.
else { else {
var nodeAfterSplit = split( range.startContainer, range.startOffset, var splitPoint = range.startContainer,
range.startContainer.ownerDocument.body ), nodeAfterSplit = split( splitPoint, range.startOffset,
getNearest( splitPoint.parentNode, 'BLOCKQUOTE' ) ||
splitPoint.ownerDocument.body ),
nodeBeforeSplit = nodeAfterSplit.previousSibling, nodeBeforeSplit = nodeAfterSplit.previousSibling,
startContainer = nodeBeforeSplit, startContainer = nodeBeforeSplit,
startOffset = startContainer.childNodes.length, startOffset = startContainer.childNodes.length,