Korbs/Squire
0
Fork 0
mirror of https://github.com/fastmail/Squire.git synced 2024-12-22 15:23:29 -05:00
Code Issues Activity

FF: Selection range may not have startContainer.

Browse source 
* Odd bug this. From the logs, it seems either it's returning a range with no
  startContainer, or the startContainer is not something inheriting from the
  Node prototype (which would be very wrong).
This commit is contained in:
Neil Jenkins 2013-02-27 10:49:08 +11:00
parent a069e8305e
commit 5b52e9b4b8
2 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
build/squire.js
View file

File diff suppressed because one or more lines are too long

10
source/Editor.js
View file

@ -160,12 +160,14 @@
var getSelection = function () { var getSelection = function () {
if ( sel.rangeCount ) { if ( sel.rangeCount ) {
lastSelection = sel.getRangeAt( 0 ).cloneRange(); lastSelection = sel.getRangeAt( 0 ).cloneRange();
var startContainer = lastSelection.startContainer,
endContainer = lastSelection.endContainer;
// FF can return the selection as being inside an <img>. WTF? // FF can return the selection as being inside an <img>. WTF?
if ( lastSelection.startContainer.isLeaf() ) { if ( startContainer && startContainer.isLeaf() ) {
lastSelection.setStartBefore( lastSelection.startContainer ); lastSelection.setStartBefore( startContainer );
} }
if ( lastSelection.endContainer.isLeaf() ) { if ( endContainer && endContainer.isLeaf() ) {
lastSelection.setEndBefore( lastSelection.endContainer ); lastSelection.setEndBefore( endContainer );
} }
} }
return lastSelection; return lastSelection;