Korbs/Squire
0
Fork 0
mirror of https://github.com/fastmail/Squire.git synced 2024-12-22 07:13:08 -05:00
Code Issues Activity

Editor.ts: Revert fix for Grammarly bug

Browse source 
The fix for Grammarly bug prevents pasting text directly from the keyboard on Android if the text to be
inserted contains \n, as pasting from the keyboard does not fire a true paste event. The Grammarly bug seems to have been
fixed in Samsung keyboard as of v5.6.10.4.
This commit is contained in:
Chasen Stark 2024-02-01 15:16:58 -05:00
parent 38754f17f9
commit 43799dc57d
1 changed files with 1 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
source/Editor.ts
View file

@ -41,7 +41,7 @@ import {
} from './node/MergeSplit'; } from './node/MergeSplit';
import { getBlockWalker, getNextBlock, isEmptyBlock } from './node/Block'; import { getBlockWalker, getNextBlock, isEmptyBlock } from './node/Block';
import { cleanTree, cleanupBRs, escapeHTML, removeEmptyInlines } from './Clean'; import { cleanTree, cleanupBRs, escapeHTML, removeEmptyInlines } from './Clean';
import { cantFocusEmptyTextNodes, isAndroid, ZWS } from './Constants'; import { cantFocusEmptyTextNodes, ZWS } from './Constants';
import { import {
expandRangeToBlockBoundaries, expandRangeToBlockBoundaries,
getEndBlockOfRange, getEndBlockOfRange,
@ -256,25 +256,6 @@ class Squire {
_beforeInput(event: InputEvent): void { _beforeInput(event: InputEvent): void {
switch (event.inputType) { switch (event.inputType) {
case 'insertText':
// Generally we let the browser handle text insertion, as it
// does so fine. However, the Samsung keyboard on Android with
// the Grammarly extension goes batshit crazy for some reason
// and will try to disastrously rewrite the whole data, without
// the user even doing anything (it can happen on first load
// before the user types anything). Fortunately we can detect
// this by looking for a new line in the data and if we see it,
// stop it by preventing default.
// 30-11-2023 Update: The fix for Grammarly bug prevents pasting
// text directly from the keyboard on Android if the text to be
// inserted contains \n, as pasting from the keyboard does not
// fire a true paste event. The Grammarly bug seems to have been
// fixed in Samsung keyboard as of v5.6.10.4, but leaving the
// fix in place for now, as the bug is particularly destructive.
if (isAndroid && event.data && event.data.includes('\n')) {
event.preventDefault();
}
break;
case 'insertLineBreak': case 'insertLineBreak':
event.preventDefault(); event.preventDefault();
this.splitBlock(true); this.splitBlock(true);