0
Fork 0
mirror of https://github.com/project-zot/zot.git synced 2025-01-06 22:40:28 -05:00
zot/pkg/extensions/search
peusebiu 7642e5af98
fix(scheduler): fix data race (#2085)
* fix(scheduler): data race when pushing new tasks

the problem here is that scheduler can be closed in two ways:
- canceling the context given as argument to scheduler.RunScheduler()
- running scheduler.Shutdown()

because of this shutdown can trigger a data race between calling scheduler.inShutdown()
and actually pushing tasks into the pool workers

solved that by keeping a quit channel and listening on both quit channel and ctx.Done()
and closing the worker chan and scheduler afterwards.

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>

* refactor(scheduler): refactor into a single shutdown

before this we could stop scheduler either by closing the context
provided to RunScheduler(ctx) or by running Shutdown().

simplify things by getting rid of the external context in RunScheduler().
keep an internal context in the scheduler itself and pass it down to all tasks.

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>

---------

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
2023-12-11 10:00:34 -08:00
..
convert refactor(test): add lint rule for messages starting with the component (#2045) 2023-12-08 10:05:02 +02:00
cve fix(scheduler): fix data race (#2085) 2023-12-11 10:00:34 -08:00
gql_generated chore: fix dependabot alerts (#2113) 2023-12-04 11:28:01 -08:00
pagination fix(cve): cummulative fixes and improvements for CVE scanning logic (#1810) 2023-09-17 15:12:20 -07:00
digest_test.go refactor(pkg/test): split logic in pkg/test/common.go into multiple packages (#1861) 2023-09-27 11:34:48 -07:00
gqlgen.yml
resolver.go refactor(test): add lint rule for messages starting with the component (#2045) 2023-12-08 10:05:02 +02:00
resolver_test.go feat(metadb): add support for querying for images by a blob digest (#2077) 2023-11-27 08:52:52 -08:00
schema.graphql feat(cve): expand search domain to cve description and package info (#2086) 2023-11-29 20:59:00 +02:00
schema.resolvers.go refactor(test): add lint rule for messages starting with the component (#2045) 2023-12-08 10:05:02 +02:00
search.md docs: update graphql examples to match current implementation (#2038) 2023-11-13 09:58:15 -08:00
search_test.go fix(scheduler): fix data race (#2085) 2023-12-11 10:00:34 -08:00
userprefs_test.go refactor(metadb): improve UX by speeding up metadb serialize/deserialize (#1842) 2023-10-30 13:06:04 -07:00