0
Fork 0
mirror of https://github.com/project-zot/zot.git synced 2024-12-30 22:34:13 -05:00
zot/pkg
peusebiu 7642e5af98
fix(scheduler): fix data race (#2085)
* fix(scheduler): data race when pushing new tasks

the problem here is that scheduler can be closed in two ways:
- canceling the context given as argument to scheduler.RunScheduler()
- running scheduler.Shutdown()

because of this shutdown can trigger a data race between calling scheduler.inShutdown()
and actually pushing tasks into the pool workers

solved that by keeping a quit channel and listening on both quit channel and ctx.Done()
and closing the worker chan and scheduler afterwards.

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>

* refactor(scheduler): refactor into a single shutdown

before this we could stop scheduler either by closing the context
provided to RunScheduler(ctx) or by running Shutdown().

simplify things by getting rid of the external context in RunScheduler().
keep an internal context in the scheduler itself and pass it down to all tasks.

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>

---------

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
2023-12-11 10:00:34 -08:00
..
api fix(scheduler): fix data race (#2085) 2023-12-11 10:00:34 -08:00
cli fix(scheduler): fix data race (#2085) 2023-12-11 10:00:34 -08:00
common feat(scheduler): gracefully shutdown (#1951) 2023-11-24 00:40:10 -08:00
compliance fix(scheduler): fix data race (#2085) 2023-12-11 10:00:34 -08:00
debug fix: tests refactoring (#1950) 2023-10-26 11:20:39 +03:00
exporter fix(scheduler): fix data race (#2085) 2023-12-11 10:00:34 -08:00
extensions fix(scheduler): fix data race (#2085) 2023-12-11 10:00:34 -08:00
log refactor(test): add lint rule for messages starting with the component (#2045) 2023-12-08 10:05:02 +02:00
meta fix(scheduler): fix data race (#2085) 2023-12-11 10:00:34 -08:00
regexp chore(trivy): update trivy version and enforce OCI compliant repo names in local image storage (#1068) 2023-01-18 08:24:44 -08:00
requestcontext refactor(authz): use a struct for user access control info operations (#1682) 2023-09-01 11:13:53 -07:00
retention feat(scheduler): gracefully shutdown (#1951) 2023-11-24 00:40:10 -08:00
scheduler fix(scheduler): fix data race (#2085) 2023-12-11 10:00:34 -08:00
storage fix(scheduler): fix data race (#2085) 2023-12-11 10:00:34 -08:00
test fix(scheduler): fix data race (#2085) 2023-12-11 10:00:34 -08:00