mirror of
https://github.com/project-zot/zot.git
synced 2024-12-16 21:56:37 -05:00
fix issue and PR templates
Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
This commit is contained in:
parent
10f0e6c307
commit
e767cb456c
2 changed files with 5 additions and 26 deletions
18
.github/ISSUE_TEMPLATE/bug_report.md
vendored
18
.github/ISSUE_TEMPLATE/bug_report.md
vendored
|
@ -12,10 +12,9 @@ A clear and concise description of what the bug is.
|
||||||
|
|
||||||
**To Reproduce**
|
**To Reproduce**
|
||||||
Steps to reproduce the behavior:
|
Steps to reproduce the behavior:
|
||||||
1. Go to '...'
|
1. Configuration
|
||||||
2. Click on '....'
|
2. Client tool used
|
||||||
3. Scroll down to '....'
|
3. See error
|
||||||
4. See error
|
|
||||||
|
|
||||||
**Expected behavior**
|
**Expected behavior**
|
||||||
A clear and concise description of what you expected to happen.
|
A clear and concise description of what you expected to happen.
|
||||||
|
@ -23,16 +22,5 @@ A clear and concise description of what you expected to happen.
|
||||||
**Screenshots**
|
**Screenshots**
|
||||||
If applicable, add screenshots to help explain your problem.
|
If applicable, add screenshots to help explain your problem.
|
||||||
|
|
||||||
**Desktop (please complete the following information):**
|
|
||||||
- OS: [e.g. iOS]
|
|
||||||
- Browser [e.g. chrome, safari]
|
|
||||||
- Version [e.g. 22]
|
|
||||||
|
|
||||||
**Smartphone (please complete the following information):**
|
|
||||||
- Device: [e.g. iPhone6]
|
|
||||||
- OS: [e.g. iOS8.1]
|
|
||||||
- Browser [e.g. stock browser, safari]
|
|
||||||
- Version [e.g. 22]
|
|
||||||
|
|
||||||
**Additional context**
|
**Additional context**
|
||||||
Add any other context about the problem here.
|
Add any other context about the problem here.
|
||||||
|
|
13
.github/PULL_REQUEST_TEMPLATE.md
vendored
13
.github/PULL_REQUEST_TEMPLATE.md
vendored
|
@ -2,10 +2,6 @@
|
||||||
1. Ensure you have added the unit tests for your changes.
|
1. Ensure you have added the unit tests for your changes.
|
||||||
2. Ensure you have included output of manual testing done in the Testing section.
|
2. Ensure you have included output of manual testing done in the Testing section.
|
||||||
3. Ensure number of lines of code for new or existing methods are within the reasonable limit.
|
3. Ensure number of lines of code for new or existing methods are within the reasonable limit.
|
||||||
4. Ensure your change works on existing clusters after upgrade.
|
|
||||||
5. If your mounting any new file or directory, make sure its not opening up any security attack vector for aws-vpc-cni-k8s modules.
|
|
||||||
6. If AWS apis are invoked, document the call rate in the description section.
|
|
||||||
7. If EC2 Metadata apis are invoked, ensure to handle stale information returned from metadata.
|
|
||||||
-->
|
-->
|
||||||
**What type of PR is this?**
|
**What type of PR is this?**
|
||||||
|
|
||||||
|
@ -23,7 +19,7 @@ feature
|
||||||
**What does this PR do / Why do we need it**:
|
**What does this PR do / Why do we need it**:
|
||||||
|
|
||||||
|
|
||||||
**If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue**:
|
**If an issue # is not available please add repro steps and logs showing the issue**:
|
||||||
|
|
||||||
|
|
||||||
**Testing done on this change**:
|
**Testing done on this change**:
|
||||||
|
@ -38,14 +34,9 @@ Test case added to lib/integration.sh
|
||||||
If no, create an issue with enhancement/testing label
|
If no, create an issue with enhancement/testing label
|
||||||
-->
|
-->
|
||||||
|
|
||||||
**Will this break upgrades or downgrades. Has updating a running cluster been tested?**:
|
**Will this break upgrades or downgrades?**
|
||||||
|
|
||||||
|
|
||||||
**Does this change require updates to the CNI daemonset config files to work?**:
|
|
||||||
<!--
|
|
||||||
If this change does not work with a "kubectl patch" of the image tag, please explain why.
|
|
||||||
-->
|
|
||||||
|
|
||||||
**Does this PR introduce any user-facing change?**:
|
**Does this PR introduce any user-facing change?**:
|
||||||
<!--
|
<!--
|
||||||
If yes, a release note update is required:
|
If yes, a release note update is required:
|
||||||
|
|
Loading…
Reference in a new issue