From e767cb456cd5be23ed41e6f31f6f472af44f1802 Mon Sep 17 00:00:00 2001 From: Ramkumar Chinchani Date: Wed, 16 Mar 2022 20:57:54 +0000 Subject: [PATCH] fix issue and PR templates Signed-off-by: Ramkumar Chinchani --- .github/ISSUE_TEMPLATE/bug_report.md | 18 +++--------------- .github/PULL_REQUEST_TEMPLATE.md | 13 ++----------- 2 files changed, 5 insertions(+), 26 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index dd84ea78..d2e45dd4 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -12,10 +12,9 @@ A clear and concise description of what the bug is. **To Reproduce** Steps to reproduce the behavior: -1. Go to '...' -2. Click on '....' -3. Scroll down to '....' -4. See error +1. Configuration +2. Client tool used +3. See error **Expected behavior** A clear and concise description of what you expected to happen. @@ -23,16 +22,5 @@ A clear and concise description of what you expected to happen. **Screenshots** If applicable, add screenshots to help explain your problem. -**Desktop (please complete the following information):** - - OS: [e.g. iOS] - - Browser [e.g. chrome, safari] - - Version [e.g. 22] - -**Smartphone (please complete the following information):** - - Device: [e.g. iPhone6] - - OS: [e.g. iOS8.1] - - Browser [e.g. stock browser, safari] - - Version [e.g. 22] - **Additional context** Add any other context about the problem here. diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 07522221..bfdc15d5 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,10 +2,6 @@ 1. Ensure you have added the unit tests for your changes. 2. Ensure you have included output of manual testing done in the Testing section. 3. Ensure number of lines of code for new or existing methods are within the reasonable limit. -4. Ensure your change works on existing clusters after upgrade. -5. If your mounting any new file or directory, make sure its not opening up any security attack vector for aws-vpc-cni-k8s modules. -6. If AWS apis are invoked, document the call rate in the description section. -7. If EC2 Metadata apis are invoked, ensure to handle stale information returned from metadata. --> **What type of PR is this?** @@ -23,7 +19,7 @@ feature **What does this PR do / Why do we need it**: -**If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue**: +**If an issue # is not available please add repro steps and logs showing the issue**: **Testing done on this change**: @@ -38,14 +34,9 @@ Test case added to lib/integration.sh If no, create an issue with enhancement/testing label --> -**Will this break upgrades or downgrades. Has updating a running cluster been tested?**: +**Will this break upgrades or downgrades?** -**Does this change require updates to the CNI daemonset config files to work?**: - - **Does this PR introduce any user-facing change?**: