Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-03-31 22:51:25 -05:00
Code Issues Activity

refactor(core): per comment

Browse source
This commit is contained in:
Gao Sun 2022-04-20 15:59:14 +08:00
parent f4a656300e
commit 7e14ccb1a9
No known key found for this signature in database
GPG key ID: 13EBE123E4773688
2 changed files with 14 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
packages/core/src/database/insert-into.test.ts
View file

@ -8,6 +8,8 @@ import { createTestPool } from '@/utils/test-utils';
import { buildInsertInto } from './insert-into';
import { convertToIdentifiers } from './utils';
const poolSpy = jest.spyOn(envSet, 'pool', 'get');
const buildExpectedInsertIntoSql = (keys: string[]) => [
// eslint-disable-next-line sql/no-unsafe-query
`insert into "users" (${keys.map((key) => `"${decamelize(key)}"`).join(', ')})`,
@ -19,7 +21,7 @@ describe('buildInsertInto()', () => {
const user: CreateUser = { id: 'foo', username: '456' };
const expectInsertIntoSql = buildExpectedInsertIntoSql(Object.keys(user));
const pool = createTestPool(expectInsertIntoSql.join('\n'));
jest.spyOn(envSet, 'pool', 'get').mockReturnValue(pool);
poolSpy.mockReturnValue(pool);
const insertInto = buildInsertInto(Users);
await expect(insertInto(user)).resolves.toBe(undefined);
@ -35,7 +37,7 @@ describe('buildInsertInto()', () => {
'set "primary_email"=excluded."primary_email"',
].join('\n')
);
jest.spyOn(envSet, 'pool', 'get').mockReturnValue(pool);
poolSpy.mockReturnValue(pool);
const { fields } = convertToIdentifiers(Users);
const insertInto = buildInsertInto(Users, {
@ -58,7 +60,7 @@ describe('buildInsertInto()', () => {
primaryEmail: String(primaryEmail),
})
);
jest.spyOn(envSet, 'pool', 'get').mockReturnValue(pool);
poolSpy.mockReturnValue(pool);
const insertInto = buildInsertInto(Users, { returning: true });
await expect(
@ -70,7 +72,7 @@ describe('buildInsertInto()', () => {
const user: CreateUser = { id: 'foo', username: '123', primaryEmail: 'foo@bar.com' };
const expectInsertIntoSql = buildExpectedInsertIntoSql(Object.keys(user));
const pool = createTestPool([...expectInsertIntoSql, 'returning *'].join('\n'));
jest.spyOn(envSet, 'pool', 'get').mockReturnValue(pool);
poolSpy.mockReturnValue(pool);
const insertInto = buildInsertInto(Users, { returning: true });
const dataToInsert = { id: 'foo', username: '123', primaryEmail: 'foo@bar.com' };

14
packages/core/src/database/update-where.test.ts
View file

@ -6,12 +6,14 @@ import { createTestPool } from '@/utils/test-utils';
import { buildUpdateWhere } from './update-where';
const poolSpy = jest.spyOn(envSet, 'pool', 'get');
describe('buildUpdateWhere()', () => {
it('resolves a promise with `undefined` when `returning` is false', async () => {
const pool = createTestPool(
'update "users"\nset "username"=$1\nwhere "id"=$2 and "username"=$3'
);
jest.spyOn(envSet, 'pool', 'get').mockReturnValue(pool);
poolSpy.mockReturnValue(pool);
const updateWhere = buildUpdateWhere(Users);
await expect(
@ -32,7 +34,7 @@ describe('buildUpdateWhere()', () => {
primaryEmail: String(primaryEmail),
})
);
jest.spyOn(envSet, 'pool', 'get').mockReturnValue(pool);
poolSpy.mockReturnValue(pool);
const updateWhere = buildUpdateWhere(Users, true);
await expect(
@ -48,7 +50,7 @@ describe('buildUpdateWhere()', () => {
customClientMetadata: String(customClientMetadata),
})
);
jest.spyOn(envSet, 'pool', 'get').mockReturnValue(pool);
poolSpy.mockReturnValue(pool);
const updateWhere = buildUpdateWhere(Applications, true);
await expect(
@ -63,7 +65,7 @@ describe('buildUpdateWhere()', () => {
const pool = createTestPool(
'update "users"\nset "username"=$1\nwhere "id"=$2 and "username"=$3'
);
jest.spyOn(envSet, 'pool', 'get').mockReturnValue(pool);
poolSpy.mockReturnValue(pool);
const updateWhere = buildUpdateWhere(Users);
@ -77,7 +79,7 @@ describe('buildUpdateWhere()', () => {
it('throws `entity.not_exists_with_id` error with `undefined` when `returning` is true', async () => {
const pool = createTestPool('update "users"\nset "username"=$1\nwhere "id"=$2\nreturning *');
jest.spyOn(envSet, 'pool', 'get').mockReturnValue(pool);
poolSpy.mockReturnValue(pool);
const updateWhere = buildUpdateWhere(Users, true);
const updateWhereData = { set: { username: '123' }, where: { id: 'foo' } };
@ -91,7 +93,7 @@ describe('buildUpdateWhere()', () => {
const pool = createTestPool(
'update "users"\nset "username"=$1\nwhere "username"=$2\nreturning *'
);
jest.spyOn(envSet, 'pool', 'get').mockReturnValue(pool);
poolSpy.mockReturnValue(pool);
const updateWhere = buildUpdateWhere(Users, true);
const updateData = { set: { username: '123' }, where: { username: 'foo' } };