From 7e14ccb1a9a0bdf7067622a5afb0dc2f0a3111b8 Mon Sep 17 00:00:00 2001
From: Gao Sun <gao@silverhand.io>
Date: Wed, 20 Apr 2022 15:59:14 +0800
Subject: [PATCH] refactor(core): per comment

---
 packages/core/src/database/insert-into.test.ts  | 10 ++++++----
 packages/core/src/database/update-where.test.ts | 14 ++++++++------
 2 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/packages/core/src/database/insert-into.test.ts b/packages/core/src/database/insert-into.test.ts
index 2fc6295f6..a95a8ad35 100644
--- a/packages/core/src/database/insert-into.test.ts
+++ b/packages/core/src/database/insert-into.test.ts
@@ -8,6 +8,8 @@ import { createTestPool } from '@/utils/test-utils';
 import { buildInsertInto } from './insert-into';
 import { convertToIdentifiers } from './utils';
 
+const poolSpy = jest.spyOn(envSet, 'pool', 'get');
+
 const buildExpectedInsertIntoSql = (keys: string[]) => [
   // eslint-disable-next-line sql/no-unsafe-query
   `insert into "users" (${keys.map((key) => `"${decamelize(key)}"`).join(', ')})`,
@@ -19,7 +21,7 @@ describe('buildInsertInto()', () => {
     const user: CreateUser = { id: 'foo', username: '456' };
     const expectInsertIntoSql = buildExpectedInsertIntoSql(Object.keys(user));
     const pool = createTestPool(expectInsertIntoSql.join('\n'));
-    jest.spyOn(envSet, 'pool', 'get').mockReturnValue(pool);
+    poolSpy.mockReturnValue(pool);
 
     const insertInto = buildInsertInto(Users);
     await expect(insertInto(user)).resolves.toBe(undefined);
@@ -35,7 +37,7 @@ describe('buildInsertInto()', () => {
         'set "primary_email"=excluded."primary_email"',
       ].join('\n')
     );
-    jest.spyOn(envSet, 'pool', 'get').mockReturnValue(pool);
+    poolSpy.mockReturnValue(pool);
 
     const { fields } = convertToIdentifiers(Users);
     const insertInto = buildInsertInto(Users, {
@@ -58,7 +60,7 @@ describe('buildInsertInto()', () => {
         primaryEmail: String(primaryEmail),
       })
     );
-    jest.spyOn(envSet, 'pool', 'get').mockReturnValue(pool);
+    poolSpy.mockReturnValue(pool);
 
     const insertInto = buildInsertInto(Users, { returning: true });
     await expect(
@@ -70,7 +72,7 @@ describe('buildInsertInto()', () => {
     const user: CreateUser = { id: 'foo', username: '123', primaryEmail: 'foo@bar.com' };
     const expectInsertIntoSql = buildExpectedInsertIntoSql(Object.keys(user));
     const pool = createTestPool([...expectInsertIntoSql, 'returning *'].join('\n'));
-    jest.spyOn(envSet, 'pool', 'get').mockReturnValue(pool);
+    poolSpy.mockReturnValue(pool);
 
     const insertInto = buildInsertInto(Users, { returning: true });
     const dataToInsert = { id: 'foo', username: '123', primaryEmail: 'foo@bar.com' };
diff --git a/packages/core/src/database/update-where.test.ts b/packages/core/src/database/update-where.test.ts
index 2a610374e..520e6ad2a 100644
--- a/packages/core/src/database/update-where.test.ts
+++ b/packages/core/src/database/update-where.test.ts
@@ -6,12 +6,14 @@ import { createTestPool } from '@/utils/test-utils';
 
 import { buildUpdateWhere } from './update-where';
 
+const poolSpy = jest.spyOn(envSet, 'pool', 'get');
+
 describe('buildUpdateWhere()', () => {
   it('resolves a promise with `undefined` when `returning` is false', async () => {
     const pool = createTestPool(
       'update "users"\nset "username"=$1\nwhere "id"=$2 and "username"=$3'
     );
-    jest.spyOn(envSet, 'pool', 'get').mockReturnValue(pool);
+    poolSpy.mockReturnValue(pool);
 
     const updateWhere = buildUpdateWhere(Users);
     await expect(
@@ -32,7 +34,7 @@ describe('buildUpdateWhere()', () => {
         primaryEmail: String(primaryEmail),
       })
     );
-    jest.spyOn(envSet, 'pool', 'get').mockReturnValue(pool);
+    poolSpy.mockReturnValue(pool);
 
     const updateWhere = buildUpdateWhere(Users, true);
     await expect(
@@ -48,7 +50,7 @@ describe('buildUpdateWhere()', () => {
         customClientMetadata: String(customClientMetadata),
       })
     );
-    jest.spyOn(envSet, 'pool', 'get').mockReturnValue(pool);
+    poolSpy.mockReturnValue(pool);
 
     const updateWhere = buildUpdateWhere(Applications, true);
     await expect(
@@ -63,7 +65,7 @@ describe('buildUpdateWhere()', () => {
     const pool = createTestPool(
       'update "users"\nset "username"=$1\nwhere "id"=$2 and "username"=$3'
     );
-    jest.spyOn(envSet, 'pool', 'get').mockReturnValue(pool);
+    poolSpy.mockReturnValue(pool);
 
     const updateWhere = buildUpdateWhere(Users);
 
@@ -77,7 +79,7 @@ describe('buildUpdateWhere()', () => {
 
   it('throws `entity.not_exists_with_id` error with `undefined` when `returning` is true', async () => {
     const pool = createTestPool('update "users"\nset "username"=$1\nwhere "id"=$2\nreturning *');
-    jest.spyOn(envSet, 'pool', 'get').mockReturnValue(pool);
+    poolSpy.mockReturnValue(pool);
 
     const updateWhere = buildUpdateWhere(Users, true);
     const updateWhereData = { set: { username: '123' }, where: { id: 'foo' } };
@@ -91,7 +93,7 @@ describe('buildUpdateWhere()', () => {
     const pool = createTestPool(
       'update "users"\nset "username"=$1\nwhere "username"=$2\nreturning *'
     );
-    jest.spyOn(envSet, 'pool', 'get').mockReturnValue(pool);
+    poolSpy.mockReturnValue(pool);
 
     const updateWhere = buildUpdateWhere(Users, true);
     const updateData = { set: { username: '123' }, where: { username: 'foo' } };