Infrastructure/logto
0
Fork 0
mirror of https://github.com/logto-io/logto.git synced 2025-01-27 21:39:16 -05:00
Code Issues Activity

fix(ui): add sandbox props to iframe (#1757)

Browse source 
add sandbox props to iframe
This commit is contained in:
simeng-li 2022-08-10 10:59:59 +08:00 • committed by GitHub
parent ba50de5d66
commit 62d2afe957
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/ui/src/components/ConfirmModal/IframeConfirmModal.tsx
View file

@ -1,5 +1,3 @@
// FIXME: @simeng
/* eslint-disable react/iframe-missing-sandbox */
import classNames from 'classnames'; import classNames from 'classnames';
import { useState } from 'react'; import { useState } from 'react';
import { useTranslation } from 'react-i18next'; import { useTranslation } from 'react-i18next';
@ -37,6 +35,7 @@ const IframeConfirmModal = ({
<div className={styles.content}> <div className={styles.content}>
{isLoading && <LoadingIcon />} {isLoading && <LoadingIcon />}
<iframe <iframe
sandbox={undefined}
className={isLoading ? styles.hidden : undefined} className={isLoading ? styles.hidden : undefined}
role="iframe" role="iframe"
src={url} src={url}
@ -64,4 +63,3 @@ const IframeConfirmModal = ({
}; };
export default IframeConfirmModal; export default IframeConfirmModal;
/* eslint-enable react/iframe-missing-sandbox */

2
packages/ui/src/include.d/dom.d.ts vendored
View file

@ -73,7 +73,7 @@ type AutoCompleteType =
| 'tel-country-code' | 'tel-country-code'
| 'tel-national'; | 'tel-national';
// TODO: @simeng remove me // LOG-2893 should remove this once we have API response guard
interface Body { interface Body {
json<T>(): Promise<T>; json<T>(): Promise<T>;
} }