From 62d2afe9579334547b7ff5b803299b89933a5bd8 Mon Sep 17 00:00:00 2001
From: simeng-li <simeng@silverhand.io>
Date: Wed, 10 Aug 2022 10:59:59 +0800
Subject: [PATCH] fix(ui): add sandbox props to iframe (#1757)

add sandbox props to iframe
---
 .../ui/src/components/ConfirmModal/IframeConfirmModal.tsx     | 4 +---
 packages/ui/src/include.d/dom.d.ts                            | 2 +-
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/packages/ui/src/components/ConfirmModal/IframeConfirmModal.tsx b/packages/ui/src/components/ConfirmModal/IframeConfirmModal.tsx
index fb1cfae98..30bb13adf 100644
--- a/packages/ui/src/components/ConfirmModal/IframeConfirmModal.tsx
+++ b/packages/ui/src/components/ConfirmModal/IframeConfirmModal.tsx
@@ -1,5 +1,3 @@
-// FIXME: @simeng
-/* eslint-disable react/iframe-missing-sandbox */
 import classNames from 'classnames';
 import { useState } from 'react';
 import { useTranslation } from 'react-i18next';
@@ -37,6 +35,7 @@ const IframeConfirmModal = ({
         <div className={styles.content}>
           {isLoading && <LoadingIcon />}
           <iframe
+            sandbox={undefined}
             className={isLoading ? styles.hidden : undefined}
             role="iframe"
             src={url}
@@ -64,4 +63,3 @@ const IframeConfirmModal = ({
 };
 
 export default IframeConfirmModal;
-/* eslint-enable react/iframe-missing-sandbox */
diff --git a/packages/ui/src/include.d/dom.d.ts b/packages/ui/src/include.d/dom.d.ts
index 4a8e47150..9d2d7a6f5 100644
--- a/packages/ui/src/include.d/dom.d.ts
+++ b/packages/ui/src/include.d/dom.d.ts
@@ -73,7 +73,7 @@ type AutoCompleteType =
   | 'tel-country-code'
   | 'tel-national';
 
-// TODO: @simeng remove me
+// LOG-2893 should remove this once we have API response guard
 interface Body {
   json<T>(): Promise<T>;
 }