0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
ghost/core/server/api/v3
Kevin Ansfield a485509a2f
🐛 Fixed GA labs flags not appearing enabled in settings API (#13681)
no issue

The way GA flags were introduced means that they stop existing in the `'labs'` setting in the db and are instead forced to always return `true` when checking the flag in the labs service. However, Admin which uses the flags fetches them via the `/settings/` API endpoint which was only returning the raw labs setting db value meaning GA flags appeared to be disabled unless the flag had previously been enabled and no settings save had occured.

- updated the settings bread service to replace the labs setting value with the JSON stringified output of `labs.getAll()` which is the ultimate source-of-truth for a feature being enabled/disabled
  - extracted `browse()` behaviour to an internal `_formatBrowse()` method so we can apply the same filtering/modification for output of `browse()` and `edit()`

Co-authored-by: Fabien O'Carroll <fabien@allou.is>
2021-10-22 19:59:13 +01:00
..
utils 🐛 Fixed GA labs flags not appearing enabled in settings API (#13681) 2021-10-22 19:59:13 +01:00
actions.js
authentication.js Replaced i18n with tpl in core/server/api/v3 (#13548) 2021-10-12 08:33:33 +01:00
authors-public.js Replaced i18n with tpl in core/server/api/v3 (#13548) 2021-10-12 08:33:33 +01:00
config.js Fixed max-api-complexity linting warnings for site and config APIs (#12982) 2021-05-26 12:10:19 +01:00
db.js Refactored exporter to use "allowlist" table filtering 2021-03-25 16:46:56 +13:00
email-preview.js Replace i18n with tpl in email-preview.js (#13475) 2021-10-07 09:22:32 +01:00
email.js Replaced i18n with tpl in core/server/api/v3 (#13548) 2021-10-12 08:33:33 +01:00
identities.js Moved settings/cache to shared/settings-cache 2021-06-30 15:49:10 +01:00
images.js Made storage calls related to images use "images" feature 2021-10-21 20:22:45 +13:00
index.js Added eslint override for index.js false positives 2021-08-13 12:48:49 +01:00
integrations.js Replaced i18n with tpl in core/server/api/v3 (#13548) 2021-10-12 08:33:33 +01:00
invites.js Replace i18n with tpl in core/server/api/v3/invites.js (#13587) 2021-10-13 09:07:57 +01:00
labels.js Replaced i18n with tpl in core/server/api/v3 (#13548) 2021-10-12 08:33:33 +01:00
mail.js Replace the deprecated dependency i18n with tpl in mail.js files (#13449) 2021-10-05 10:40:00 +01:00
members.js Replaced i18n.t w/ tpl helper in v3/members.js (#13480) 2021-10-08 15:25:06 +01:00
memberSigninUrls.js Fixed duplicate message due to bad merge 2021-10-13 09:17:01 +01:00
membersStripeConnect.js
notifications.js Fixed error being saved in notification settings 2021-06-03 12:54:09 +04:00
oembed.js Refactored tpl to never be used in DI 2021-10-11 15:19:54 +01:00
pages-public.js Replace i18n with tpl in api/v3/pages-public.js (#13586) 2021-10-13 09:07:42 +01:00
pages.js Replace i18n with tpl in api/v3/pages.js (#13585) 2021-10-13 09:06:53 +01:00
posts-public.js Replaced i18n w/ tpl in /core/server/api/v3/posts-public.js (#13527) 2021-10-11 14:40:01 +01:00
posts.js Replaced i18n.t w/ tpl helper in v3/posts.js file (#13580) 2021-10-13 08:58:34 +01:00
preview.js Replaced i18n w/ tpl in /core/server/api/v3/preview.js (#13526) 2021-10-11 14:39:36 +01:00
redirects.js Simplified redirects module api 2021-09-27 19:39:47 +02:00
roles.js
schedules.js Migrated schedules v2/v3 APIs to match refactor in canary 2021-09-04 07:49:11 +12:00
session.js Replaced i18n w/ tpl in /core/server/api/v3/session.js (#13525) 2021-10-11 14:39:19 +01:00
settings-public.js Moved settings/cache to shared/settings-cache 2021-06-30 15:49:10 +01:00
settings.js Replaced i18n.t w/ tpl in v3/settings.js (#13551) 2021-10-12 08:36:11 +01:00
site.js Fixed max-api-complexity linting warnings for site and config APIs (#12982) 2021-05-26 12:10:19 +01:00
slack.js Added comments to all usages of lib/common/events 2021-07-07 16:02:44 +01:00
slugs.js Replaced i18n with tpl in /core/server/api/v3/slugs.js (#13524) 2021-10-11 14:37:44 +01:00
snippets.js Removed use of i18n in snippets controllers 2021-07-19 11:08:55 +01:00
tags-public.js Replace the dependency i18n with tpl in all tags.js files (#13447) 2021-10-05 10:38:13 +01:00
tags.js Replace the dependency i18n with tpl in all tags.js files (#13447) 2021-10-05 10:38:13 +01:00
themes.js Added comments to all usages of lib/common/events 2021-07-07 16:02:44 +01:00
users.js Replace the deprecated dependency i18n with tpl in users.js files (#13446) 2021-10-05 10:37:05 +01:00
webhooks.js Replaced i18n.t w/ tpl helper in webhooks (#13482) 2021-10-08 15:26:44 +01:00