0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
ghost/core
Kevin Ansfield a485509a2f
🐛 Fixed GA labs flags not appearing enabled in settings API (#13681)
no issue

The way GA flags were introduced means that they stop existing in the `'labs'` setting in the db and are instead forced to always return `true` when checking the flag in the labs service. However, Admin which uses the flags fetches them via the `/settings/` API endpoint which was only returning the raw labs setting db value meaning GA flags appeared to be disabled unless the flag had previously been enabled and no settings save had occured.

- updated the settings bread service to replace the labs setting value with the JSON stringified output of `labs.getAll()` which is the ultimate source-of-truth for a feature being enabled/disabled
  - extracted `browse()` behaviour to an internal `_formatBrowse()` method so we can apply the same filtering/modification for output of `browse()` and `edit()`

Co-authored-by: Fabien O'Carroll <fabien@allou.is>
2021-10-22 19:59:13 +01:00
..
client@56fc1aab98 Updated Admin to v4.20.0 2021-10-22 17:19:47 +01:00
frontend Renamed frontend/web/app to site 2021-10-21 19:54:50 +01:00
server 🐛 Fixed GA labs flags not appearing enabled in settings API (#13681) 2021-10-22 19:59:13 +01:00
shared Added Offers feature to Ghost 2021-10-22 17:55:34 +02:00
app.js Added Sentry to new boot process 2021-02-19 09:20:41 +00:00
boot.js Renamed bootstrap to routerManager 2021-10-19 07:29:09 +13:00
bridge.js Renamed frontend/web/app to site 2021-10-21 19:54:50 +01:00