0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
ghost/core/server/api/canary
Kevin Ansfield a485509a2f
🐛 Fixed GA labs flags not appearing enabled in settings API (#13681)
no issue

The way GA flags were introduced means that they stop existing in the `'labs'` setting in the db and are instead forced to always return `true` when checking the flag in the labs service. However, Admin which uses the flags fetches them via the `/settings/` API endpoint which was only returning the raw labs setting db value meaning GA flags appeared to be disabled unless the flag had previously been enabled and no settings save had occured.

- updated the settings bread service to replace the labs setting value with the JSON stringified output of `labs.getAll()` which is the ultimate source-of-truth for a feature being enabled/disabled
  - extracted `browse()` behaviour to an internal `_formatBrowse()` method so we can apply the same filtering/modification for output of `browse()` and `edit()`

Co-authored-by: Fabien O'Carroll <fabien@allou.is>
2021-10-22 19:59:13 +01:00
..
utils 🐛 Fixed GA labs flags not appearing enabled in settings API (#13681) 2021-10-22 19:59:13 +01:00
actions.js
authentication.js Replaced i18n.t w/ tpl helper in authentication.js (#13402) 2021-10-04 09:54:15 +01:00
authors-public.js Replaced i18n.t w/ tpl helper (#13403) 2021-10-04 09:55:30 +01:00
config.js Fixed max-api-complexity linting warnings for site and config APIs (#12982) 2021-05-26 12:10:19 +01:00
custom-theme-settings.js Added API tests for custom theme settings (#13519) 2021-10-08 16:18:49 +01:00
db.js Update cache invalidation on several routes 2021-07-07 18:12:51 +02:00
email-post.js Replaced i18n.t w/ tpl helper in email-post.js and email-preview.js (#13418) 2021-10-04 09:57:08 +01:00
email-preview.js Replaced i18n.t w/ tpl helper in email-post.js and email-preview.js (#13418) 2021-10-04 09:57:08 +01:00
email.js Replaced i18n.t w/ tpl helper in email and integrations (#13424) 2021-10-04 10:02:27 +01:00
identities.js Moved settings/cache to shared/settings-cache 2021-06-30 15:49:10 +01:00
images.js Made storage calls related to images use "images" feature 2021-10-21 20:22:45 +13:00
index.js Added initial Offers API 2021-10-06 12:33:19 +02:00
integrations.js Replaced i18n.t w/ tpl helper in email and integrations (#13424) 2021-10-04 10:02:27 +01:00
invites.js Replaced i18n.t w/ tpl helper in invites.js (#13433) 2021-10-06 09:49:20 +01:00
labels.js Replaced i18n.t w/ tpl helper in invites.js (#13433) 2021-10-06 09:49:20 +01:00
mail.js Replaced i18n.t w/ tpl helper in mail.js 2021-10-05 09:43:47 +01:00
members.js Replaced i18n.t w/ tpl helper in members.js (#13456) 2021-10-06 11:40:32 +01:00
memberSigninUrls.js Replaced i18n.t w/ tpl helper in memberSigninUrls.js (#13462) 2021-10-06 11:41:37 +01:00
membersStripeConnect.js Added precondition for Stripe Connect Admin API 2021-05-20 12:08:45 +01:00
notifications.js Fixed error being saved in notification settings 2021-06-03 12:54:09 +04:00
oembed.js Refactored tpl to never be used in DI 2021-10-11 15:19:54 +01:00
offers.js Added 404 handling for edit Offer 2021-10-22 16:16:39 +02:00
pages-public.js Replaced i18n.t w/ tpl helper in pages-public.js 2021-10-07 09:14:15 +01:00
pages.js Replaced i18n.t w/ tpl helper in pages.js 2021-10-07 09:14:15 +01:00
posts-public.js Replaced i18n.t w/ tpl helper in core/server/api/canary/* (#13521) 2021-10-11 14:35:43 +01:00
posts.js Replaced i18n.t w/ tpl helper in posts.js (#13455) 2021-10-06 08:59:21 +01:00
preview.js Replaced i18n.t w/ tpl helper in preview.js (#13494) 2021-10-08 15:32:51 +01:00
products-public.js Supported monthly & yearly price in Products API 2021-06-03 17:08:02 +01:00
products.js Replaced i18n.t w/ tpl helper in core/server/api/canary/* (#13521) 2021-10-11 14:35:43 +01:00
redirects.js Simplified redirects module api 2021-09-27 19:39:47 +02:00
roles.js
schedules.js Removed method complexity in schedules API controller 2021-09-04 07:49:11 +12:00
session.js Replaced i18n with tpl core/server/api/canary/session.js (#13487) 2021-10-08 15:11:26 +01:00
settings-public.js Moved settings/cache to shared/settings-cache 2021-06-30 15:49:10 +01:00
settings.js replaced i18n with tpl (#13484) 2021-10-07 16:51:28 +01:00
site.js Fixed max-api-complexity linting warnings for site and config APIs (#12982) 2021-05-26 12:10:19 +01:00
slack.js Added comments to all usages of lib/common/events 2021-07-07 16:02:44 +01:00
slugs.js Replaced i18n.t w/ tpl helper in slugs.js (#13463) 2021-10-06 11:42:33 +01:00
snippets.js Removed use of i18n in snippets controllers 2021-07-19 11:08:55 +01:00
tags-public.js Replaced i18n.t w/ tpl helper in core/server/api/canary/* (#13521) 2021-10-11 14:35:43 +01:00
tags.js Replaced i18n.t w/ tpl in tags.js (#13428) 2021-10-05 10:00:00 +01:00
themes.js Removed method complexity in themes API controller 2021-09-03 20:33:28 +04:00
users.js Replaced i18n.t w/ tpl helper in core/server/api/canary/* (#13521) 2021-10-11 14:35:43 +01:00
webhooks.js Replaced i18n with tpl in webhooks.js 2021-10-07 09:16:20 +01:00