Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
Code Issues Activity
ghost/core/test/regression
History
kirrg001 449bae9a48 🐛 Fixed missing "value" property for settings Admin API v2 
closes #10518

- we had a very generic logic to remove "unwanted" null values
  - copied from v0.1
  - originally added in 7d4107fec4
- this logic transformed: settings = [{key: 'key', value: null}] to [{key: 'key'}], which is wrong
- i've removed this generic logic completely, because i don't know which purpose it serves
- if there a specific case where we want to remove null values, we should either use the JSON schema or use a specific serializer for the target resource
- added tests to proof that settings API behaves as it should
- one test failed because we removed the isNull logic -> if you send published_at = null on a published post
  - the model layer has a piece of logic to force a date if you set published_at to null if the status is published
  - protected
2019-03-04 20:06:53 +01:00
..
api 🐛 Fixed missing "value" property for settings Admin API v2 2019-03-04 20:06:53 +01:00
apps/subscribers
exporter
importer Fixed regression tests for importer 2019-02-26 11:58:37 +07:00
migrations Added members permission migrations 2019-02-26 15:43:36 +07:00
models 🐛 Fixed plaintext field not being cleared when post body is removed 2019-03-04 14:03:44 +00:00
site 🐛 Fixed empty amp page 2019-02-27 17:56:09 +01:00
update-check
README.md

README.md

Regression Tests

This folder should contain packages which we test in a cron job once per day. These tests should ensure that we don't break Ghost.

The goal is that most of these packages use Ghost's API's to test behaviours, otherwise transform the tests into unit tests.