0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
ghost/core
kirrg001 449bae9a48 🐛 Fixed missing "value" property for settings Admin API v2
closes #10518

- we had a very generic logic to remove "unwanted" null values
  - copied from v0.1
  - originally added in 7d4107fec4
- this logic transformed: settings = [{key: 'key', value: null}] to [{key: 'key'}], which is wrong
- i've removed this generic logic completely, because i don't know which purpose it serves
- if there a specific case where we want to remove null values, we should either use the JSON schema or use a specific serializer for the target resource
- added tests to proof that settings API behaves as it should
- one test failed because we removed the isNull logic -> if you send published_at = null on a published post
  - the model layer has a piece of logic to force a date if you set published_at to null if the status is published
  - protected
2019-03-04 20:06:53 +01:00
..
client@b99721d849 Updated Ghost-Admin to 2.16.2 2019-02-27 10:06:48 +01:00
server 🐛 Fixed missing "value" property for settings Admin API v2 2019-03-04 20:06:53 +01:00
test 🐛 Fixed missing "value" property for settings Admin API v2 2019-03-04 20:06:53 +01:00
index.js Changed where we trigger server start/stop announcement (#9815) 2018-08-22 13:28:31 +02:00