0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
ghost/core/server
kirrg001 449bae9a48 🐛 Fixed missing "value" property for settings Admin API v2
closes #10518

- we had a very generic logic to remove "unwanted" null values
  - copied from v0.1
  - originally added in 7d4107fec4
- this logic transformed: settings = [{key: 'key', value: null}] to [{key: 'key'}], which is wrong
- i've removed this generic logic completely, because i don't know which purpose it serves
- if there a specific case where we want to remove null values, we should either use the JSON schema or use a specific serializer for the target resource
- added tests to proof that settings API behaves as it should
- one test failed because we removed the isNull logic -> if you send published_at = null on a published post
  - the model layer has a piece of logic to force a date if you set published_at to null if the status is published
  - protected
2019-03-04 20:06:53 +01:00
..
adapters Removed superagent dependency (#10535) 2019-03-04 15:59:38 +08:00
api 🐛 Fixed missing "value" property for settings Admin API v2 2019-03-04 20:06:53 +01:00
apps Updated TODO's 2019-02-27 18:08:36 +01:00
config Improved Members security and performance (#10511) 2019-02-23 04:47:42 +01:00
data Added members permission migrations 2019-02-26 15:43:36 +07:00
helpers 🐛 Supported "false" as absolute attribute value (#10556) 2019-03-04 11:23:42 +01:00
lib Refactored members auth flow with dynamic settings 2019-02-26 15:43:36 +07:00
models 🐛 Fixed plaintext field not being cleared when post body is removed 2019-03-04 14:03:44 +00:00
public Removed change frequency and priority fields from sitemap generator (#9771) 2018-09-24 19:16:31 +02:00
services 🐛 Allowed data in collections to use specified key (#10559) 2019-03-04 17:53:58 +01:00
translations Updated Admin API key auth to require kid in header (#10538) 2019-02-26 11:03:47 +07:00
views Aliased {{@blog}} as {{@site}} in the theme API 2019-01-04 12:17:32 +00:00
web Refactored members auth flow with dynamic settings 2019-02-26 15:43:36 +07:00
analytics-events.js Added back "theme.uploaded" analytics event (#10450) 2019-02-05 17:38:40 +01:00
filters.js Switched to eslint-plugin-ghost (#9835) 2018-09-17 20:49:30 +02:00
ghost-server.js Switched to eslint-plugin-ghost (#9835) 2018-09-17 20:49:30 +02:00
index.js De-aliased api versions in codebase (#10375) 2019-01-14 19:49:55 +01:00
overrides.js Disabled bluebird debug logs 2018-08-13 14:01:31 +02:00
update-check.js De-aliased api versions in codebase (#10375) 2019-01-14 19:49:55 +01:00