Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-30 22:34:01 -05:00
Code Issues Activity
39698 commits 250 branches 1686 tags 519 MiB
Commit graph

39698 commits

This branch
This branch
All branches
Author SHA1 Message Date
Chris Raible
af0f26c75f
Added Dev Container setup (#21279) 
no issue

- Dev Containers let you work on Ghost in a consistent, isolated
environment with all the necessary development dependencies
pre-installed. VSCode (or Cursor) can effectively run _inside_ the
container, providing a local quality development environment while
working in a well-defined, isolated environment.
- For now the default setup only works with "Clone repository in
Container Volume" or "Clone PR in Container Volume" — this allows for a
super quick and simple setup. We can also introduce another
configuration to allow opening an existing local checkout in a Dev
Container, but that's not quite ready yet.
- This PR also added the `yarn clean:hard` command which: deletes all
node_modules, cleans the yarn cache, and cleans the NX cache. This will
be necessary for opening a local checkout in a Dev Container.
- To learn more about Dev Containers, read this guide from VSCode:
https://code.visualstudio.com/docs/devcontainers/containers#_personalizing-with-dotfile-repositories

---------

Co-authored-by: Joe Grigg <joe@ghost.org>
Co-authored-by: Steve Larson <9larsons@gmail.com>
 2024-10-24 11:15:08 -07:00
Fabien 'egg' O'Carroll
3f9fd2ad3f
Removed flaky playwright tests (#21397) 
refs INC-116

These tests are causing random failures on CI and stopping us from
merging PRs and creating releases. The aim is to unblock us and then
bring them back
 2024-10-24 23:59:54 +07:00
Sanne de Vries
4a5c8000bf
Fixed spacing issue with signup terms in Portal (#21390) 
REF DES-907
 2024-10-24 11:58:00 +00:00
Aileen Booker
c1ce322e86
Custom fonts (#21337) 
- Adding custom fonts for themes behind a feature flag
- Introduces new `@tryghost/custom-fonts` module to manage custom fonts
- UI updates for Branding and Theme settings

---------

Co-authored-by: Fabien O'Carroll <fabien@allou.is>
Co-authored-by: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
Co-authored-by: Peter Zimon <peter.zimon@gmail.com>
Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
Co-authored-by: Daniël van der Winden <danielvanderwinden@ghost.org>
 2024-10-24 07:43:08 -04:00
Ronald Langeveld
96239d31a6
Added Comments Sorting UI (#21375) 
ref PLG-220

- Added UI for Comments Sorting on the Comments UI App.

Co-authored-by: Sanne de Vries <65487235+sanne-san@users.noreply.github.com>
 2024-10-24 19:01:14 +09:00
Ronald Langeveld
cd3b1c3935
Bumped Portal to 2.45.1 (#21386) 
no issue

Co-authored-by: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
 2024-10-24 04:30:00 +00:00
Djordje Vlaisavljevic
880c88a184 Bumped admin-x-activitypub package 
no ref
 2024-10-23 19:44:40 +01:00
Djordje Vlaisavljevic
ba0c0439ab Made clicking users and posts on your profile bring up drawer view 
ref https://linear.app/ghost/issue/AP-510/clicking-on-following-and-followers-users-should-open-the-drawer-on, https://linear.app/ghost/issue/AP-511/clicking-on-items-in-posts-and-liked-tabs-of-your-profile-should-open
 2024-10-23 19:44:40 +01:00
Djordje Vlaisavljevic
79439b80c1 Made links inside posts look nicer 
ref https://linear.app/ghost/issue/AP-513/show-nicer-links-in-posts
 2024-10-23 19:44:40 +01:00
Djordje Vlaisavljevic
45df4bf860 Added ReplyBox to Articles viewed in drawer view 
ref https://linear.app/ghost/issue/AP-514/show-replybox-when-article-is-opened-in-drawer
 2024-10-23 19:44:40 +01:00
Michael Barrett
3d430b453f
Opened follow notifications in profile viewer in admin-x-activitypub (#21384) 
refs
[#479](https://linear.app/ghost/issue/AP-479/open-profile-viewer-when-clicking-follow-notifications)

Clicking on a follow notification will now open the profile viewer with
details of the profile of the user that followed you

---------

Co-authored-by: Djordje Vlaisavljevic <dzvlais@gmail.com>
 2024-10-23 14:26:31 +01:00
Ghost CI
ee980e3e34 Merged v5.97.3 into main 2024-10-23 12:30:55 +00:00
Ghost CI
e8b6f9ff84 v5.97.3 2024-10-23 12:30:53 +00:00
Michael Barrett
75205a7d31
Updated admin-x-activitypub URL to point at shorter cached version (#21378) 
no refs
 2024-10-23 13:03:40 +01:00
Daniel Lockyer
23cff56961 Removed unused vite-plugin-commonjs dependency 2024-10-23 13:43:53 +02:00
Daniel Lockyer
8fb7da4be0 Bumped Node versions in CI 
- we should be running most of CI on Node 20
- this has fallen out of sync because we declare the version in so many
  places
- to help with this, I've extracted the Node version to an env var, and
  re-used that across the workflow
 2024-10-23 13:23:35 +02:00
renovate[bot]
cb453febe9 Update benchmark-action/github-action-benchmark action to v1.20.4 2024-10-23 13:22:37 +02:00
Daniel Lockyer
9c6992535b Refactored URL service code to aid with debugging 
- replaced a couple of uses of lodash.each in favor of native for loops
- tidied up `debug` statements and spacing
- pulled out common statements into variables
 2024-10-23 13:17:54 +02:00
Sodbileg Gansukh
c11c516e14
Made unsubscribe from all button sticky on scroll (#21381) 
ref DES-785
 2024-10-23 19:07:29 +08:00
Ludovic Toinel
182a07278d
Added missing lang attribute to html tag for AMP 
refs https://github.com/ampproject/amphtml/blob/main/docs/spec/amp-html-components.md

SEMRush was giving back issues on AMP analysis due to this missing attribute
 2024-10-23 18:05:46 +07:00
Michael Barrett
5492e64988
Updated admin-x-activitypub URL to point at shorter cached version (#21378) 
no refs
 2024-10-23 11:36:16 +01:00
Fabien O'Carroll
0cb435fe4d Added breaking test for ghost_head including portal script 
refs https://linear.app/ghost/issue/ONC-254
refs https://github.com/TryGhost/Ghost/issues/20771

The reason that recommendations aren't working is because portal isn't loaded,
which handles the data-attributes having the event listeners added to them.
 2024-10-23 08:58:52 +01:00
Ghost CI
df1da8ac24 Merged v5.97.2 into main 2024-10-23 07:56:20 +00:00
Ghost CI
0f718a13f1 v5.97.2 2024-10-23 07:56:19 +00:00
Cathy Sarisky
de3b9b1ec5
🐛 Fixed recommendations popup not opening 
closes https://linear.app/ghost/issue/ONC-254
closes #20771

The portal script, which is responsible for handling the recommendations popup,
was only loaded into the front end if either members or donations are enabled.
We're adding an extra condition to load it if recommendations are enabled.

We may want to consider splitting out this functionality into several scripts,
so that we don't have to load _everything_ if only one feature is enabled, but
that is outside the scope of this issue.
 2024-10-23 14:49:10 +07:00
Michael Barrett
c6bfd0f98f
Moved ActivityPub labs flag to (private) beta (#21363) 
no refs
 2024-10-23 08:36:15 +01:00
Daniël van der Winden
8615bd538b
MRR/Members chart axis fix (#21359) 
fixes
https://linear.app/ghost/issue/DES-869/dashboard-mrr-member-chart-axis-is-making-flat-growth-look-like

A slight decline/increase on the MRR/members chart was shown as a very
dramatic shift. These changes will make the chart appear more gradual
when the changes are small. 

The chart will effectively "zoom in" on the
range where the values fluctuate. The y-axis minimum is 95% of the lowest data point, and the maximum is 105% of the highest data point. That way there's a small buffer above and below the data range, and the chart as a whole doesn't have the overly dramatic drops/peaks.

I've tested it with hardcoded values, as well as values inserted via the
API, and the charts look a lot better.

**Before**
<img width="1257" alt="1 - chart before"
src="https://github.com/user-attachments/assets/8d59fc38-0a57-4a7a-a83f-06e045057f45">
<img width="1255" alt="2 - chart before"
src="https://github.com/user-attachments/assets/46476d88-3991-4253-a5bc-76591ea67e39">

**After (same two values)**
<img width="1260" alt="3 - chart after"
src="https://github.com/user-attachments/assets/d5bcfdb2-40dd-4655-afd4-ba19a62d76b9">
<img width="1263" alt="4 - chart after"
src="https://github.com/user-attachments/assets/6c8cf189-6497-482e-9414-a7d77c00c533">

**Gradual decline**
<img width="1259" alt="5 - chart gradual"
src="https://github.com/user-attachments/assets/5ec2b470-f1d2-45cd-aba5-5f11e6e718fd">
<img width="1250" alt="6 - chart gradual"
src="https://github.com/user-attachments/assets/b6dd67ab-0b5e-47db-a9ef-d4ae10b78f73">

**More pronounced decline**
<img width="1270" alt="7 - chart dramatic"
src="https://github.com/user-attachments/assets/c43215c3-a687-47be-ab05-70fee855a345">
<img width="1256" alt="8 - chart dramatic"
src="https://github.com/user-attachments/assets/55ae833b-e47d-441a-98e0-fcfa2e9734a0">
<img width="1258" alt="9 - chart dramatic"
src="https://github.com/user-attachments/assets/b9fdef8f-61fa-4315-a662-b37eea2259d3">
 2024-10-23 09:02:30 +02:00
Princi Vershwal
3f1fa96003
Updated code for fetching location (#21368) 
Ref:
https://linear.app/ghost/issue/ENG-1660/undefined-location-when-logging-in-on-ios
 2024-10-23 06:43:42 +01:00
Ronald Langeveld
1e8bb253bf
Added Best Comment to top of API output (#21374) 
ref PLG-220

- Added the ability to move the Best comment to the first entry when
order=best is passed as params.
 2024-10-23 09:48:16 +09:00
Michael Barrett
1b468f333b
Added buttons to show more data on profile in admin-x-activitypub (#21373) 
no refs
 2024-10-22 21:29:46 +01:00
Djordje Vlaisavljevic
26133095ea Added excerpt to Ghost posts 
ref https://linear.app/ghost/issue/AP-124/view-full-article
 2024-10-22 21:02:42 +01:00
Djordje Vlaisavljevic
773ce016b0 Made Following button disabled 
ref https://linear.app/ghost/issue/AP-501/updated-suggested-users
 2024-10-22 21:02:42 +01:00
Djordje Vlaisavljevic
36d15a4b40 Updated suggested users list 
ref https://linear.app/ghost/issue/AP-501/updated-suggested-users
 2024-10-22 21:02:42 +01:00
Michael Barrett
63afb15356
Added button to show more followers on profile in admin-x-activitypub (#21371) 
no refs
 2024-10-22 20:56:14 +01:00
Michael Barrett
e9914d8fe5
Fixed followers list on profile in admin-x-activitypub app (#21370) 
refs
[AP-489](https://linear.app/ghost/issue/AP-489/followers-showing-unknown-on-user-profile)

Fixed the followers list on profile in admin-x-activitypub app by
utilising a custom endpoint to fetch a list of expanded followers
seeming though the followers endpoint only returns follower id's
 2024-10-22 20:21:12 +01:00
Michael Barrett
b9768f99e9
Added posts to the user profile in admin-x-activitypub (#21369) 
refs
[AP-484](https://linear.app/ghost/issue/AP-484/render-posts-on-user-profile)

Added posts to the user profile in admin-x-activitypub
 2024-10-22 19:54:05 +01:00
Michael Barrett
febb7f720e
Used attributedTo for the Like activities on the profile page (#21367) 
refs
[AP-487](https://linear.app/ghost/issue/AP-487/likes-on-profile-info-displaying-incorrect-actor-info)

Used `attributedTo` for the `Like` activities on the profile page of the
`admin-x-activitypub` app
 2024-10-22 17:02:04 +01:00
Ghost CI
1626a0c537 Merged v5.97.1 into main 2024-10-22 15:20:32 +00:00
Ghost CI
7dc0c87b44 v5.97.1 2024-10-22 15:20:30 +00:00
Fabien 'egg' O'Carroll
1739bdb9be 🐛 Fixed hidden comments still appearing 
refs https://linear.app/ghost/issue/ONC-469

Hidden comments were not being purged from the cache, which resulted
in stale data being served, and hidden comments being visible.
 2024-10-22 22:08:37 +07:00
Fabien 'egg' O'Carroll
73e0727cc4
🐛 Fixed hidden comments still appearing 
refs https://linear.app/ghost/issue/ONC-469

Hidden comments were not being purged from the cache, which resulted
in stale data being served, and hidden comments being visible.
 2024-10-22 22:02:24 +07:00
Michael Barrett
94584489b4
Added graceful handling of suggested profile errors in admin-x-activitypub (#21366) 
no refs

Added graceful handling of suggested profile errors in
admin-x-activitypub
 2024-10-22 15:49:21 +01:00
Djordje Vlaisavljevic
f214213859 Improved how we handle Like notifications 
ref https://linear.app/ghost/issue/AP-480/handle-likes-received-on-replies

- Clicking a notification now opens Article/Note in the drawer
- When the liked post is a reply, the content of the reply is shown in the notification
 2024-10-22 15:42:25 +01:00
Djordje Vlaisavljevic
936ff85efb Updated welcome screen copy and link 
ref https://forum.ghost.org/t/activitypub-beta-start-here/51780
 2024-10-22 15:42:25 +01:00
Djordje Vlaisavljevic
7e7aee92c5 Removed Comment button in drawer view 
ref https://linear.app/ghost/issue/AP-498/remove-items-from-post-view-in-sidebar
 2024-10-22 15:42:25 +01:00
Djordje Vlaisavljevic
51913a7990 Removed button for resizing the drawer 
ref https://linear.app/ghost/issue/AP-498/remove-items-from-post-view-in-sidebar
 2024-10-22 15:42:25 +01:00
Djordje Vlaisavljevic
797a34f9e2 Removed static Unfollow button from Following tab 
ref https://linear.app/ghost/issue/AP-499/remove-unfollow-buttons-from-following-tab-on-your-profile
 2024-10-22 15:42:25 +01:00
Djordje Vlaisavljevic
8846cb9d19 Removed static Delete button from the dropdown 
ref https://linear.app/ghost/issue/AP-420/i-can-see-a-delete-action-on-posts-that-are-not-mine
 2024-10-22 15:42:25 +01:00
Djordje Vlaisavljevic
ba43678964 Fixed z-index issue 
ref https://linear.app/tryghost/issue/AP-464/feed-view-refinements
 2024-10-22 15:42:25 +01:00
renovate[bot]
eb85af051f Update tiptap monorepo to v2.9.0 2024-10-22 13:57:37 +00:00