Simon Backx
a5ac2bd470
Added showSubscriptionDetails toggle in admin
...
refs https://github.com/TryGhost/Team/issues/2737
2023-03-15 14:44:37 +01:00
Simon Backx
80043f2699
Fixed snapshot tests in batch sending
2023-03-15 14:11:05 +01:00
Simon Backx
6e5ddc6a9a
Fixed email preview snapshots
2023-03-15 14:03:24 +01:00
Sanne de Vries
c4bbaf7c7b
Updated spacing in emails without post title
...
Refs https://github.com/TryGhost/Team/issues/2699
2023-03-15 13:33:10 +01:00
Sanne de Vries
e0c3573079
Updated email template snapshot resulting in test failure
...
No ref
2023-03-15 12:45:54 +01:00
Sanne de Vries
4284292736
Updated email spacing for when post title is hidden
...
Refs https://github.com/TryGhost/Team/issues/2699
2023-03-15 12:27:03 +01:00
Sanne de Vries
f9cb4bcaaf
Updated comments link UI in email preview
...
Refs https://github.com/TryGhost/Team/issues/2714
2023-03-15 12:10:10 +01:00
Simon Backx
da2e56916e
Added show_subscription_details column to newsletter table ( #16403 )
...
fixes https://github.com/TryGhost/Team/issues/2708
Adds `show_subscription_details` column to newsletter table. Disabled by
default.
2023-03-15 11:53:45 +01:00
Fabien 'egg' O'Carroll
bdaddd1a64
Added setting to store last mention report email date ( #16399 )
...
Because there is no guarantee about a daily job running exactly once a
day, we need to store the last time that the email was sent, so that we
can refrain from sending one if it's been less than a day since the
last.
A setting has been used for this as we don't currently have a pattern
for it, we might want to consider moving this to some kind of cache
based solution in future. This has been added as a core setting so that
we don't expose it via the API.
The setting is stored as a number to allow us to store value as unix timestamp.
---------
Co-authored-by: Rishabh <zrishabhgarg@gmail.com>
2023-03-15 15:34:41 +05:30
Sodbileg Gansukh
64e5fbe5b7
Adjusted Portal popup width for better readibility
...
refs https://github.com/TryGhost/Team/issues/2621
2023-03-15 17:45:01 +08:00
Sanne de Vries
9667ec2eea
Updated spacing between header and feature image in email preview
...
Refs https://github.com/TryGhost/Team/issues/2699
2023-03-15 10:34:51 +01:00
Simon Backx
4cc7d7d6d1
Added show/hide comment CTA to preview labs view
...
refs https://github.com/TryGhost/Team/issues/2714
Uses the comments settings and the showCommentCta setting from the newsletter.
2023-03-15 10:16:57 +01:00
Daniel Lockyer
42d9c3ea4d
Reorganised React imports
...
- we use ES6 `import` for all other imports so this standardizes the
React package to also use import vs require
- merged with other imports from the react package if present
2023-03-15 10:15:04 +01:00
Sanne de Vries
03b8715276
Added support for center-aligning comments link in email preview
...
Refs https://github.com/TryGhost/Team/issues/2714
- When center-aligning the post title, the meta data and comments link are also centered
2023-03-15 10:12:20 +01:00
Sanne de Vries
c538e39d33
Updated comments link UI in email preview
...
Refs https://github.com/TryGhost/Team/issues/2714
2023-03-15 10:02:43 +01:00
Simon Backx
b27c7bc707
Fixed batch sending snapshots dates
...
no issue
The snapshots contained the current date, so they broke every day. This commit fixes the issue by setting a fixed date.
2023-03-15 09:45:36 +01:00
Sodbileg Gansukh
7c9e77bc81
Updated recent posts links to analytics
...
Refs https://github.com/TryGhost/Team/issues/2612
- the recent posts were used to link to the editor, now they're linked to their analytics page
- now that we have an analytics screen for each post it makes sense to link to that screen where possible
2023-03-15 15:21:26 +08:00
Kevin Ansfield
6a3a4632ad
Updated post links in member event feeds to point to post analytics screen ( #16384 )
...
refs https://github.com/TryGhost/Team/issues/2612
- member event feeds previously had links to posts that opened the
front-end post URL in a new tab
- now that we have an analytics screen for each post it makes sense to
link to that screen where possible because it allows drill-down into
site performance
2023-03-15 15:12:16 +08:00
renovate[bot]
a7207eb0dd
Update dependency sqlite3 to v5.1.6
2023-03-15 07:51:08 +01:00
Naz
b627516088
Removed mediaInliner labs flag
...
refs https://github.com/TryGhost/Toolbox/issues/524
- The 'mediaInliner' beta flag is not used for anything anymore, so there's no need to keep it around. The only surface of the feature is the `POST /db/media/inline` endpoint that will be used through internal tooling mostly and won't be accessible through the Admin UI.
2023-03-14 22:13:04 +01:00
Naz
f442398239
Reverted media inlining button in settings>labs
...
refs https://github.com/TryGhost/Toolbox/issues/524
- We no longer need the UI of any kind for the media inliner feature as
the inliner endpoint will be used mostly for internal purposes through
automated tooling
- This reverts commit 901485c47b
2023-03-14 21:57:35 +01:00
Naz
8025663616
Moved POST /db/media/inline endpoint outside labs
...
refs https://github.com/TryGhost/Toolbox/issues/524
- The endpoints is for internal (non-documented) usage at the moment and is fine without the labs flag.
- This should allows us to test the inlining on production sites sooner
2023-03-14 18:32:52 +01:00
Simon Backx
66c20710ba
Added placeholder comment CTA button to emails
...
fixes https://github.com/TryGhost/Team/issues/2725
- Added to emails if labs flag enabled, comments enabled and comment CTA button enabled
- Links to comment section
- Design and styling not added yet
2023-03-14 17:11:24 +01:00
Simon Backx
56cbb15e37
Wired up showCommentCTA in admin
...
fixes https://github.com/TryGhost/Team/issues/2726
This makes sure the toggle actually saves to the database, and that the toggle is only shown when comments is enabled.
2023-03-14 16:35:23 +01:00
Simon Backx
bb019a0ab5
Added E2E test for sending email without post title
...
fixes https://github.com/TryGhost/Team/issues/2724
This change also includes new snapshots for email sending (similar for email previews, but this time for the real emails to make sure we catch changes).
2023-03-14 16:05:18 +01:00
Sanne de Vries
3cdd13ba3a
Updated spacing of email newsletter modal sidebar
...
Refs https://github.com/TryGhost/Team/issues/2699
2023-03-14 15:37:22 +01:00
Simon Backx
350b291c34
Added show_comment_cta column to newsletter table ( #16401 )
...
fixes https://github.com/TryGhost/Team/issues/2707
Adds the new column for storing whether we need to show a comment CTA in
emails. Enabled by default.
2023-03-14 15:03:02 +01:00
Sanne de Vries
3a95b558e0
Fixed post title not being hidden in email preview
...
Refs https://github.com/TryGhost/Team/issues/2705
2023-03-14 13:37:52 +01:00
Sam Lord
72ba6ec4af
Added member feedback to data generator
...
refs: https://github.com/TryGhost/Toolbox/issues/454
2023-03-14 10:32:34 +00:00
Simon Backx
1e435fb328
Implemented showPostTitleSection ( #16404 )
...
fixes https://github.com/TryGhost/Team/issues/2705
- Added showPostTitleSection to newsletter model in admin
- Wired up UI to admin model so it saves to the database
- Implemented showPostTitleSection in newsletter preview and added some
minor temporary css styling
- Implemented showPostTitleSection in newsletter template in backend,
and added some extra CSS styling to fix spacing
2023-03-14 11:29:43 +01:00
Aileen Nowak
475d8f9dd6
Fixed not providing a boolean value or slack-notifications service
...
no issue
The logic was incorrect and provided a URL instead of the expected `boolean` value for `isEnabled`
2023-03-14 12:00:20 +02:00
Simon Backx
69d07c892c
Fixed getLazyRelation returning new model for optional relations ( #16411 )
...
no issue
When using `getLazyRelation` on an optional relation that is not set, it
will return a newly created model instead of a model from the database.
- Adds a new require option to `getLazyRelation`, that throws an error
if the relation is not set (off by default to match existing use cases)
- This caused a bug (not visible because we always pass a newsletter id)
in email previews, where when the newsletter id was not explicitly set,
it would use `newsletter = (await post.getLazyRelation('newsletter')) ??
(await this.models.Newsletter.getDefaultNewsletter());`, which always
returned the first one, and could return a newly initiated newsletter
with all properties set to undefined.
- Some page snapshots are altered by this, because the usage of
`getLazyRelation` on a post no longer sets the email relation to some
new model.
2023-03-14 10:58:58 +01:00
Sagar Gupta
1fd20151bd
🐛 Fixed upper price limit in Membership Tiers
...
closes https://github.com/TryGhost/Team/issues/2287
- Stripe allows a max. amount of 999,999.99, cf. Stripe docs https://stripe.com/docs/api/payment_intents/object#payment_intent_object-amount
- The publisher now sees an error if they choose a price that is higher than the upper limit
2023-03-14 10:52:17 +01:00
Simon Backx
ff5e7202c6
Added show_post_title_section column to newsletters table ( #16397 )
...
fixes https://github.com/TryGhost/Team/issues/2706
Only includes the migration. The setting is not used at the moment, but
will be enabled by default.
2023-03-14 09:48:13 +01:00
renovate[bot]
3c22203c71
Update @tryghost ( #16406 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@tryghost/html-to-mobiledoc](https://togithub.com/TryGhost/SDK/tree/master#readme )
([source](https://togithub.com/TryGhost/SDK )) | [`2.0.6` ->
`2.0.7`](https://renovatebot.com/diffs/npm/@tryghost%2fhtml-to-mobiledoc/2.0.6/2.0.7 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[@tryghost/kg-card-factory](https://togithub.com/TryGhost/Koenig/tree/master#readme )
([source](https://togithub.com/TryGhost/Koenig )) | [`4.0.4` ->
`4.0.5`](https://renovatebot.com/diffs/npm/@tryghost%2fkg-card-factory/4.0.4/4.0.5 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[@tryghost/kg-clean-basic-html](https://togithub.com/TryGhost/Koenig/tree/master#readme )
([source](https://togithub.com/TryGhost/Koenig )) | [`3.0.6` ->
`3.0.7`](https://renovatebot.com/diffs/npm/@tryghost%2fkg-clean-basic-html/3.0.6/3.0.7 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[@tryghost/kg-default-cards](https://togithub.com/TryGhost/Koenig/tree/master#readme )
([source](https://togithub.com/TryGhost/Koenig )) | [`6.0.4` ->
`6.0.5`](https://renovatebot.com/diffs/npm/@tryghost%2fkg-default-cards/6.0.4/6.0.5 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[@tryghost/kg-default-nodes](https://togithub.com/TryGhost/Koenig/tree/main#readme )
([source](https://togithub.com/TryGhost/Koenig )) | [`0.0.15` ->
`0.0.16`](https://renovatebot.com/diffs/npm/@tryghost%2fkg-default-nodes/0.0.15/0.0.16 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[@tryghost/kg-lexical-html-renderer](https://togithub.com/TryGhost/Koenig/tree/main#readme )
([source](https://togithub.com/TryGhost/Koenig )) | [`0.1.11` ->
`0.1.12`](https://renovatebot.com/diffs/npm/@tryghost%2fkg-lexical-html-renderer/0.1.11/0.1.12 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[@tryghost/kg-mobiledoc-html-renderer](https://togithub.com/TryGhost/Koenig/tree/master#readme )
([source](https://togithub.com/TryGhost/Koenig )) | [`6.0.4` ->
`6.0.5`](https://renovatebot.com/diffs/npm/@tryghost%2fkg-mobiledoc-html-renderer/6.0.4/6.0.5 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[@tryghost/kg-parser-plugins](https://togithub.com/TryGhost/Koenig/tree/master#readme )
([source](https://togithub.com/TryGhost/Koenig )) | [`3.0.6` ->
`3.0.7`](https://renovatebot.com/diffs/npm/@tryghost%2fkg-parser-plugins/3.0.6/3.0.7 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>TryGhost/SDK</summary>
###
[`v2.0.7`](ca389b95dd...924c77a60eca389b95dd...924c77a60ehttps://togithub.com/TryGhost/Koenig/compare/@tryghost/kg-card-factory@4.0.4...@tryghost/kg-card-factory@4.0.5 )
[Compare
Source](https://togithub.com/TryGhost/Koenig/compare/@tryghost/kg-card-factory@4.0.4...@tryghost/kg-card-factory@4.0.5 )
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions ) if
that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNjAuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE2MC4wIn0=-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-03-14 06:47:38 +00:00
renovate[bot]
221d1e616c
Update dependency sqlite3 to v5.1.5 [SECURITY]
2023-03-14 07:09:09 +01:00
renovate[bot]
0780cc2dd1
Update dependency metascraper to v5.34.0
2023-03-13 21:36:01 +00:00
Daniel Lockyer
f06ee87787
Removed myself as a CODEOWNER for migrations
...
refs https://ghost.slack.com/archives/C02G9E68C/p1678726901892459
- following a procedure update, I am no longer required to review
migrations so I can remove myself as a CODEOWNER for those paths
2023-03-13 18:06:35 +01:00
Aileen Booker
eeb7546abb
Added handling for initial and skipped Milestones ( #16405 )
...
refs
https://www.notion.so/ghost/Marketing-Milestone-email-campaigns-1d2c9dee3cfa4029863edb16092ad5c4?pvs=4
- When milestones will be activated we would send out emails to users
that are way above the achieved milestone, as we didn't record
milestones before
- The plan is to implement a 0 milestone and don't send an email for
achieving those and also add all achieved milestones in the first run
until a first milestone is stored in the DB, then increment from there.
- This change takes care of two cases:
1. Milestones gets enabled and runs initially. We don't want to send
emails unless there's already at least one milestone achieved. For that
we add a 0 milestone helper and add a `initial` reason to the meta
object for the milestone event, so we can choose not to ping Slack and
also disable email sending for all milestones achieved in this initial
run.
2. All achieved milestones will be stored in the DB, even when that
means we skip some. This introduces the `skipped` reason which also
doesn't send emails for the skipped milestones, but will do for
correctly achieved milestones (always the highest one).
- Added handling for slack notifications to not attempt sending when
reason is `skipped` or `initial`
2023-03-13 19:01:11 +02:00
Sanne de Vries
4c946f5145
Added comments links to email preview in email settings
...
Refs https://github.com/TryGhost/Team/issues/2714
2023-03-13 17:57:19 +01:00
renovate[bot]
f6ed086735
Update sentry-javascript monorepo to v7.42.0
2023-03-13 14:57:18 +01:00
Sanne de Vries
d06f4c5329
Updated email newsletter settings copy
...
Refs https://github.com/TryGhost/Team/issues/2699
2023-03-13 14:39:39 +01:00
renovate[bot]
b1706decf8
Update dependency html-validate to v7.13.3
2023-03-13 12:49:57 +01:00
Fabien 'egg' O'Carroll
4525c7293c
Removed email notifications for new mentions
...
These are no longer desired and will be replaced with a digest style
email.
2023-03-13 18:33:57 +07:00
Sam Lord
8b978b1eb3
Switch to using @tryghost/action-trigger-metric
...
no issue
Was previously using a repo in sam-lord's personal Github.
2023-03-13 11:19:42 +00:00
Fabien "egg" O'Carroll
531e4ab1a9
Removed service.js files from unit test coverage
...
The service.js files are rarely unit tested because they are
essentially glue code which acts as a singleton and doesn't use
dependency injection, this lil cocktail makes it difficult to stub
dependencies, as well as to call the init method more than once in a
test suite. This change should give us improved unit test coverage
2023-03-13 17:26:03 +07:00
Sodbileg Gansukh
905c2ed090
Adjusted hover text for scheduled email-only posts
...
refs https://github.com/TryGhost/Team/issues/2533
- changes the text from "to be published and sent" to "to be sent"
- this applies to scheduled email-only posts only
2023-03-13 17:54:34 +08:00
Sanne de Vries
f31c69d7d5
Added UI for new settings in email newsletter settings
...
Refs https://github.com/TryGhost/Team/issues/2699
- Added 'Making it rain' feature flag
- Added toggles for newsletter title section, comment links, and latest posts
2023-03-13 09:56:35 +01:00
renovate[bot]
2223db5379
Update Test & linting packages
2023-03-13 02:36:20 +00:00
renovate[bot]
d622631087
Update dependency webpack to v5.76.1
2023-03-13 00:08:13 +00:00
