0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-27 22:49:56 -05:00
Commit graph

8260 commits

Author SHA1 Message Date
Hannah Wolfe
366e90ddef Updated yaml parser error to be InvalidUsageError
- a yaml parser error can only be fixed by the user uploading a file, therefore it should be a 4xx, not a 5xx error
- an amp parser error indicates the amperize module is unable to handle a genuine case, and needs to be fixed at the code level
2019-12-04 14:32:25 +00:00
Hannah Wolfe
79683f60bb 🐛 Fixed uncaught exceptions from image fetches
closes #10383

- Upgrades got to 8.3.2, which contains better error handling and resolves the issue with uncaught exceptions
- Note: Got 9.x stream doesn't support Node v6
- Requires us to hardcode http:// for xmlrpc because there is a breaking change where got now defaults to https instead of http
2019-12-04 14:22:11 +00:00
Hannah Wolfe
1404745b50 Added guard to asset helper for missing paths
refs #10496

- currently {{asset this/is/not/a.string}} would throw a 500 error
- this commit changes that to make it throw a sensible 400 + incorrect usage error
2019-12-04 14:11:27 +00:00
Hannah Wolfe
617d861ca0 Added error handling for weird handlebars syntax
refs #10496

- handlebars if and unless helpers throw weird, unhelpful syntax errors
- for now, catch these errors and do something helpful with them
2019-12-04 14:05:14 +00:00
Hannah Wolfe
03f31bba9d Return correct error codes from storage adapter
no issue

- malformed paths such as http://localhost:2368/content/images/2018/02/%c0%af were throwing 500 errors, instead of 500 errors
- this code catches the error and handles it correctly
2019-12-04 14:04:03 +00:00
Kevin Ansfield
81f6b3df1e Version bump to 1.26.0 2019-06-25 12:25:20 +01:00
Kevin Ansfield
a0536dda0e Updated Ghost-Admin to 1.26.0 2019-06-25 12:25:20 +01:00
Naz Gargol
6eaea7e699
Updated Node v6 and v10 support (#10810)
no issue

- Updated travis.yml to xenial build
- Fixes failing tests which require mysql
- Reason for above: by default, Travis is now running all instances with xenial distro
- Fixed unit test for amp-img
- The unit test was doing HTTP request which failed because resources
were migrated from previously used location
- Added node v10 support
- Updated amperize to run under Node v10
- Droped Node v6 support
2019-06-25 10:19:35 +02:00
Rish
1e1d43aea7 Version bump to 1.25.8 2019-05-28 19:05:49 +05:30
Rish
9289995345 Updated Ghost-Admin to 1.25.8 2019-05-28 19:05:49 +05:30
Rish
855a7cdf06 Bumped ghost-ignition version to 3.1.0
no issue

Bumped ghost ignition to 3.1.0 to have unified logging for all versions on Ghost Pro
2019-05-28 14:56:10 +05:30
Kevin Ansfield
a391a3becf Version bump to 1.25.7 2019-02-07 13:30:48 +00:00
Kevin Ansfield
ed8399cf72 Updated Ghost-Admin to 1.25.7 2019-02-07 13:30:48 +00:00
Kevin Ansfield
30442a0d10 Bumped express-hbs dependency
no issue
- express-hbs has been updated to depend on handlebars@4.0.13 which protects against a potential RCE
- Ghost itself was not vulnerable to the RCE due to protection by gscan which does not allow themes using unknown helpers to be installed/activated
2019-02-07 13:15:28 +00:00
Fabien O'Carroll
ccecc19e4a Version bump to 1.25.6 2018-11-07 16:19:37 +07:00
Fabien O'Carroll
c1d4257adb Updated Ghost-Admin to 1.25.6 2018-11-07 16:19:37 +07:00
Nazar Gargol
305d13e5c4 Fixed sanitization issue in subscribers
no issue

- Added sanitization to subscribed_url & subscribed_referrer fields when rendering error state

Credits: Antony Garand
2018-11-07 16:16:27 +07:00
Fabien O'Carroll
eb22429338 🐛 Fixed redirect issue with private sites (#9960)
closes #9959

This issue existed because the logic assumed that if there were no
query parameters then there would be no `query` object. However this is
not the case. What we really wanted to check was for the existence of an
"r" query param - the code has been refactor to explicitly do this now.
2018-11-07 16:16:27 +07:00
Fabien O'Carroll
68c56d9539 Updated private-sites to not redirect to full urls
no-issue

- Parse redirects as URL with blog as base
- Redirect to the pathname property of parsed URL

Credits: @j3ssie
2018-11-07 16:16:27 +07:00
Kevin Ansfield
f6a45b6ade Version bump to 1.25.5 2018-08-14 14:43:41 +01:00
Kevin Ansfield
59c08db87a Updated Ghost-Admin to 1.25.5 2018-08-14 14:43:41 +01:00
Katharina Irrgang
4554bbcba7
Overhauled README.md (#9784)
no issue

- Significantly improved README.md
- Highlight our cli install
- Nicer formatting of links
- And much, much more...
- use V1 docs links for master
2018-08-14 00:35:15 +02:00
kirrg001
8aac74b3e8 Disabled bluebird debug logs
refs https://github.com/TryGhost/Ghost-CLI/issues/778

- enabling the debug logs will eat a huge amount of memory
- ensure we disable the debug logs before we require anything else
2018-08-13 14:01:31 +02:00
Kevin Ansfield
66fb0955a4 Koenig - Render image title attribute if present
refs https://github.com/TryGhost/Ghost/issues/9724
- `<img>` elements can have both `alt ` and `title` attributes, ensure we render both of them
2018-08-13 09:48:04 +01:00
Kevin Ansfield
cfd9ff3993 🎨 Koenig - Added support for shortened URLs in embed card (#9781)
refs https://github.com/TryGhost/Ghost/issues/9724

- perform a HEAD request on a url if we don't find a matching provider, following any redirects until we hit success response before looking up providers for the resulting url
2018-08-12 15:57:19 +02:00
kirrg001
860718f584 Minimized cached data on resource add/update
refs #9601

- on resource update/add we have cached mobiledoc, html etc
- we have to ensure we exclude the fields (same procdure happens on bootstrap)
- these excluded fields don't have to be cached
- otherwise memory usage is higher in general
- ensure we cache relations with a minimal field set on resource update/add
2018-08-12 14:23:32 +02:00
kirrg001
3ed5087deb Released memory in importer as early as possible
no issue

- set bigger objects to null as soon as possible
- this will trigger the GC to free memory
2018-08-12 12:22:23 +02:00
kirrg001
d421b8ccac Fixed offset calculation for SQlite3
no issue
2018-08-11 14:04:25 +02:00
kirrg001
a36191de5c Enabled useNullAsDefault for SQlite3
closes #9587

- when `useNullAsDefault` was invented in knex 0.10, it was a breaking change, that update/insert etc no longer set's null as default if a field is missing
- at this time we thought it only affects our test env, because the test generator doesn't generate all fields
- but turned out the importer is affected as well e.g. you import a post with missing fields
- the importer doesn't iterate over all fields and checks if the field is present or not
- as this only happens with SQlite3, we should enable `useNullAsDefault` by default
- you can still disable this option if you want, but not recommended
- the reason why knex added this breaking change was that some applications want "undefined" as value
- this is not the case in Ghost, so it's fine to make use of the default null behaviour
2018-08-11 13:52:03 +02:00
Hannah Wolfe
66f00bc1e2 Update issue templates
- More clarity - more links to forum - more emoji
2018-08-10 16:47:37 +01:00
kirrg001
1ce504bb2d Fixed exporting extra tables for endpoint db/backup
refs #8719

- initial commit: 40c8eacd44
- we have forgotten that there is another endpoint which triggers an export (the backup endpoint)
- this endpoint needs to accept the new `include` query param as well (was missing)
2018-08-10 15:31:54 +02:00
kirrg001
1b5eae2af5 Version bump to 1.25.4 2018-08-08 19:45:54 +02:00
kirrg001
84ec604254 Updated Ghost-Admin to 1.25.4 2018-08-08 19:45:53 +02:00
kirrg001
08f54d2f57 Added protection against "too many SQL variables" for SQLite3
no issue

- discovered while testing
- SQLite3 has a restriction that you cannot query more than 999 SQL variables (e.g. fetch all tag relations for all posts)
- if you have more than 999 posts in your database, Ghost wasn't able to finish the bootstrap
  - the url service tried to fetch all posts & relations, but could not complete, because SQlite3 has thrown
    -> "too many SQL variables"
- i have added a recursive query strategy only for SQLite3
  - use offset/limit
2018-08-08 19:17:01 +02:00
kirrg001
6c18ceef25 Importer: Added protection for duplicate trusted domains
refs #8719
2018-08-08 19:00:23 +02:00
kirrg001
7c4e1584a6 Upgrading Casper to 2.4.2 2018-08-08 17:11:39 +02:00
Kevin Ansfield
0c06a47b9b Koenig - Added rich-text caption support
refs https://github.com/TryGhost/Ghost/issues/9724
- captions can have HTML so we need to render as HTML rather than as a text node so special chars don't get escaped
2018-08-08 14:29:20 +01:00
kirrg001
75cc60c20a Added option to import clients and trusted domains
refs #9742, refs #8719

- make it possible to import more tables (optional)
  - available tables: clients, trusted domains
- by default we won't import these tables, you have to tell Ghost using `include` (same syntax on export)
- we won't announce this ability for now (stays hidden)
2018-08-03 14:12:06 +02:00
kirrg001
40c8eacd44 Added option to export extra tables
refs #9742, refs #8719

- you can now use `include` to export extra tables e.g. `include=clients`
- admin client won't make use of this option yet, maybe later and optional
- we won't announce this new ability for now (stays hidden)
2018-08-03 14:11:45 +02:00
Kevin Ansfield
3efee1ae54 Version bump to 1.25.3 2018-07-31 11:37:01 +01:00
Kevin Ansfield
23e980b4f6 Updated Ghost-Admin to 1.25.3 2018-07-31 11:37:01 +01:00
Kevin Ansfield
329c13900e Upgrading Casper to 2.4.1 2018-07-31 11:34:52 +01:00
Mandeep Singh Gulati
104a4a5c92 ES6 migration: server/api (#9756)
refs #9589
2018-07-30 12:28:05 +02:00
Kevin Ansfield
5b80ec44ab 🐛 Koenig - Fixed missing alt text on images
refs https://github.com/TryGhost/Ghost/issues/9724
- render `alt` attribute if the image card payload has an `alt` property
2018-07-30 10:10:11 +01:00
kirrg001
a1723a687c Version bump to 1.25.2 2018-07-25 22:41:23 +02:00
kirrg001
5e6c345e96 Updated Ghost-Admin to 1.25.2 2018-07-25 22:41:23 +02:00
kirrg001
569018c2bc 🐛 Fixed 1.25 migration for html field being null
no issue

- it can happen that the `html` field is null
- the migration script will fail and rollback the changes automatically
2018-07-25 21:54:44 +02:00
kirrg001
fe367e4dbc Version bump to 1.25.1 2018-07-25 11:59:21 +02:00
kirrg001
60cd1ad339 Updated Ghost-Admin to 1.25.1 2018-07-25 11:59:21 +02:00
Katharina Irrgang
6a9fe1e10c
🐛 Fixed 1.25 migration for mobiledoc field being null (#9752)
refs #9751

- the mobiledoc field can be null
- e.g. if you import a JSON with no markdown/mobiledoc or html field

The migration script for 1.25 had only the purpose to migrate existing Koenig Beta posts.
2018-07-25 11:49:04 +02:00