Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-17 23:44:39 -05:00
Code Issues Activity
9423 commits 238 branches 1702 tags 571 MiB
Commit graph

9423 commits

This branch
This branch
All branches
Author SHA1 Message Date
Sanne de Vries
2fb62708a8 Added fade-in effect when opening publish and preview modals in editor 
No ref
 2022-05-19 11:58:51 +02:00
Simon Backx
f9cd8b1f66 Removed zero tiers from paid mix charts (unless all zero) 
no issue

When the last tier in the paid mix chart is zero, the border radius is broken.
 2022-05-19 11:41:54 +02:00
Simon Backx
1ce02660aa Fixed recent posts open rate bars width 
refs https://ghost.slack.com/archives/C02G9E68C/p1652951577111489
 2022-05-19 11:28:37 +02:00
Kevin Ansfield
0549ffd4b5 Removed unused component argument with typo 
no issue

- spotted the typo and thought there was a bug somewhere but post count isn't used in the complete-with-email-error state of the publish flow
 2022-05-19 10:25:05 +01:00
Sanne de Vries
e09f41716b Fixed subscriber count not showing for scheduled email-only posts 
No ref
 2022-05-19 11:23:50 +02:00
Simon Backx
0cddb3ccb9 Fixed archived paid tiers causing dashboard errors 2022-05-19 11:19:28 +02:00
Sanne de Vries
df15dcb8d5 Added confirmation message to email-only post being sent 
No ref
 2022-05-19 10:54:44 +02:00
Djordje Vlaisavljevic
635dc3ce56 Fixed icon color 2022-05-18 23:31:27 +02:00
Sanne de Vries
435f5189aa Hid "Back to settings" when publish button is running 
No ref
 2022-05-18 20:56:49 +02:00
Sanne de Vries
8468994014 Added spinner icon to running publish button 
No ref
 2022-05-18 20:48:36 +02:00
Sanne de Vries
2835d0a6a4 Fixed publish button pulsating when running 
No ref
 2022-05-18 20:32:10 +02:00
Kevin Ansfield
473831ac2b Added image fallback and site icon/title to <GhPostBookmark> (#2401) 
no issue

- adds `{{get-setting "key"}}` helper to make settings available in templates without needing a backing class
- updated `<GhPostBookmark>` component
  - if post feature image isn't present, fall back to site cover image
  - add site icon (if present) and title to the details line
  - removed author image

Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
 2022-05-18 19:05:27 +01:00
Kevin Ansfield
f2b9fa544f Fixed published post count shown on publish complete step 
no issue

- API query was using `?status=published` instead of `?filter=status:published` so was counting all posts rather than just published ones
 2022-05-18 18:01:28 +01:00
James Morris
9019ae783c Fixed up the borders for dark mode on Dashboard 
refs: https://github.com/TryGhost/Team/issues/1531
 2022-05-18 17:06:41 +01:00
Simon Backx
fdece55480 Added auto save to newsletters toggle 
refs https://github.com/TryGhost/Team/issues/1639

- When enabling/disabling newsletters, the change is saved automatically
 2022-05-18 17:26:03 +02:00
Rishabh Garg
1dc3026aba Fixed subscribe count on adding new newsletter (#2402) 
refs https://github.com/TryGhost/Team/issues/1634

- member count on newsletter may not be immediately updated on saving newsletter
- api returns `opted_in_member_count` in response to adding newsletter which admin cannot use atm
- re-fetches newsletters on save so all newsletters get updated member and post counts
 2022-05-18 20:44:42 +05:30
Simon Backx
857a8e5ae0 Added tests for unsaved newsletter changes 
refs https://github.com/TryGhost/Team/issues/1477
 2022-05-18 15:57:02 +02:00
Sanne de Vries
02a3f4d784 Changed running and success copy for publish button when scheduled 
No ref
 2022-05-18 15:14:43 +02:00
Simon Backx
d87aef7e0a Removed some multipleNewslettersUI feature checks 2022-05-18 15:00:29 +02:00
Kevin Ansfield
6c960704b9 Hid total member counts in newsletter selection for authors/editors 
no issue

- authors/editors don't yet have a way to fetch member counts for specific filters so the final member count is hidden in the publish options text, however we were still showing the total subscribed members for each newsletter in the dropdown which could lead to incorrect assumptions for how many members would receive the newsletter
 2022-05-18 13:58:25 +01:00
Simon Backx
6ba9f6a3be Fixed tiers without members not shown in paid mix chart 2022-05-18 14:17:59 +02:00
Simon Backx
59a1b8a31f Added tests for editing newsletters 
refs https://github.com/TryGhost/Team/issues/1477

- Added default test fixture
- Added tests for validation of newsletter when editing
- Added tests for opening and closing tabs
 2022-05-18 13:14:38 +02:00
Kevin Ansfield
93c9035c49 Fixed "memberssubscribers" text in editor status for scheduled posts 
refs d11cf9e1c7

- "free subscribers" worked but "paid" and "all" states still had "members" in the fixed string along with the new "members/subscribers" plural variable resulting in text like "all memberssusbcribers of My Newsletter"
 2022-05-18 10:55:31 +01:00
Kevin Ansfield
a6dcd936bc Hooked up "revert to draft" button on complete step after scheduling 
refs a19d5c7df3

- added handling of the `afterTask` return value provided when closing the publish flow modal via the revert-to-draft button
 2022-05-18 10:49:08 +01:00
Kevin Ansfield
ea98469e6e Cleaned up improvedOnboarding labs flag 
no issue

- the feature has been GA for a while now so the conditionals are no longer required
 2022-05-18 10:13:06 +01:00
Kevin Ansfield
07fde0ee48 Fixed double capitalisation in publish options recipients text 
refs 89f089e439

- if "Free" or "Paid" had already been output we were still capitalising "Subscribers" ending up with "Free Subscribers" instead of "Free subscribers"
- adjusted the capitalisation conditionals so we don't capitalize "subscriber(s)" if we've already output the recipient type
 2022-05-18 10:00:18 +01:00
Simon Backx
e2ad6e9366 Fixed usage of nullish coalescing in dashboard mocking (missing file) 2022-05-18 10:54:50 +02:00
Simon Backx
4f52acd433 Fixed usage of nullish coalescing in dashboard mocking 2022-05-18 10:51:38 +02:00
Kevin Ansfield
89f089e439 Fixed incorrect member count and capitalisation in publish options for editors/authors 
no issue

- `{{format-number}}` was showing "0" when passed in an empty/nullish string when it should have been showing nothing
- used `{{if-empty}}` to fix capitalisation when the member count is missing
  - previously attempted a CSS-only fix with `:first-letter` and `text-transform: uppercase` but that broke the layout in Safari
 2022-05-18 09:42:44 +01:00
Kevin Ansfield
78418e3708 Resolved "no-action" lint errors in editor.hbs 
refs https://github.com/TryGhost/Ghost/issues/14101

- backing class already updated to use `@action` so the use of `{{action}}` in the template could be removed
 2022-05-18 09:27:43 +01:00
Kevin Ansfield
a7d7c4bf6d Fixed save button not appearing on title changes 
no issue

- the title comparison in the editor's `hasDirtyAttributes` CP was comparing properties on the wrong object so never returned `true` when the title was changed
 2022-05-18 09:25:27 +01:00
Djordje Vlaisavljevic
c16bc682cf Added bottom margin to post bookmark 2022-05-17 17:49:13 +02:00
Djordje Vlaisavljevic
a19d5c7df3 Added static unschedule-and-revert button 2022-05-17 17:49:13 +02:00
Djordje Vlaisavljevic
1320adbba7 Fixed user avatar design 2022-05-17 17:49:13 +02:00
Djordje Vlaisavljevic
a021553203 Updated button label logic to match different states 2022-05-17 17:49:13 +02:00
James Morris
bcef562206 Moved all the dropdowns to be right aligned on the new Dashboard 
refs: https://github.com/TryGhost/Team/issues/1531
 2022-05-17 15:04:55 +01:00
James Morris
600e02610a Changed how the mini charts are layed out to fix bugs in Safari for new Dashboard 
refs: https://github.com/TryGhost/Team/issues/1531
 2022-05-17 14:44:19 +01:00
James Morris
b2a6c01cdf Working out the Safari layout issue when changing dropdowns on new Dashboard 
refs: https://github.com/TryGhost/Team/issues/1531
 2022-05-17 14:44:19 +01:00
Peter Zimon
980f45719d Fixed sent email preview alignment bug 2022-05-17 15:20:58 +02:00
Djordje Vlaisavljevic
ba6e86d4c4 Set icon height so it doesn't break layout in Safari 2022-05-17 13:53:45 +02:00
Peter Zimon
44f338d8a6 Updated Dashboard tooltip background in dark mode 2022-05-17 13:36:37 +02:00
Kevin Ansfield
ab85ddf382 Renamed core/client to core/admin in PR template 2022-05-17 11:57:00 +01:00
James Morris
1d25f6d494 Added in additional check for avatar which will depend on where the data source comes from 
refs: https://github.com/TryGhost/Team/issues/1531
 2022-05-17 11:18:44 +01:00
Peter Zimon
5e3b3acad5 Updated dark mode modal background color 2022-05-17 11:53:59 +02:00
Peter Zimon
8891fd0bd4 Updated dark mode white color 2022-05-17 11:50:23 +02:00
Peter Zimon
da9a2c6b8a Added curve to line charts 2022-05-17 11:45:18 +02:00
Peter Zimon
a9da3b13fc Updated anchor chart background color 2022-05-17 11:41:11 +02:00
Peter Zimon
60568547e3 Updated dark mode colors 2022-05-17 11:38:34 +02:00
Hannah Wolfe
3dec09d7f7 Renamed "client" references to "admin" 
refs: https://github.com/TryGhost/Toolbox/issues/299

- renamed things that reference Ghost admin as "client"
- these things make even less sense in a post core/client world
 2022-05-17 09:09:14 +01:00
Simon Backx
8502ebb96a Moving over the new Dashboard to replace the old (#2389) 
refs: https://github.com/TryGhost/Team/issues/1631

Co-authored-by: James Morris <moreofmorris@users.noreply.github.com>
 2022-05-17 09:34:34 +02:00