Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
Code Issues Activity

Bumped CI to use Node 18 for majority of tests

Browse source 
refs https://github.com/TryGhost/Toolbox/issues/528

- we're moving towards making Node 18 our recommended version, so that
  involves ensuring all of CI is running Node 18
- we still have some Node 16 matrix runs to ensure compatibility
This commit is contained in:
Daniel Lockyer 2023-06-01 11:18:33 +02:00 committed by Daniel Lockyer
parent 5152e0e042
commit ec5f0eefd2
3 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.github/workflows/browser-tests.yml vendored
View file

@ -38,7 +38,7 @@ jobs:
submodules: true submodules: true
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: '16.x' node-version: '18.x'
cache: yarn cache: yarn
- name: Install Stripe-CLI - name: Install Stripe-CLI

2
.github/workflows/signup-form-tests.yml vendored
View file

@ -27,7 +27,7 @@ jobs:
env: env:
FORCE_COLOR: 0 FORCE_COLOR: 0
with: with:
node-version: "16.13.0" node-version: "18.12.1"
cache: yarn cache: yarn
- run: yarn --prefer-offline - run: yarn --prefer-offline

12
.github/workflows/test.yml vendored
View file

@ -24,7 +24,7 @@ jobs:
env: env:
FORCE_COLOR: 0 FORCE_COLOR: 0
with: with:
node-version: '16.13.0' node-version: '18.12.1'
cache: yarn cache: yarn
- uses: actions/cache@v3 - uses: actions/cache@v3
@ -54,7 +54,7 @@ jobs:
- uses: actions/checkout@v3 - uses: actions/checkout@v3
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: "16.13.0" node-version: "18.12.1"
- run: yarn --prefer-offline - run: yarn --prefer-offline
- run: yarn workspace ghost-admin run test - run: yarn workspace ghost-admin run test
@ -98,7 +98,7 @@ jobs:
env: env:
FORCE_COLOR: 0 FORCE_COLOR: 0
with: with:
node-version: '16.13.0' node-version: '18.12.1'
cache: yarn cache: yarn
- name: Shutdown MySQL - name: Shutdown MySQL
@ -160,7 +160,7 @@ jobs:
- run: yarn test:unit - run: yarn test:unit
- uses: actions/upload-artifact@v3 - uses: actions/upload-artifact@v3
if: startsWith(matrix.node, '16') if: startsWith(matrix.node, '18')
with: with:
name: unit-coverage name: unit-coverage
path: ghost/*/coverage/cobertura-coverage.xml path: ghost/*/coverage/cobertura-coverage.xml
@ -182,7 +182,7 @@ jobs:
- DB: mysql8 - DB: mysql8
NODE_ENV: testing-mysql NODE_ENV: testing-mysql
include: include:
- node: 16.13.0 - node: 18.12.1
env: env:
DB: sqlite3 DB: sqlite3
NODE_ENV: testing NODE_ENV: testing
@ -245,7 +245,7 @@ jobs:
echo "test_time=$(($endTime-$startTime))" >> $GITHUB_ENV echo "test_time=$(($endTime-$startTime))" >> $GITHUB_ENV
- uses: actions/upload-artifact@v3 - uses: actions/upload-artifact@v3
if: startsWith(matrix.node, '16') && contains(matrix.env.DB, 'mysql') if: startsWith(matrix.node, '18') && contains(matrix.env.DB, 'mysql')
with: with:
name: e2e-coverage name: e2e-coverage
path: | path: |