From ec5f0eefd299a91244ba0a8b11a49ca250f6bc09 Mon Sep 17 00:00:00 2001
From: Daniel Lockyer <hi@daniellockyer.com>
Date: Thu, 1 Jun 2023 11:18:33 +0200
Subject: [PATCH] Bumped CI to use Node 18 for majority of tests

refs https://github.com/TryGhost/Toolbox/issues/528

- we're moving towards making Node 18 our recommended version, so that
  involves ensuring all of CI is running Node 18
- we still have some Node 16 matrix runs to ensure compatibility
---
 .github/workflows/browser-tests.yml     |  2 +-
 .github/workflows/signup-form-tests.yml |  2 +-
 .github/workflows/test.yml              | 12 ++++++------
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/browser-tests.yml b/.github/workflows/browser-tests.yml
index e844ccaf8c..7a7c11ae14 100644
--- a/.github/workflows/browser-tests.yml
+++ b/.github/workflows/browser-tests.yml
@@ -38,7 +38,7 @@ jobs:
         submodules: true
     - uses: actions/setup-node@v3
       with:
-        node-version: '16.x'
+        node-version: '18.x'
         cache: yarn
 
     - name: Install Stripe-CLI
diff --git a/.github/workflows/signup-form-tests.yml b/.github/workflows/signup-form-tests.yml
index f7c644d7fb..d3147c457f 100644
--- a/.github/workflows/signup-form-tests.yml
+++ b/.github/workflows/signup-form-tests.yml
@@ -27,7 +27,7 @@ jobs:
         env:
           FORCE_COLOR: 0
         with:
-          node-version: "16.13.0"
+          node-version: "18.12.1"
           cache: yarn
 
       - run: yarn --prefer-offline
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 1b9d409d56..eec0d53fb8 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -24,7 +24,7 @@ jobs:
         env:
           FORCE_COLOR: 0
         with:
-          node-version: '16.13.0'
+          node-version: '18.12.1'
           cache: yarn
 
       - uses: actions/cache@v3
@@ -54,7 +54,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: "16.13.0"
+          node-version: "18.12.1"
 
       - run: yarn --prefer-offline
       - run: yarn workspace ghost-admin run test
@@ -98,7 +98,7 @@ jobs:
         env:
           FORCE_COLOR: 0
         with:
-          node-version: '16.13.0'
+          node-version: '18.12.1'
           cache: yarn
 
       - name: Shutdown MySQL
@@ -160,7 +160,7 @@ jobs:
       - run: yarn test:unit
 
       - uses: actions/upload-artifact@v3
-        if: startsWith(matrix.node, '16')
+        if: startsWith(matrix.node, '18')
         with:
           name: unit-coverage
           path: ghost/*/coverage/cobertura-coverage.xml
@@ -182,7 +182,7 @@ jobs:
           - DB: mysql8
             NODE_ENV: testing-mysql
         include:
-          - node: 16.13.0
+          - node: 18.12.1
             env:
               DB: sqlite3
               NODE_ENV: testing
@@ -245,7 +245,7 @@ jobs:
           echo "test_time=$(($endTime-$startTime))" >> $GITHUB_ENV
 
       - uses: actions/upload-artifact@v3
-        if: startsWith(matrix.node, '16') && contains(matrix.env.DB, 'mysql')
+        if: startsWith(matrix.node, '18') && contains(matrix.env.DB, 'mysql')
         with:
           name: e2e-coverage
           path: |