Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

Fixed Segment event named wrong

Browse source
This commit is contained in:
Aileen Booker 2023-07-24 15:35:52 +01:00 • committed by Aileen Booker
parent ce2df20b53
commit eb303ec221
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/core/core/server/services/segment/DomainEventsAnalytics.js
View file

@ -65,7 +65,7 @@ module.exports = class DomainEventsAnalytics {
if (event.data.milestone
&& event.data.milestone.value === 100
) {
const eventName = event.data.milestone.type === 'arr' ? '$100 MRR reached' : '100 Members reached';
const eventName = event.data.milestone.type === 'arr' ? '$100 ARR reached' : '100 Members reached';
try {
this.#analytics.track(Object.assign(this.#trackDefaults, {}, {event: this.#prefix + eventName}));

2
ghost/core/test/unit/server/services/segment/DomainEventsAnalytics.test.js
View file

@ -153,7 +153,7 @@ describe('DomainEventsAnalytics', function () {
assert(analyticsStub.calledWith({
userId: '9876',
properties: {email: 'john+arr@test.com'},
event: 'Pro: $100 MRR reached'
event: 'Pro: $100 ARR reached'
}));
assert(loggingStub.callCount === 0);