From eb303ec221fd5a20ec6de43c47e01eb592255429 Mon Sep 17 00:00:00 2001 From: Aileen Booker Date: Mon, 24 Jul 2023 15:35:52 +0100 Subject: [PATCH] Fixed Segment event named wrong --- .../core/core/server/services/segment/DomainEventsAnalytics.js | 2 +- .../unit/server/services/segment/DomainEventsAnalytics.test.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ghost/core/core/server/services/segment/DomainEventsAnalytics.js b/ghost/core/core/server/services/segment/DomainEventsAnalytics.js index a49bdcb97e..45c99880a7 100644 --- a/ghost/core/core/server/services/segment/DomainEventsAnalytics.js +++ b/ghost/core/core/server/services/segment/DomainEventsAnalytics.js @@ -65,7 +65,7 @@ module.exports = class DomainEventsAnalytics { if (event.data.milestone && event.data.milestone.value === 100 ) { - const eventName = event.data.milestone.type === 'arr' ? '$100 MRR reached' : '100 Members reached'; + const eventName = event.data.milestone.type === 'arr' ? '$100 ARR reached' : '100 Members reached'; try { this.#analytics.track(Object.assign(this.#trackDefaults, {}, {event: this.#prefix + eventName})); diff --git a/ghost/core/test/unit/server/services/segment/DomainEventsAnalytics.test.js b/ghost/core/test/unit/server/services/segment/DomainEventsAnalytics.test.js index d90e495de8..9e2e6b83c7 100644 --- a/ghost/core/test/unit/server/services/segment/DomainEventsAnalytics.test.js +++ b/ghost/core/test/unit/server/services/segment/DomainEventsAnalytics.test.js @@ -153,7 +153,7 @@ describe('DomainEventsAnalytics', function () { assert(analyticsStub.calledWith({ userId: '9876', properties: {email: 'john+arr@test.com'}, - event: 'Pro: $100 MRR reached' + event: 'Pro: $100 ARR reached' })); assert(loggingStub.callCount === 0);