Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
Code Issues Activity

Added created_at field to member fixtures for consistent sort (#21325)

Browse source 
no ref

When running tests, occasionally we'll see some varying sort in the
members api response because members are generally all created with the
same timestamp. While `ObjectId` should be progressive, and our defalut
sort is `ORDER BY created_at desc, id desc`, we still would sometimes
see issues. This ought to remove any flakiness.
This commit is contained in:
Steve Larson 2024-10-16 11:45:22 -05:00 committed by GitHub
parent cf2b429436
commit ea70631a29
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 16 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
ghost/core/test/utils/fixtures/data-generator.js
View file

@ -305,7 +305,8 @@ DataGenerator.Content = {
name: 'Mr Egg', name: 'Mr Egg',
uuid: 'f6f91461-d7d8-4a3f-aa5d-8e582c40b340', uuid: 'f6f91461-d7d8-4a3f-aa5d-8e582c40b340',
status: 'free', status: 'free',
email_disabled: false email_disabled: false,
created_at: moment().subtract(8, 'day').toDate()
}, },
{ {
id: ObjectId().toHexString(), id: ObjectId().toHexString(),
@ -313,7 +314,8 @@ DataGenerator.Content = {
email_open_rate: 50, email_open_rate: 50,
uuid: 'f6f91461-d7d8-4a3f-aa5d-8e582c40b341', uuid: 'f6f91461-d7d8-4a3f-aa5d-8e582c40b341',
status: 'free', status: 'free',
email_disabled: false email_disabled: false,
created_at: moment().subtract(7, 'day').toDate()
}, },
{ {
id: ObjectId().toHexString(), id: ObjectId().toHexString(),
@ -322,7 +324,8 @@ DataGenerator.Content = {
email_open_rate: 80, email_open_rate: 80,
uuid: 'f6f91461-d7d8-4a3f-aa5d-8e582c40b342', uuid: 'f6f91461-d7d8-4a3f-aa5d-8e582c40b342',
status: 'paid', status: 'paid',
email_disabled: false email_disabled: false,
created_at: moment().subtract(6, 'day').toDate()
}, },
{ {
id: ObjectId().toHexString(), id: ObjectId().toHexString(),
@ -330,7 +333,8 @@ DataGenerator.Content = {
name: 'Ray Stantz', name: 'Ray Stantz',
uuid: 'f6f91461-d7d8-4a3f-aa5d-8e582c40b343', uuid: 'f6f91461-d7d8-4a3f-aa5d-8e582c40b343',
status: 'paid', status: 'paid',
email_disabled: false email_disabled: false,
created_at: moment().subtract(5, 'day').toDate()
}, },
{ {
id: ObjectId().toHexString(), id: ObjectId().toHexString(),
@ -338,7 +342,8 @@ DataGenerator.Content = {
name: 'Vinz Clortho', name: 'Vinz Clortho',
uuid: 'f6f91461-d7d8-4a3f-aa5d-8e582c40b344', uuid: 'f6f91461-d7d8-4a3f-aa5d-8e582c40b344',
status: 'paid', status: 'paid',
email_disabled: false email_disabled: false,
created_at: moment().subtract(4, 'day').toDate()
}, },
{ {
id: ObjectId().toHexString(), id: ObjectId().toHexString(),
@ -346,7 +351,8 @@ DataGenerator.Content = {
name: 'Winston Zeddemore', name: 'Winston Zeddemore',
uuid: 'f6f91461-d7d8-4a3f-aa5d-8e582c40b345', uuid: 'f6f91461-d7d8-4a3f-aa5d-8e582c40b345',
status: 'free', status: 'free',
email_disabled: false email_disabled: false,
created_at: moment().subtract(3, 'day').toDate()
}, },
{ {
id: ObjectId().toHexString(), id: ObjectId().toHexString(),
@ -355,7 +361,8 @@ DataGenerator.Content = {
uuid: 'f6f91461-d7d8-4a3f-aa5d-8e582c40b346', uuid: 'f6f91461-d7d8-4a3f-aa5d-8e582c40b346',
status: 'paid', status: 'paid',
subscribed: false, subscribed: false,
email_disabled: false email_disabled: false,
created_at: moment().subtract(2, 'day').toDate()
}, },
{ {
id: ObjectId().toHexString(), id: ObjectId().toHexString(),
@ -364,7 +371,8 @@ DataGenerator.Content = {
uuid: 'f6f91461-d7d8-4a3f-aa5d-8e582c40b347', uuid: 'f6f91461-d7d8-4a3f-aa5d-8e582c40b347',
status: 'paid', status: 'paid',
subscribed: false, subscribed: false,
email_disabled: false email_disabled: false,
created_at: moment().subtract(1, 'day').toDate()
} }
], ],