Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
Code Issues Activity

Stubbed ghost core unit test errors (#21324)

Browse source 
no ref

Stubbed expected test errors. In general, we should be expecting these
errors in the tests as we write them as that is the expected behavior
(or that behavior should change).
This commit is contained in:
Steve Larson 2024-10-16 10:31:57 -05:00 committed by GitHub
parent e2519848c1
commit cf2b429436
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 39 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
ghost/core/test/unit/frontend/helpers/ghost_head.test.js
View file

@ -10,6 +10,7 @@ const models = require('../../../../core/server/models');
const imageLib = require('../../../../core/server/lib/image');
const routing = require('../../../../core/frontend/services/routing');
const urlService = require('../../../../core/server/services/url');
const logging = require('@tryghost/logging');
const ghost_head = require('../../../../core/frontend/helpers/ghost_head');
const proxy = require('../../../../core/frontend/services/proxy');
@ -393,12 +394,19 @@ describe('{{ghost_head}} helper', function () {
});
describe('without Code Injection', function () {
let loggingErrorStub; // assert # of calls if test throws errors, do not globally stub
beforeEach(function () {
configUtils.set({url: 'http://localhost:65530/'});
});
afterEach(function () {
sinon.restore();
});
it('returns meta tag string on paginated index page without structured data and schema', async function () {
// @TODO: later we can extend this fn with an `meta` object e.g. locals.meta
loggingErrorStub = sinon.stub(logging, 'error');
await testGhostHead(testUtils.createHbsResponse({
locals: {
relativeUrl: '/page/2/',
@ -406,6 +414,7 @@ describe('{{ghost_head}} helper', function () {
safeVersion: '0.3'
}
}));
sinon.assert.calledOnce(loggingErrorStub);
});
it('returns structured data on first index page', async function () {
@ -771,19 +780,27 @@ describe('{{ghost_head}} helper', function () {
});
it('disallows indexing for preview pages', async function () {
loggingErrorStub = sinon.stub(logging, 'error');
await testGhostHead(testUtils.createHbsResponse({
locals: {
context: ['preview', 'post']
}
}));
// Unknown Request error for favico
// TypeError for primary_author being undefined
sinon.assert.calledOnce(loggingErrorStub);
});
it('implicit indexing settings for non-preview pages', async function () {
loggingErrorStub = sinon.stub(logging, 'error');
await testGhostHead(testUtils.createHbsResponse({
locals: {
context: ['featured', 'paged', 'index', 'post', 'amp', 'home', 'unicorn']
}
}));
// Unknown Request error for favico
// TypeError for primary_author being undefined
sinon.assert.calledOnce(loggingErrorStub);
});
it('outputs structured data but not schema for custom collection', async function () {
@ -951,6 +968,8 @@ describe('{{ghost_head}} helper', function () {
});
it('does not contain amphtml link', async function () {
let loggingErrorStub = sinon.stub(logging, 'error');
const renderObject = {
post: posts[1]
};
@ -963,6 +982,8 @@ describe('{{ghost_head}} helper', function () {
safeVersion: '0.3'
}
}));
sinon.assert.calledOnce(loggingErrorStub);
});
});

19
ghost/core/test/unit/frontend/helpers/readable_url.test.js
View file

@ -1,7 +1,21 @@
const should = require('should');
const readable_url = require('../../../../core/frontend/helpers/readable_url');
const logging = require('@tryghost/logging');
const sinon = require('sinon');
const errors = require('@tryghost/errors');
describe('{{#readable_url}} helper', function () {
let loggingErrorStub;
beforeEach(function () {
// Stub the logging.error method
loggingErrorStub = sinon.stub(logging, 'error');
});
afterEach(function () {
// Restore the original logging.error method
loggingErrorStub.restore();
});
it('renders a short URL, without protocol, www, query params nor hash fragments', function () {
const readable = readable_url.call(
{},
@ -17,6 +31,9 @@ describe('{{#readable_url}} helper', function () {
{foo: 'bar'}
);
sinon.assert.calledOnce(loggingErrorStub);
sinon.assert.calledWith(loggingErrorStub, sinon.match.instanceOf(errors.IncorrectUsageError));
readable.string.should.equal('');
});