Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
Code Issues Activity

✨ Added Ghost Explore app

Browse source 
no issue

- bumps Ghost Explore integrated app  to GA from alpha
This commit is contained in:
Aileen Nowak 2022-10-25 16:02:35 +01:00 • committed by Aileen Booker
parent cdd65f25ac
commit b79006d7f3
6 changed files with 7 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/admin/app/components/gh-nav-menu/main.hbs
View file

@ -33,12 +33,10 @@
</a> </a>
</li> </li>
{{#if (gh-user-can-admin this.session.user)}} {{#if (gh-user-can-admin this.session.user)}}
{{#if (feature "exploreApp")}}
<li class="relative"> <li class="relative">
<LinkTo @route="explore" title="Ghost Explore" data-test-nav="explore">{{svg-jar "globe-simple"}} Explore</LinkTo> <LinkTo @route="explore" title="Ghost Explore" data-test-nav="explore">{{svg-jar "globe-simple"}} Explore</LinkTo>
</li> </li>
{{/if}} {{/if}}
{{/if}}
</ul> </ul>
<ul class="gh-nav-list gh-nav-manage"> <ul class="gh-nav-list gh-nav-manage">
<li class="gh-nav-list-new relative"> <li class="gh-nav-list-new relative">

4
ghost/admin/app/routes/explore/index.js
View file

@ -15,13 +15,13 @@ export default class ExploreIndexRoute extends AuthenticatedRoute {
// older versions of Ghost where the `connect` part lives in the // older versions of Ghost where the `connect` part lives in the
// explore route directly. By using the query param, we avoid causing // explore route directly. By using the query param, we avoid causing
// a 404 and handle the redirect here. // a 404 and handle the redirect here.
if (transition.to?.queryParams?.new === 'true' || !this.feature.exploreApp) { if (transition.to?.queryParams?.new === 'true') {
this.explore.isIframeTransition = false; this.explore.isIframeTransition = false;
return this.router.transitionTo('explore.connect'); return this.router.transitionTo('explore.connect');
} }
// Ensure the explore window is set to open // Ensure the explore window is set to open
if (this.feature.get('exploreApp') && transition.to?.localName === 'index' && !this.explore.exploreWindowOpen) { if (transition.to?.localName === 'index' && !this.explore.exploreWindowOpen) {
this.explore.openExploreWindow(this.router.currentURL); this.explore.openExploreWindow(this.router.currentURL);
} }
} }

1
ghost/admin/app/services/feature.js
View file

@ -65,7 +65,6 @@ export default class FeatureService extends Service {
@feature('emailAlerts') emailAlerts; @feature('emailAlerts') emailAlerts;
@feature('sourceAttribution') sourceAttribution; @feature('sourceAttribution') sourceAttribution;
@feature('lexicalEditor') lexicalEditor; @feature('lexicalEditor') lexicalEditor;
@feature('exploreApp') exploreApp;
@feature('audienceFeedback') audienceFeedback; @feature('audienceFeedback') audienceFeedback;
@feature('fixNewsletterLinks') fixNewsletterLinks; @feature('fixNewsletterLinks') fixNewsletterLinks;

3
ghost/admin/app/templates/application.hbs
View file

@ -14,9 +14,8 @@
{{#if this.showBilling}} {{#if this.showBilling}}
<GhBillingModal @billingWindowOpen={{this.billing.billingWindowOpen}} /> <GhBillingModal @billingWindowOpen={{this.billing.billingWindowOpen}} />
{{/if}} {{/if}}
{{#if (feature "exploreApp")}}
<GhExploreModal /> <GhExploreModal />
{{/if}}
</main> </main>

13
ghost/admin/app/templates/settings/labs.hbs
View file

@ -258,19 +258,6 @@
</div> </div>
</div> </div>
</div> </div>
<div class="gh-expandable-block">
<div class="gh-expandable-header">
<div>
<h4 class="gh-expandable-title">Explore app</h4>
<p class="gh-expandable-description">
Enable the Explore iframe app.
</p>
</div>
<div class="for-switch">
<GhFeatureFlag @flag="exploreApp" />
</div>
</div>
</div>
<div class="gh-expandable-block"> <div class="gh-expandable-block">
<div class="gh-expandable-header"> <div class="gh-expandable-header">
<div> <div>

1
ghost/core/core/shared/labs.js
View file

@ -35,7 +35,6 @@ const ALPHA_FEATURES = [
'urlCache', 'urlCache',
'beforeAfterCard', 'beforeAfterCard',
'lexicalEditor', 'lexicalEditor',
'exploreApp',
'audienceFeedback' 'audienceFeedback'
]; ];