Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:18:42 -05:00
Code Issues Activity

Removed richTwitterNewsletters GA labs flag

Browse source 
refs https://github.com/TryGhost/Team/issues/1258

- conditional custom-processing of twitter embeds is GA so no longer needs the flag or conditional
This commit is contained in:
Kevin Ansfield 2022-01-04 13:07:39 +00:00
parent cd745e09a8
commit afb402991d
2 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
core/server/services/twitter-embed.js
View file

@ -1,6 +1,5 @@
const {extract} = require('oembed-parser'); const {extract} = require('oembed-parser');
const logging = require('@tryghost/logging'); const logging = require('@tryghost/logging');
const labs = require('../../shared/labs');
/** /**
* @typedef {import('./oembed').ICustomProvider} ICustomProvider * @typedef {import('./oembed').ICustomProvider} ICustomProvider
@ -43,7 +42,7 @@ class TwitterOEmbedProvider {
/** @type {object} */ /** @type {object} */
const oembedData = await extract(url.href); const oembedData = await extract(url.href);
if (this.dependencies.config.bearerToken && labs.isSet('richTwitterNewsletters')) { if (this.dependencies.config.bearerToken) {
const query = { const query = {
expansions: ['attachments.poll_ids', 'attachments.media_keys', 'author_id', 'entities.mentions.username', 'geo.place_id', 'in_reply_to_user_id', 'referenced_tweets.id', 'referenced_tweets.id.author_id'], expansions: ['attachments.poll_ids', 'attachments.media_keys', 'author_id', 'entities.mentions.username', 'geo.place_id', 'in_reply_to_user_id', 'referenced_tweets.id', 'referenced_tweets.id.author_id'],
'media.fields': ['duration_ms', 'height', 'media_key', 'preview_image_url', 'type', 'url', 'width', 'public_metrics', 'alt_text'], 'media.fields': ['duration_ms', 'height', 'media_key', 'preview_image_url', 'type', 'url', 'width', 'public_metrics', 'alt_text'],

1
core/shared/labs.js
View file

@ -15,7 +15,6 @@ const messages = {
// flags in this list always return `true`, allows quick global enable prior to full flag removal // flags in this list always return `true`, allows quick global enable prior to full flag removal
const GA_FEATURES = [ const GA_FEATURES = [
'richTwitterNewsletters',
'audioCard', 'audioCard',
'mediaAPI', 'mediaAPI',
'membersAutoLogin', 'membersAutoLogin',