From afb402991d9ff377f9dacc9e7dd91ad4896580e9 Mon Sep 17 00:00:00 2001 From: Kevin Ansfield Date: Tue, 4 Jan 2022 13:07:39 +0000 Subject: [PATCH] Removed `richTwitterNewsletters` GA labs flag refs https://github.com/TryGhost/Team/issues/1258 - conditional custom-processing of twitter embeds is GA so no longer needs the flag or conditional --- core/server/services/twitter-embed.js | 3 +-- core/shared/labs.js | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/core/server/services/twitter-embed.js b/core/server/services/twitter-embed.js index ec40c3a0af..e5ee1322be 100644 --- a/core/server/services/twitter-embed.js +++ b/core/server/services/twitter-embed.js @@ -1,6 +1,5 @@ const {extract} = require('oembed-parser'); const logging = require('@tryghost/logging'); -const labs = require('../../shared/labs'); /** * @typedef {import('./oembed').ICustomProvider} ICustomProvider @@ -43,7 +42,7 @@ class TwitterOEmbedProvider { /** @type {object} */ const oembedData = await extract(url.href); - if (this.dependencies.config.bearerToken && labs.isSet('richTwitterNewsletters')) { + if (this.dependencies.config.bearerToken) { const query = { expansions: ['attachments.poll_ids', 'attachments.media_keys', 'author_id', 'entities.mentions.username', 'geo.place_id', 'in_reply_to_user_id', 'referenced_tweets.id', 'referenced_tweets.id.author_id'], 'media.fields': ['duration_ms', 'height', 'media_key', 'preview_image_url', 'type', 'url', 'width', 'public_metrics', 'alt_text'], diff --git a/core/shared/labs.js b/core/shared/labs.js index 078189295c..4ae4a385cd 100644 --- a/core/shared/labs.js +++ b/core/shared/labs.js @@ -15,7 +15,6 @@ const messages = { // flags in this list always return `true`, allows quick global enable prior to full flag removal const GA_FEATURES = [ - 'richTwitterNewsletters', 'audioCard', 'mediaAPI', 'membersAutoLogin',