Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

Bumped Node versions in CI

Browse source 
- we should be running most of CI on Node 20
- this has fallen out of sync because we declare the version in so many
  places
- to help with this, I've extracted the Node version to an env var, and
  re-used that across the workflow
This commit is contained in:
Daniel Lockyer 2024-10-23 10:48:27 +02:00 • committed by Daniel Lockyer
parent cb453febe9
commit 8fb7da4be0
1 changed files with 15 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
.github/workflows/ci.yml vendored
View file

@ -18,6 +18,7 @@ env:
CACHED_BUILD_PATHS: | CACHED_BUILD_PATHS: |
${{ github.workspace }}/ghost/*/build ${{ github.workspace }}/ghost/*/build
NX_REJECT_UNKNOWN_LOCAL_CACHE: 0 NX_REJECT_UNKNOWN_LOCAL_CACHE: 0
NODE_VERSION: 20.11.1
concurrency: concurrency:
group: ${{ github.head_ref || github.run_id }} group: ${{ github.head_ref || github.run_id }}
@ -171,7 +172,7 @@ jobs:
env: env:
FORCE_COLOR: 0 FORCE_COLOR: 0
with: with:
node-version: '18.12.1' node-version: ${{ env.NODE_VERSION }}
cache: yarn cache: yarn
- name: Install dependencies - name: Install dependencies
@ -211,7 +212,7 @@ jobs:
env: env:
FORCE_COLOR: 0 FORCE_COLOR: 0
with: with:
node-version: '18.12.1' node-version: ${{ env.NODE_VERSION }}
- name: Restore caches - name: Restore caches
uses: ./.github/actions/restore-cache uses: ./.github/actions/restore-cache
@ -246,7 +247,7 @@ jobs:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
- uses: actions/setup-node@v4 - uses: actions/setup-node@v4
with: with:
node-version: "18.12.1" node-version: ${{ env.NODE_VERSION }}
- name: Restore caches - name: Restore caches
uses: ./.github/actions/restore-cache uses: ./.github/actions/restore-cache
@ -270,7 +271,7 @@ jobs:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
- uses: actions/setup-node@v4 - uses: actions/setup-node@v4
with: with:
node-version: "18.12.1" node-version: ${{ env.NODE_VERSION }}
- name: Restore caches - name: Restore caches
uses: ./.github/actions/restore-cache uses: ./.github/actions/restore-cache
@ -314,7 +315,7 @@ jobs:
env: env:
FORCE_COLOR: 0 FORCE_COLOR: 0
with: with:
node-version: '18.x' node-version: ${{ env.NODE_VERSION }}
cache: yarn cache: yarn
- name: Install Stripe-CLI - name: Install Stripe-CLI
@ -388,7 +389,7 @@ jobs:
env: env:
FORCE_COLOR: 0 FORCE_COLOR: 0
with: with:
node-version: '18.12.1' node-version: ${{ env.NODE_VERSION }}
- name: Restore caches - name: Restore caches
uses: ./.github/actions/restore-cache uses: ./.github/actions/restore-cache
@ -476,7 +477,7 @@ jobs:
- DB: mysql8 - DB: mysql8
NODE_ENV: testing-mysql NODE_ENV: testing-mysql
include: include:
- node: 18.12.1 - node: 20.11.1
env: env:
DB: sqlite3 DB: sqlite3
NODE_ENV: testing NODE_ENV: testing
@ -598,11 +599,11 @@ jobs:
strategy: strategy:
matrix: matrix:
include: include:
- node: 18.12.1 - node: 20.11.1
env: env:
DB: mysql8 DB: mysql8
NODE_ENV: testing-mysql NODE_ENV: testing-mysql
- node: 18.12.1 - node: 20.11.1
env: env:
DB: sqlite3 DB: sqlite3
NODE_ENV: testing NODE_ENV: testing
@ -669,7 +670,7 @@ jobs:
env: env:
FORCE_COLOR: 0 FORCE_COLOR: 0
with: with:
node-version: "18.12.1" node-version: ${{ env.NODE_VERSION }}
- name: Restore caches - name: Restore caches
uses: ./.github/actions/restore-cache uses: ./.github/actions/restore-cache
@ -722,7 +723,7 @@ jobs:
env: env:
FORCE_COLOR: 0 FORCE_COLOR: 0
with: with:
node-version: "18.12.1" node-version: ${{ env.NODE_VERSION }}
- name: Restore caches - name: Restore caches
uses: ./.github/actions/restore-cache uses: ./.github/actions/restore-cache
@ -775,7 +776,7 @@ jobs:
env: env:
FORCE_COLOR: 0 FORCE_COLOR: 0
with: with:
node-version: "18.12.1" node-version: ${{ env.NODE_VERSION }}
- name: Restore caches - name: Restore caches
uses: ./.github/actions/restore-cache uses: ./.github/actions/restore-cache
@ -857,7 +858,7 @@ jobs:
env: env:
FORCE_COLOR: 0 FORCE_COLOR: 0
with: with:
node-version: '18.12.1' node-version: ${{ env.NODE_VERSION }}
- name: Update from v4 - name: Update from v4
run: | run: |
@ -1025,7 +1026,7 @@ jobs:
- name: Set up Node.js - name: Set up Node.js
uses: actions/setup-node@v4 uses: actions/setup-node@v4
with: with:
node-version: '18.12.1' node-version: ${{ env.NODE_VERSION }}
- name: Restore caches - name: Restore caches
uses: ./.github/actions/restore-cache uses: ./.github/actions/restore-cache