From 8fb7da4be0db2305a4ffc4474dd0131c82b11ae4 Mon Sep 17 00:00:00 2001
From: Daniel Lockyer <hi@daniellockyer.com>
Date: Wed, 23 Oct 2024 10:48:27 +0200
Subject: [PATCH] Bumped Node versions in CI

- we should be running most of CI on Node 20
- this has fallen out of sync because we declare the version in so many
  places
- to help with this, I've extracted the Node version to an env var, and
  re-used that across the workflow
---
 .github/workflows/ci.yml | 29 +++++++++++++++--------------
 1 file changed, 15 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 6bc1a53801..7a88b03677 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -18,6 +18,7 @@ env:
   CACHED_BUILD_PATHS: |
     ${{ github.workspace }}/ghost/*/build
   NX_REJECT_UNKNOWN_LOCAL_CACHE: 0
+  NODE_VERSION: 20.11.1
 
 concurrency:
   group: ${{ github.head_ref || github.run_id }}
@@ -171,7 +172,7 @@ jobs:
         env:
           FORCE_COLOR: 0
         with:
-          node-version: '18.12.1'
+          node-version: ${{ env.NODE_VERSION }}
           cache: yarn
 
       - name: Install dependencies
@@ -211,7 +212,7 @@ jobs:
         env:
           FORCE_COLOR: 0
         with:
-          node-version: '18.12.1'
+          node-version: ${{ env.NODE_VERSION }}
 
       - name: Restore caches
         uses: ./.github/actions/restore-cache
@@ -246,7 +247,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: "18.12.1"
+          node-version: ${{ env.NODE_VERSION }}
 
       - name: Restore caches
         uses: ./.github/actions/restore-cache
@@ -270,7 +271,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: "18.12.1"
+          node-version: ${{ env.NODE_VERSION }}
 
       - name: Restore caches
         uses: ./.github/actions/restore-cache
@@ -314,7 +315,7 @@ jobs:
       env:
         FORCE_COLOR: 0
       with:
-        node-version: '18.x'
+        node-version: ${{ env.NODE_VERSION }}
         cache: yarn
 
     - name: Install Stripe-CLI
@@ -388,7 +389,7 @@ jobs:
         env:
           FORCE_COLOR: 0
         with:
-          node-version: '18.12.1'
+          node-version: ${{ env.NODE_VERSION }}
 
       - name: Restore caches
         uses: ./.github/actions/restore-cache
@@ -476,7 +477,7 @@ jobs:
           - DB: mysql8
             NODE_ENV: testing-mysql
         include:
-          - node: 18.12.1
+          - node: 20.11.1
             env:
               DB: sqlite3
               NODE_ENV: testing
@@ -598,11 +599,11 @@ jobs:
     strategy:
       matrix:
         include:
-          - node: 18.12.1
+          - node: 20.11.1
             env:
               DB: mysql8
               NODE_ENV: testing-mysql
-          - node: 18.12.1
+          - node: 20.11.1
             env:
               DB: sqlite3
               NODE_ENV: testing
@@ -669,7 +670,7 @@ jobs:
         env:
           FORCE_COLOR: 0
         with:
-          node-version: "18.12.1"
+          node-version: ${{ env.NODE_VERSION }}
 
       - name: Restore caches
         uses: ./.github/actions/restore-cache
@@ -722,7 +723,7 @@ jobs:
         env:
           FORCE_COLOR: 0
         with:
-          node-version: "18.12.1"
+          node-version: ${{ env.NODE_VERSION }}
 
       - name: Restore caches
         uses: ./.github/actions/restore-cache
@@ -775,7 +776,7 @@ jobs:
         env:
           FORCE_COLOR: 0
         with:
-          node-version: "18.12.1"
+          node-version: ${{ env.NODE_VERSION }}
 
       - name: Restore caches
         uses: ./.github/actions/restore-cache
@@ -857,7 +858,7 @@ jobs:
         env:
           FORCE_COLOR: 0
         with:
-          node-version: '18.12.1'
+          node-version: ${{ env.NODE_VERSION }}
 
       - name: Update from v4
         run: |
@@ -1025,7 +1026,7 @@ jobs:
       - name: Set up Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: '18.12.1'
+          node-version: ${{ env.NODE_VERSION }}
 
       - name: Restore caches
         uses: ./.github/actions/restore-cache