Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

Renamed logout middleware to deleteSession

Browse source 
no issue

- This rename is meant to clarify what exactly happens behind the logout and be inline with `login`-> `getIdentityToken` rename
This commit is contained in:
Nazar Gargol 2019-11-28 14:53:30 +07:00 • committed by Fabien O'Carroll
parent 046bd652e5
commit 0be2c21f68
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
core/server/services/members/middleware.js
View file

@ -16,7 +16,7 @@ const getIdentityToken = async function (req, res) {
} }
}; };
const logout = async function (req, res) { const deleteSession = async function (req, res) {
try { try {
await membersService.ssr.deleteSession(req, res); await membersService.ssr.deleteSession(req, res);
res.writeHead(204); res.writeHead(204);
@ -86,9 +86,9 @@ module.exports = {
shared.middlewares.labs.members, shared.middlewares.labs.members,
getIdentityToken getIdentityToken
], ],
logout: [ deleteSession: [
shared.middlewares.labs.members, shared.middlewares.labs.members,
logout deleteSession
], ],
stripeWebhooks: [ stripeWebhooks: [
shared.middlewares.labs.members, shared.middlewares.labs.members,

2
core/server/web/site/app.js
View file

@ -120,7 +120,7 @@ module.exports = function setupSiteApp(options = {}) {
// Members middleware // Members middleware
// Initializes members specific routes as well as assigns members specific data to the req/res objects // Initializes members specific routes as well as assigns members specific data to the req/res objects
siteApp.get('/members/ssr', membersMiddleware.getIdentityToken); siteApp.get('/members/ssr', membersMiddleware.getIdentityToken);
siteApp.delete('/members/ssr', membersMiddleware.logout); siteApp.delete('/members/ssr', membersMiddleware.deleteSession);
siteApp.post('/members/webhooks/stripe', membersMiddleware.stripeWebhooks); siteApp.post('/members/webhooks/stripe', membersMiddleware.stripeWebhooks);
siteApp.use(membersMiddleware.authentication); siteApp.use(membersMiddleware.authentication);