From 0be2c21f684568442c18888c1f438d4085bf199b Mon Sep 17 00:00:00 2001 From: Nazar Gargol Date: Thu, 28 Nov 2019 14:53:30 +0700 Subject: [PATCH] Renamed logout middleware to deleteSession no issue - This rename is meant to clarify what exactly happens behind the logout and be inline with `login`-> `getIdentityToken` rename --- core/server/services/members/middleware.js | 6 +++--- core/server/web/site/app.js | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/core/server/services/members/middleware.js b/core/server/services/members/middleware.js index 4bb9cd05e0..982eb0f2ed 100644 --- a/core/server/services/members/middleware.js +++ b/core/server/services/members/middleware.js @@ -16,7 +16,7 @@ const getIdentityToken = async function (req, res) { } }; -const logout = async function (req, res) { +const deleteSession = async function (req, res) { try { await membersService.ssr.deleteSession(req, res); res.writeHead(204); @@ -86,9 +86,9 @@ module.exports = { shared.middlewares.labs.members, getIdentityToken ], - logout: [ + deleteSession: [ shared.middlewares.labs.members, - logout + deleteSession ], stripeWebhooks: [ shared.middlewares.labs.members, diff --git a/core/server/web/site/app.js b/core/server/web/site/app.js index e5306c9128..de0c146b9a 100644 --- a/core/server/web/site/app.js +++ b/core/server/web/site/app.js @@ -120,7 +120,7 @@ module.exports = function setupSiteApp(options = {}) { // Members middleware // Initializes members specific routes as well as assigns members specific data to the req/res objects siteApp.get('/members/ssr', membersMiddleware.getIdentityToken); - siteApp.delete('/members/ssr', membersMiddleware.logout); + siteApp.delete('/members/ssr', membersMiddleware.deleteSession); siteApp.post('/members/webhooks/stripe', membersMiddleware.stripeWebhooks); siteApp.use(membersMiddleware.authentication);