Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-04-01 02:41:39 -05:00
Code Issues Activity

Added concurency limit for member creation when importing

Browse source 
no issue

- When importing large batches of members we should not allow for unlimited amount of parallel requests created as this might lead to connection pool problems and reaching API rate limits (for example Stripe API is limited to 100 req/s)
This commit is contained in:
Nazar Gargol 2020-02-10 16:03:08 +08:00
parent 6a6413cec5
commit 019605e9e0
1 changed files with 14 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
core/server/api/canary/members.js
View file

@ -312,7 +312,7 @@ const members = {
const sanitized = sanitizeInput(result);
invalid += result.length - sanitized.length;
return Promise.all(sanitized.map((entry) => {
return Promise.map(sanitized, ((entry) => {
const api = require('./index');
cleanupUndefined(entry);
@ -332,20 +332,21 @@ const members = {
options: {send_email: false}
}
})).reflect();
})).each((inspection) => {
if (inspection.isFulfilled()) {
fulfilled = fulfilled + 1;
} else {
if (inspection.reason() instanceof common.errors.ValidationError) {
duplicates = duplicates + 1;
}), {concurrency: 10})
.each((inspection) => {
if (inspection.isFulfilled()) {
fulfilled = fulfilled + 1;
} else {
// NOTE: if the error happens as a result of pure API call it doesn't get logged anywhere
// for this reason we have to make sure any unexpected errors are logged here
common.logging.error(inspection.reason());
invalid = invalid + 1;
if (inspection.reason() instanceof common.errors.ValidationError) {
duplicates = duplicates + 1;
} else {
// NOTE: if the error happens as a result of pure API call it doesn't get logged anywhere
// for this reason we have to make sure any unexpected errors are logged here
common.logging.error(inspection.reason());
invalid = invalid + 1;
}
}
}
});
});
}).then(() => {
return {
meta: {