From 019605e9e0fac95c0de0c5598b2c72c7b97d35ae Mon Sep 17 00:00:00 2001
From: Nazar Gargol <nazargargol@gmail.com>
Date: Mon, 10 Feb 2020 16:03:08 +0800
Subject: [PATCH] Added concurency limit for member creation when importing

no issue

- When importing large batches of members we should not allow for unlimited amount of parallel requests created as this might lead to connection pool problems and reaching API rate limits (for example Stripe API is limited to 100 req/s)
---
 core/server/api/canary/members.js | 27 ++++++++++++++-------------
 1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/core/server/api/canary/members.js b/core/server/api/canary/members.js
index 0f73bd9913..0337d49573 100644
--- a/core/server/api/canary/members.js
+++ b/core/server/api/canary/members.js
@@ -312,7 +312,7 @@ const members = {
                 const sanitized = sanitizeInput(result);
                 invalid += result.length - sanitized.length;
 
-                return Promise.all(sanitized.map((entry) => {
+                return Promise.map(sanitized, ((entry) => {
                     const api = require('./index');
 
                     cleanupUndefined(entry);
@@ -332,20 +332,21 @@ const members = {
                             options: {send_email: false}
                         }
                     })).reflect();
-                })).each((inspection) => {
-                    if (inspection.isFulfilled()) {
-                        fulfilled = fulfilled + 1;
-                    } else {
-                        if (inspection.reason() instanceof common.errors.ValidationError) {
-                            duplicates = duplicates + 1;
+                }), {concurrency: 10})
+                    .each((inspection) => {
+                        if (inspection.isFulfilled()) {
+                            fulfilled = fulfilled + 1;
                         } else {
-                            // NOTE: if the error happens as a result of pure API call it doesn't get logged anywhere
-                            //       for this reason we have to make sure any unexpected errors are logged here
-                            common.logging.error(inspection.reason());
-                            invalid = invalid + 1;
+                            if (inspection.reason() instanceof common.errors.ValidationError) {
+                                duplicates = duplicates + 1;
+                            } else {
+                                // NOTE: if the error happens as a result of pure API call it doesn't get logged anywhere
+                                //       for this reason we have to make sure any unexpected errors are logged here
+                                common.logging.error(inspection.reason());
+                                invalid = invalid + 1;
+                            }
                         }
-                    }
-                });
+                    });
             }).then(() => {
                 return {
                     meta: {