mirror of
https://github.com/withastro/astro.git
synced 2024-12-16 21:46:22 -05:00
e90f5593d2
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
50 lines
1.4 KiB
Markdown
50 lines
1.4 KiB
Markdown
---
|
|
'astro': major
|
|
---
|
|
|
|
Fixes attribute rendering for non-[boolean HTML attributes](https://developer.mozilla.org/en-US/docs/Glossary/Boolean/HTML) with boolean values to match proper attribute handling in browsers.
|
|
|
|
Previously, non-boolean attributes may not have included their values when rendered to HTML. In Astro v5.0, the values are now explicitly rendered as `="true"` or `="false"`
|
|
|
|
In the following `.astro` examples, only `allowfullscreen` is a boolean attribute:
|
|
|
|
```astro
|
|
<!-- src/pages/index.astro -->
|
|
<!-- `allowfullscreen` is a boolean attribute -->
|
|
<p allowfullscreen={true}></p>
|
|
<p allowfullscreen={false}></p>
|
|
|
|
<!-- `inherit` is *not* a boolean attribute -->
|
|
<p inherit={true}></p>
|
|
<p inherit={false}></p>
|
|
|
|
<!-- `data-*` attributes are not boolean attributes -->
|
|
<p data-light={true}></p>
|
|
<p data-light={false}></p>
|
|
```
|
|
|
|
Astro v5.0 now preserves the full data attribute with its value when rendering the HTML of non-boolean attributes:
|
|
|
|
```diff
|
|
<p allowfullscreen></p>
|
|
<p></p>
|
|
|
|
<p inherit="true"></p>
|
|
- <p inherit></p>
|
|
+ <p inherit="false"></p>
|
|
|
|
- <p data-light></p>
|
|
+ <p data-light="true"></p>
|
|
- <p></p>
|
|
+ <p data-light="false"></p>
|
|
```
|
|
|
|
If you rely on attribute values, for example to locate elements or to conditionally render, update your code to match the new non-boolean attribute values:
|
|
|
|
```diff
|
|
- el.getAttribute('inherit') === ''
|
|
+ el.getAttribute('inherit') === 'false'
|
|
|
|
- el.hasAttribute('data-light')
|
|
+ el.dataset.light === 'true'
|
|
```
|