Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2024-12-16 21:46:22 -05:00
Code Issues Activity
8400 commits 314 branches 2281 tags 459 MiB
Commit graph

8400 commits

This branch
This branch
All branches
Author SHA1 Message Date
Jeff R
6e5676862b
sort newest to oldest (#11587) 
* sort newest to oldest

* Update pubDate to preserve a meaningful order in the examples/blog folder
 2024-08-05 13:30:06 +02:00
Abu Bakr
196092ae69
fix: audit incorrectly flagging images as above the fold (#10891) (#11617) 
* fix: audit incorrectly flagging images as above the fold (#10891)

Previously used lement.offsetTop to find the y position of the image, which does not work when the element parent has a position: relative property.
Instead, this uses lement.getBoundingClientRect().y top get real y position of the image.
There's one issue though, which is that getBoundingClientRect returns the position relative to the user's viewport, not the absolute position.
So, add window.scrollY to the value to cancel that effect out, and you have the element's absolute position.

https://developer.mozilla.org/en-US/docs/Web/API/Element/getBoundingClientRect
https://developer.mozilla.org/en-US/docs/Web/API/Window/scrollY

* chore: add changeset
 2024-08-05 13:29:20 +02:00
renovate[bot]
da86d5459f
fix(deps): update all non-major dependencies (#11618) 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-08-05 16:22:43 +08:00
renovate[bot]
bc2796436d
chore(deps): update dependency postcss-preset-env to v10 (#11619) 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-08-05 10:06:00 +08:00
Armand Philippot
09ec2cadce
fix(astro:content): add deprecated to getEntryBySlug & getDataEntryById (#11600) 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
 2024-08-02 16:31:32 +02:00
Sarah Rainsberger
1b3c81c684
[error docs] adds section heading for Actions (#11601) 2024-08-02 11:02:54 -03:00
Houston (Bot)
2abbc281b3
[ci] release (#11590) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2024-08-02 09:18:47 -04:00
Mateusz Ż
19adfaa705
chore: Remove unnecessary CSS in basic example (#11596) 2024-08-02 20:21:40 +08:00
Bjorn Lu
d052428e38 [ci] format 2024-08-02 12:20:29 +00:00
Bjorn Lu
69d54b4bf2
Remove more unused code (#11598) 2024-08-02 20:19:41 +08:00
Bjorn Lu
c2d6c1f727
Remove unused code (#11592) 2024-08-02 10:15:42 +08:00
Ben Holmes
ac72ed2f55 [ci] format 2024-08-01 12:25:19 +00:00
Ben Holmes
a65ffe314b
Actions: Remove async local storage dependency (#11584) 
* refactor: move from Async local storage to .bind()

* feat: Astro.callAction for server calls

* feat(e2e): update server call

* feat(types): test callAction types

* fix: callAction context on rewrite

* feat: called from server error

* chore: remove store.ts file

* chore: remove getApiContext client stub

* chore: changeset

* fix: src -> dist import

* refactor: move content collection errors together

* fix: move rfc link to hint
 2024-08-01 08:24:22 -04:00
Emanuele Stoppa
2531abdab2 [ci] format 2024-08-01 10:49:03 +00:00
Emanuele Stoppa
2e9d183361
fix: changelog formatting (#11589) 2024-08-01 11:48:14 +01:00
Houston (Bot)
4474887937
[ci] release (#11578) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2024-08-01 11:55:37 +02:00
Sarah Rainsberger
6aaeec5034
Update errors-data.ts for Astro.rewrite release in 4.13 (#11580) 
* Update errors-data.ts

* chore: remove unused error

* deprecate the error instead

---------

Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
 2024-07-31 14:41:52 +01:00
renovate[bot]
750d5328c9
fix(deps): update all non-major dependencies (#11565) 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-07-31 21:17:26 +08:00
Emanuele Stoppa
45ad326932
feat: stabilise the rewrite APIs (#11542) 
* feat: stabilise the rewrite APIs

* chore: rewrite changeset

* oops

* Apply suggestions from code review

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* chore: fix linting

* fix: update exemple

* code formatting

* edit changeset code examples

---------

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
 2024-07-31 12:51:13 +02:00
Emanuele Stoppa
a62345fd18
feat: log slow pages in red (#11507) 
* fix: log slow pages in red

* apply feedback

* chore: update based on feedback

* Update .changeset/spotty-rice-shake.md

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

---------

Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
 2024-07-31 12:37:08 +02:00
Alexander Niebuhr
2cf770d759 [ci] format 2024-07-31 10:18:28 +00:00
Alexander Niebuhr
e5e2d3ed30
chore: unflag contentCollectionJsonSchema (#11379) 
* chore: unflag contentCollectionJsonSchema

* chore: improve json schema generation

* remove config option

* Update tasty-spoons-double.md

* Update tasty-spoons-double.md

* Update .changeset/tasty-spoons-double.md

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update .changeset/tasty-spoons-double.md

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update .changeset/tasty-spoons-double.md

* revert whitespace changes

* revert whitespace changes

* revert whitespace changes

* revert whitespace changes

---------

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
 2024-07-31 12:17:38 +02:00
Matthew Phillips
60b2766edb
Verify you can use server:defer on self-imported module (#11577) 2024-07-30 15:48:30 -04:00
Houston (Bot)
49db00444e
[ci] release (#11524) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2024-07-30 11:54:54 -04:00
Ben Holmes
9f766d8b58 [ci] format 2024-07-30 15:43:44 +00:00
Ben Holmes
1c3265a8c9
Actions: Make .safe() the default return value (#11571) 
* feat: new orThrow types

* fix: parens on return type

* feat: switch implementation to orThrow()

* feat(e2e): update PostComment

* fix: remove callSafely from middleware

* fix: toString() for actions

* fix(e2e): more orThrow updates

* feat: remove progressive enhancement from orThrow

* fix: remove _astroActionSafe handler from react

* feat(e2e): update test to use safe calling

* chore: console log

* chore: unused import

* fix: add rewriting: true to test fixture

* fix: correctly throw for server-only actions

* chore: changeset

* fix: update type tests

* fix(test): remove .safe() chain

* docs: use "patch" with BREAKING CHANGE notice

* docs: clarify react integration in changeset
 2024-07-30 11:42:52 -04:00
Ben Holmes
a77ed84759 [ci] format 2024-07-30 15:05:04 +00:00
Ben Holmes
84189b6511
Actions: New fallback behavior with action={actions.name} (#11570) 
* feat: support _astroAction query param

* feat(test): _astroAction query param

* fix: handle _actions requests from legacy fallback

* feat(e2e): new actions pattern on blog test

* feat: update React 19 adapter to use query params

* fix: remove legacy getApiContext()

* feat: ActionQueryStringInvalidError

* fix: update error description

* feat: ActionQueryStringInvalidError

* chore: comment on _actions skip

* feat: .queryString property

* chore: comment on throw new Error

* chore: better guess for "why" on query string

* chore: remove console log

* chore: changeset

* chore: changeset
 2024-07-30 11:04:10 -04:00
Bryan Wood
1953dbbd41
actions: check result.data is not undefined instead of truthy (#11559) 
* actions: check result.data is not undefined instead of truthy

* add changeset

* Update .changeset/tasty-rockets-jog.md

---------

Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
 2024-07-30 10:32:36 -04:00
Erika
e3f29d416a
fix: highlight line with error in the error overlay (#11574) 
* fix: highlight line with error in the error overlay

* chore: changeset

* Update packages/astro/e2e/errors.test.js

Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>

---------

Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
 2024-07-30 15:26:51 +02:00
Erika
0dcef3ab17
fix: check before writing to errors (#11566) 
* fix: check before writing to errors

* fix: try using try catches

* test: add

* chore: changeset

* nit: test name
 2024-07-29 17:44:59 +02:00
Matt Kane
d27cf6df7b
fix(create-astro): log fetch errors (#11567) 2024-07-29 13:49:01 +01:00
Matthew Phillips
504c383e20
Fix server islands with trailingSlash: always (#11529) 
* Fix server islands with trailingSlash: always

* Fix test missing trailingslash

* Prepend base to the server island URL

* Add tests for base
 2024-07-26 13:54:10 -04:00
Armand Philippot
904f1e535a
fix(types): change page.size to 10 in JSDoc comment (#11561) 2024-07-26 21:16:26 +08:00
Emanuele Stoppa
02c85b5412
fix: cache collections using file name too (#11553) 
* fix: cache collections using file name too

* oops
 2024-07-25 18:14:08 +01:00
Reuben Tier
602c5bf05d
Fix astro add for prerelease packages (#11548) 
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
Co-authored-by: Bjorn Lu <34116392+bluwy@users.noreply.github.com>
 2024-07-25 12:04:46 +02:00
Armand Philippot
7f26de906e
fix(types): update Astro.redirect JSDoc comment (#11546) 
* fix(types): update Astro.redirect JSDoc comment

* add changeset
 2024-07-24 19:54:21 +01:00
Josh Goldberg ✨
d94247528d [ci] format 2024-07-24 15:43:59 +00:00
Josh Goldberg ✨
87c179a5f3
chore: bump @typescript-eslint/no-unused-vars to error internally (#11173) 
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
Co-authored-by: Martin Trapp <94928215+martrapp@users.noreply.github.com>
 2024-07-24 23:43:07 +08:00
renovate[bot]
536209aa74
fix(deps): update all non-major dependencies (#11522) 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: bluwy <bjornlu.dev@gmail.com>
 2024-07-23 11:43:14 +08:00
Emanuele Stoppa
80681318c6
fix(actions): resolve actions when there aren't user actions (#11525) 
* fix(actions): pass path as input

* revert code

* chore: apply suggestions
 2024-07-22 13:15:34 +01:00
Bjorn Lu
dfbca06dda
Exclude hoisted scripts and styles from raw imports (#11509) 2024-07-22 16:10:48 +08:00
Houston (Bot)
a6c4e67544
[ci] release (#11504) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2024-07-19 10:06:49 -04:00
Malte Ubl
ca335e1dc0
Fix an XSS in Server Islands. (#11508) 
* Fix an XSS in Server Islands.

Discussed with @FredKSchott that this is OK to disclose since Server Islands are still experimental.

It's generally not safe to use `JSON.stringify` to interpolate potentially attacker controlled data into `<script>` tags as JSON doesn't escape `<>"'` and so one can use it to break out of the script tag and e.g. make a new one with controlled content.

See https://pragmaticwebsecurity.com/articles/spasecurity/json-stringify-xss

* Format

* Create smart-snakes-promise.md

* Switch to manual encoding

---------

Co-authored-by: Matt Kane <m@mk.gg>
 2024-07-19 15:02:14 +01:00
Sarah Rainsberger
026e8baf33
[docs] fix typos in config reference (#11506) 
* [docs] fix typos in config reference

* Create empty-onions-buy.md
 2024-07-19 12:57:23 +01:00
Emanuele Stoppa
df89cfd3e3 [ci] format 2024-07-19 11:45:56 +00:00
Emanuele Stoppa
8ff7658001
fix: better logging for rewrites (#11505) 
* fix: better logging for rewrites

* fix: better logging for rewrites

* apply feedback
 2024-07-19 12:45:10 +01:00
Martin Trapp
4db78ae046
Adds missing export (#11501) 2024-07-19 07:57:30 +01:00
Houston (Bot)
745ce44dd3
[ci] release (#11492) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2024-07-18 23:30:35 +02:00
Erika
4e142d38cb
fix: inferRemoteSize not being exported in the type (#11500) 2024-07-18 23:16:36 +02:00