Penpot/penpot
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-01-23 06:58:58 -05:00
Code Issues Activity

🐛 Enhancement on old thumbnail invalidation after sync

Browse source
This commit is contained in:
Pablo Alba 2023-12-04 13:24:59 +01:00 • committed by Andrés Moya
parent 3e965c96e7
commit fc1db9b985
2 changed files with 61 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

53
common/src/app/common/files/changes.cljc
View file

@ -804,3 +804,56 @@
[_ _]
nil)
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Copies changes detection
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Analyze one change and checks if if modifies any shape belonging to
;; a main or a copy. Return the ids of the mains or copies affected
(defn- find-all-heads
"Go trough the parents and get all of them that are a head of a component."
[id objects]
(->> (cfh/get-parents-with-self objects id)
(filter ctk/instance-head?)))
(defmulti heads-changed (fn [_ change] (:type change)))
(defmethod heads-changed :mod-obj
[file-data {:keys [id page-id _component-id operations]}]
(when page-id
(let [page (ctpl/get-page file-data page-id)
need-sync? (fn [operation]
; Check if the shape has changed any
; attribute that participates in components synchronization.
(and (= (:type operation) :set)
(get ctk/sync-attrs (:attr operation))))
any-sync? (some need-sync? operations)]
(when any-sync?
(find-all-heads id (:objects page))))))
(defmethod heads-changed :mov-objects
[file-data {:keys [page-id _component-id parent-id shapes] :as change}]
(when page-id
(let [page (ctpl/get-page file-data page-id)]
(concat
(find-all-heads parent-id (:objects page))
(mapcat #(find-all-heads (:parent-id %) (:objects page)) shapes)))))
(defmethod heads-changed :add-obj
[file-data {:keys [parent-id page-id _component-id] :as change}]
(when page-id
(let [page (ctpl/get-page file-data page-id)]
(find-all-heads parent-id (:objects page)))))
(defmethod heads-changed :del-obj
[file-data {:keys [id page-id _component-id] :as change}]
(when page-id
(let [page (ctpl/get-page file-data page-id)]
(find-all-heads id (:objects page)))))
(defmethod heads-changed :default
[_ _]
nil)

17
frontend/src/app/main/data/workspace/libraries.cljs
View file

@ -946,17 +946,16 @@
changes (pcb/concat-changes library-changes file-changes)
extract-shapes (fn [change]
(for [page-id [(:page-id change)]
id (:shapes change)]
(-> (get-in state [:workspace-data :pages-index page-id :objects id])
(assoc :page-id page-id))))
updated-copies (->> changes
find-heads (fn [change]
(->> (ch/heads-changed file change)
(map #(assoc %1 :page-id (:page-id change)))))
updated-copies (->> changes
:redo-changes
(filter #(= (:type %) :reg-objects))
(mapcat extract-shapes)
(filter ctk/instance-head?)
(mapcat find-heads)
distinct)]
(log/debug :msg "SYNC-FILE finished" :js/rchanges (log-changes