From fbe09e6b5a8c68a48d3bb6d884cf917a99f07ec2 Mon Sep 17 00:00:00 2001
From: Eva Marco <evamarcod@gmail.com>
Date: Wed, 13 Mar 2024 17:36:40 +0100
Subject: [PATCH] :bug: Fix workspace context menu in small screens

---
 .../styles/main/partials/workspace.scss       | 84 -------------------
 .../app/main/ui/workspace/context_menu.cljs   |  9 +-
 .../app/main/ui/workspace/context_menu.scss   |  2 +
 .../ui/workspace/text_palette_ctx_menu.cljs   |  2 +-
 .../ui/workspace/text_palette_ctx_menu.scss   |  2 +-
 5 files changed, 8 insertions(+), 91 deletions(-)

diff --git a/frontend/resources/styles/main/partials/workspace.scss b/frontend/resources/styles/main/partials/workspace.scss
index a387fed48..088add928 100644
--- a/frontend/resources/styles/main/partials/workspace.scss
+++ b/frontend/resources/styles/main/partials/workspace.scss
@@ -68,90 +68,6 @@ $height-palette-max: 80px;
   }
 }
 
-.workspace-context-menu {
-  background-color: $color-white;
-  border-radius: $br3;
-  box-shadow: 0px 2px 8px rgba(0, 0, 0, 0.25);
-  left: 740px;
-  position: absolute;
-  top: 40px;
-  width: 240px;
-  z-index: 12;
-
-  li {
-    align-items: center;
-    font-size: $fs14;
-    padding: $size-1 $size-4;
-    cursor: pointer;
-
-    display: flex;
-    justify-content: space-between;
-
-    &.separator {
-      border-top: 1px solid $color-gray-10;
-      padding: 0px;
-      margin: 2px;
-    }
-
-    span {
-      color: $color-gray-60;
-    }
-
-    span.shortcut {
-      color: $color-gray-20;
-      font-size: $fs12;
-    }
-
-    &:hover {
-      background-color: $color-primary-lighter;
-    }
-
-    .submenu-icon {
-      position: absolute;
-      right: 1rem;
-
-      svg {
-        width: 10px;
-        height: 10px;
-      }
-    }
-  }
-
-  .icon-menu-item {
-    display: flex;
-    justify-content: flex-start;
-
-    &:hover {
-      background-color: $color-primary-lighter;
-    }
-
-    span.title {
-      margin-left: 5px;
-    }
-
-    .selected-icon {
-      svg {
-        width: 10px;
-        height: 10px;
-      }
-    }
-
-    .shape-icon {
-      margin-left: 3px;
-      svg {
-        width: 13px;
-        height: 13px;
-      }
-    }
-
-    .icon-wrapper {
-      display: grid;
-      grid-template-columns: 1fr 1fr;
-      margin: 0;
-    }
-  }
-}
-
 .workspace-content {
   background-color: $color-canvas;
   display: flex;
diff --git a/frontend/src/app/main/ui/workspace/context_menu.cljs b/frontend/src/app/main/ui/workspace/context_menu.cljs
index 8ba1763fe..21f06b71c 100644
--- a/frontend/src/app/main/ui/workspace/context_menu.cljs
+++ b/frontend/src/app/main/ui/workspace/context_menu.cljs
@@ -652,11 +652,10 @@
 
     [:& dropdown {:show (boolean mdata)
                   :on-close #(st/emit! dw/hide-context-menu)}
-     [:ul
-      {:class (stl/css :workspace-context-menu)
-       :ref dropdown-ref
-       :style {:top top :left left}
-       :on-context-menu prevent-default}
+     [:ul {:class (stl/css :workspace-context-menu)
+           :ref dropdown-ref
+           :style {:top top :left left}
+           :on-context-menu prevent-default}
 
       (case (:kind mdata)
         :shape [:& shape-context-menu {:mdata mdata}]
diff --git a/frontend/src/app/main/ui/workspace/context_menu.scss b/frontend/src/app/main/ui/workspace/context_menu.scss
index 0ce429a5b..94b7060a0 100644
--- a/frontend/src/app/main/ui/workspace/context_menu.scss
+++ b/frontend/src/app/main/ui/workspace/context_menu.scss
@@ -20,6 +20,8 @@
   border: $s-2 solid var(--panel-border-color);
   background-color: var(--menu-background-color);
   z-index: $z-index-4;
+  max-height: 100vh;
+  overflow-y: auto;
 }
 
 .separator {
diff --git a/frontend/src/app/main/ui/workspace/text_palette_ctx_menu.cljs b/frontend/src/app/main/ui/workspace/text_palette_ctx_menu.cljs
index f3cbb2208..3f1b573df 100644
--- a/frontend/src/app/main/ui/workspace/text_palette_ctx_menu.cljs
+++ b/frontend/src/app/main/ui/workspace/text_palette_ctx_menu.cljs
@@ -21,7 +21,7 @@
         shared-libs   (mf/deref refs/workspace-libraries)]
     [:& dropdown {:show show-menu?
                   :on-close close-menu}
-     [:ul {:class (stl/css :workspace-context-menu)}
+     [:ul {:class (stl/css :text-context-menu)}
       (for [[idx cur-library] (map-indexed vector (vals shared-libs))]
         (let [typographies (-> cur-library (get-in [:data :typographies]) vals)]
           [:li
diff --git a/frontend/src/app/main/ui/workspace/text_palette_ctx_menu.scss b/frontend/src/app/main/ui/workspace/text_palette_ctx_menu.scss
index e29217eaa..664738562 100644
--- a/frontend/src/app/main/ui/workspace/text_palette_ctx_menu.scss
+++ b/frontend/src/app/main/ui/workspace/text_palette_ctx_menu.scss
@@ -6,7 +6,7 @@
 
 @import "refactor/common-refactor.scss";
 
-.workspace-context-menu {
+.text-context-menu {
   position: absolute;
   left: auto;
   bottom: var(--height);