Penpot/penpot
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-02-02 04:19:08 -05:00
Code Issues Activity

🐛 Fix problem with comments max length

Browse source
This commit is contained in:
alonso.torres 2024-09-17 14:13:17 +02:00
parent e65c0d9f48
commit f5f255e2d5
3 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGES.md
View file

@ -83,6 +83,7 @@
- Fix problem when dismissing shared library update [Taiga #8669](https://tree.taiga.io/project/penpot/issue/8669) - Fix problem when dismissing shared library update [Taiga #8669](https://tree.taiga.io/project/penpot/issue/8669)
- Fix visual problem with stroke cap menu [Taiga #8730](https://tree.taiga.io/project/penpot/issue/8730) - Fix visual problem with stroke cap menu [Taiga #8730](https://tree.taiga.io/project/penpot/issue/8730)
- Fix issue when exporting libraries when merging libraries [Taiga #8758](https://tree.taiga.io/project/penpot/issue/8758) - Fix issue when exporting libraries when merging libraries [Taiga #8758](https://tree.taiga.io/project/penpot/issue/8758)
- Fix problem with comments max length [Taiga #8778](https://tree.taiga.io/project/penpot/issue/8778)
## 2.1.5 ## 2.1.5

2
backend/src/app/rpc/commands/comments.clj
View file

@ -292,7 +292,7 @@
[:map {:title "create-comment-thread"} [:map {:title "create-comment-thread"}
[:file-id ::sm/uuid] [:file-id ::sm/uuid]
[:position ::gpt/point] [:position ::gpt/point]
[:content [:string {:max 250}]] [:content [:string {:max 750}]]
[:page-id ::sm/uuid] [:page-id ::sm/uuid]
[:frame-id ::sm/uuid] [:frame-id ::sm/uuid]
[:share-id {:optional true} [:maybe ::sm/uuid]]]) [:share-id {:optional true} [:maybe ::sm/uuid]]])

13
frontend/src/app/main/ui/comments.cljs
View file

@ -35,6 +35,7 @@
on-focus (unchecked-get props "on-focus") on-focus (unchecked-get props "on-focus")
on-blur (unchecked-get props "on-blur") on-blur (unchecked-get props "on-blur")
placeholder (unchecked-get props "placeholder") placeholder (unchecked-get props "placeholder")
max-length (unchecked-get props "max-length")
on-change (unchecked-get props "on-change") on-change (unchecked-get props "on-change")
on-esc (unchecked-get props "on-esc") on-esc (unchecked-get props "on-esc")
on-ctrl-enter (unchecked-get props "on-ctrl-enter") on-ctrl-enter (unchecked-get props "on-ctrl-enter")
@ -88,7 +89,8 @@
:on-blur on-blur :on-blur on-blur
:value value :value value
:placeholder placeholder :placeholder placeholder
:on-change on-change*}])) :on-change on-change*
:max-length max-length}]))
(mf/defc reply-form (mf/defc reply-form
[{:keys [thread] :as props}] [{:keys [thread] :as props}]
@ -128,7 +130,8 @@
:on-focus on-focus :on-focus on-focus
:select-on-focus? false :select-on-focus? false
:on-ctrl-enter on-submit :on-ctrl-enter on-submit
:on-change on-change}] :on-change on-change
:max-length 750}]
(when (or @show-buttons? (seq @content)) (when (or @show-buttons? (seq @content))
[:div {:class (stl/css :buttons-wrapper)} [:div {:class (stl/css :buttons-wrapper)}
[:input.btn-secondary [:input.btn-secondary
@ -196,7 +199,8 @@
:select-on-focus? false :select-on-focus? false
:on-esc on-esc :on-esc on-esc
:on-change on-change :on-change on-change
:on-ctrl-enter on-submit}] :on-ctrl-enter on-submit
:max-length 750}]
[:div {:class (stl/css :buttons-wrapper)} [:div {:class (stl/css :buttons-wrapper)}
[:input {:on-click on-esc [:input {:on-click on-esc
@ -233,7 +237,8 @@
:select-on-focus true :select-on-focus true
:select-on-focus? false :select-on-focus? false
:on-ctrl-enter on-submit* :on-ctrl-enter on-submit*
:on-change on-change}] :on-change on-change
:max-length 750}]
[:div {:class (stl/css :buttons-wrapper)} [:div {:class (stl/css :buttons-wrapper)}
[:input {:type "button" [:input {:type "button"
:value "Cancel" :value "Cancel"