Penpot/penpot
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-01-09 08:20:45 -05:00
Code Issues Activity

✨ Refactor WorkspacePage so it has more semantic locators

Browse source
This commit is contained in:
Belén Albeza 2024-06-11 15:48:18 +02:00 committed by Alejandro Alonso
parent 7719cd8d0b
commit f417445f31
3 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
frontend/playwright/ui/pages/WorkspacePage.js
View file

@ -48,7 +48,6 @@ export class WorkspacePage extends BaseWebSocketPage {
this.layers = page.getByTestId("layer-tree");
this.palette = page.getByTestId("palette");
this.sidebar = page.getByTestId("left-sidebar");
this.closeLibraries = page.getByTestId("close-libraries");
this.librariesModal = page.getByTestId("libraries-modal");
}
@ -126,7 +125,7 @@ export class WorkspacePage extends BaseWebSocketPage {
await this.sidebar.getByText("Assets").click(clickOptions);
}
async clickLibraries(clickOptions = {}) {
async openLibrariesModal(clickOptions = {}) {
await this.sidebar.getByText("Libraries").click(clickOptions);
}
@ -138,8 +137,8 @@ export class WorkspacePage extends BaseWebSocketPage {
.click(clickOptions);
}
async clickCloseLibraries(clickOptions = {}) {
await this.closeLibraries.click(clickOptions);
async closeLibrariesModal(clickOptions = {}) {
await this.librariesModal.getByRole("button", { name: "Close" }).click(clickOptions);
}
async clickColorPalette(clickOptions = {}) {

8
frontend/playwright/ui/specs/sidebar.spec.js
View file

@ -40,16 +40,16 @@ test.describe("Assets tab", () => {
await workspacePage.clickAssets();
// Now the get-file call should return a library
await workspacePage.mockRPC(/get\-file\?/, "workspace/get-file-library.json");
await workspacePage.clickLibraries();
await workspacePage.openLibrariesModal();
await workspacePage.clickLibrary("Testing library 1");
await workspacePage.clickCloseLibraries();
await workspacePage.closeLibrariesModal();
await expect(workspacePage.palette.getByRole("button", { name: "test-color-187cd5" })).toBeVisible();
// Remove Testing library 1
await workspacePage.clickLibraries();
await workspacePage.openLibrariesModal();
await workspacePage.clickLibrary("Testing library 1");
await workspacePage.clickCloseLibraries();
await workspacePage.closeLibrariesModal();
await expect(
workspacePage.palette.getByText("There are no color styles in your library yet"),

2
frontend/src/app/main/ui/workspace/libraries.cljs
View file

@ -519,7 +519,7 @@
[:div {:class (stl/css :modal-dialog)}
[:button {:class (stl/css :close-btn)
:on-click close-dialog
:data-testid "close-libraries"}
:aria-label (tr "labels.close")}
close-icon]
[:div {:class (stl/css :modal-title)}
(tr "workspace.libraries.libraries")]