From f1768c5a07f46d7da039b0f18a7043271b6c01ff Mon Sep 17 00:00:00 2001
From: "alonso.torres" <alonso.torres@kaleidos.net>
Date: Thu, 1 Feb 2024 11:32:35 +0100
Subject: [PATCH] :bug: Fix problems with inspect and texts

---
 common/src/app/common/text.cljc                        |  6 +++++-
 .../app/main/ui/viewer/inspect/attributes/common.cljs  |  9 +++------
 .../app/main/ui/viewer/inspect/attributes/common.scss  | 10 +++++++++-
 .../main/ui/viewer/inspect/attributes/geometry.cljs    |  6 ++++--
 .../app/main/ui/viewer/inspect/attributes/text.scss    |  3 +--
 5 files changed, 22 insertions(+), 12 deletions(-)

diff --git a/common/src/app/common/text.cljc b/common/src/app/common/text.cljc
index b5b12c5d5..f8297843d 100644
--- a/common/src/app/common/text.cljc
+++ b/common/src/app/common/text.cljc
@@ -53,6 +53,9 @@
 (def text-transform-attrs
   [:text-transform])
 
+(def text-fills
+  [:fills])
+
 (def shape-attrs
   [:grow-type])
 
@@ -70,7 +73,8 @@
    text-font-attrs
    text-spacing-attrs
    text-decoration-attrs
-   text-transform-attrs))
+   text-transform-attrs
+   text-fills))
 
 (def text-all-attrs (d/concat-set shape-attrs root-attrs paragraph-attrs text-node-attrs))
 
diff --git a/frontend/src/app/main/ui/viewer/inspect/attributes/common.cljs b/frontend/src/app/main/ui/viewer/inspect/attributes/common.cljs
index 1fa810340..76001fe46 100644
--- a/frontend/src/app/main/ui/viewer/inspect/attributes/common.cljs
+++ b/frontend/src/app/main/ui/viewer/inspect/attributes/common.cljs
@@ -79,11 +79,9 @@
             [:span {:class (stl/css-case :color-value-wrapper true
                                          :gradient-name (:gradient color))}
              (if (:gradient color)
-               [:& cbn/color-name {:color color
-                                   :size 80}]
+               [:& cbn/color-name {:color color :size 80}]
                (case format
-                 :hex [:& cbn/color-name {:color color
-                                          :size 80}]
+                 :hex [:& cbn/color-name {:color color}]
                  :rgba (let [[r g b a] (cc/hex->rgba (:color color) (:opacity color))]
                          [:* (str/fmt "%s, %s, %s, %s" r g b a)])
                  :hsla (let [[h s l a] (cc/hex->hsla (:color color) (:opacity color))
@@ -105,8 +103,7 @@
            [:span {:class (stl/css-case :color-value-wrapper true
                                         :gradient-name (:gradient color))}
             (if (:gradient color)
-              [:& cbn/color-name {:color color
-                                  :size 80}]
+              [:& cbn/color-name {:color color}]
               (case format
                 :hex [:& cbn/color-name {:color color
                                          :size 80}]
diff --git a/frontend/src/app/main/ui/viewer/inspect/attributes/common.scss b/frontend/src/app/main/ui/viewer/inspect/attributes/common.scss
index bb33fa99c..f05e0faa4 100644
--- a/frontend/src/app/main/ui/viewer/inspect/attributes/common.scss
+++ b/frontend/src/app/main/ui/viewer/inspect/attributes/common.scss
@@ -58,6 +58,11 @@
   }
 }
 
+.name-opacity {
+  display: flex;
+  align-items: baseline;
+}
+
 .color-name-wrapper {
   @include titleTipography;
   @include flexColumn;
@@ -113,8 +118,11 @@
 .color-value-wrapper {
   @include inspectValue;
   text-transform: uppercase;
-  max-width: $s-124;
+  max-width: $s-80;
   padding-right: $s-8;
+  white-space: nowrap;
+  overflow: hidden;
+  text-overflow: ellipsis;
   &.gradient-name {
     text-transform: none;
   }
diff --git a/frontend/src/app/main/ui/viewer/inspect/attributes/geometry.cljs b/frontend/src/app/main/ui/viewer/inspect/attributes/geometry.cljs
index 58e39ca5f..4735502f7 100644
--- a/frontend/src/app/main/ui/viewer/inspect/attributes/geometry.cljs
+++ b/frontend/src/app/main/ui/viewer/inspect/attributes/geometry.cljs
@@ -8,6 +8,7 @@
   (:require-macros [app.main.style :as stl])
   (:require
    [app.common.data :as d]
+   [app.common.data.macros :as dm]
    [app.main.ui.components.copy-button :refer [copy-button]]
    [app.main.ui.components.title-bar :refer [title-bar]]
    [app.util.code-gen.style-css :as css]
@@ -19,9 +20,10 @@
 (mf/defc geometry-block
   [{:keys [objects shape]}]
   [:*
-   (for [property properties]
+   (for [[idx property] (d/enumerate properties)]
      (when-let [value (css/get-css-value objects shape property)]
-       [:div {:class (stl/css :geometry-row)}
+       [:div {:key (dm/str "block-" idx "-" (d/name property))
+              :class (stl/css :geometry-row)}
         [:div {:class (stl/css :global/attr-label)} (d/name property)]
         [:div {:class (stl/css :global/attr-value)}
          [:& copy-button {:data (css/get-css-property objects shape property)}
diff --git a/frontend/src/app/main/ui/viewer/inspect/attributes/text.scss b/frontend/src/app/main/ui/viewer/inspect/attributes/text.scss
index 9f111adad..a506af1b4 100644
--- a/frontend/src/app/main/ui/viewer/inspect/attributes/text.scss
+++ b/frontend/src/app/main/ui/viewer/inspect/attributes/text.scss
@@ -30,7 +30,6 @@
 }
 
 .attributes-content-row {
-  width: $s-252;
   max-width: $s-252;
   min-height: calc($s-2 + $s-32);
   border-radius: $br-8;
@@ -39,7 +38,7 @@
   .content {
     @include titleTipography;
     width: 100%;
-    padding: 0;
+    padding: $s-4 0;
     color: var(--color-foreground-secondary);
   }