Penpot/penpot
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-01-22 14:39:45 -05:00
Code Issues Activity

🐛 Remove after delay event for not-frame shapes

Browse source
This commit is contained in:
alonso.torres 2024-02-22 14:46:06 +01:00
parent 5e6ce26742
commit d51338e754
2 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
common/src/app/common/types/shape/interactions.cljc
View file

@ -176,7 +176,7 @@
(contains? event-types event-type)) (contains? event-types event-type))
(dm/assert! (dm/assert!
"The `:after-delay` event type incompatible with frame shapes" "The `:after-delay` event type incompatible with not frame shapes"
(or (not= event-type :after-delay) (or (not= event-type :after-delay)
(cfh/frame-shape? shape))) (cfh/frame-shape? shape)))

15
frontend/src/app/main/ui/workspace/sidebar/options/menus/interactions.cljs
View file

@ -357,13 +357,14 @@
(update-interaction index #(ctsi/set-offset-effect % value))))) (update-interaction index #(ctsi/set-offset-effect % value)))))
event-type-options [{:value :click :label (tr "workspace.options.interaction-on-click")} event-type-options (-> [{:value :click :label (tr "workspace.options.interaction-on-click")}
;; TODO: need more UX research ;; TODO: need more UX research
;; :mouse-over (tr "workspace.options.interaction-while-hovering") ;; :mouse-over (tr "workspace.options.interaction-while-hovering")
;; :mouse-press (tr "workspace.options.interaction-while-pressing") ;; :mouse-press (tr "workspace.options.interaction-while-pressing")
{:value :mouse-enter :label (tr "workspace.options.interaction-mouse-enter")} {:value :mouse-enter :label (tr "workspace.options.interaction-mouse-enter")}
{:value :mouse-leave :label (tr "workspace.options.interaction-mouse-leave")} {:value :mouse-leave :label (tr "workspace.options.interaction-mouse-leave")}]
{:value :after-delay :label (tr "workspace.options.interaction-after-delay")}] (cond-> (cfh/frame-shape? shape)
(conj {:value :after-delay :label (tr "workspace.options.interaction-after-delay")})))
action-type-options [{:value :navigate :label (tr "workspace.options.interaction-navigate-to")} action-type-options [{:value :navigate :label (tr "workspace.options.interaction-navigate-to")}
{:value :open-overlay :label (tr "workspace.options.interaction-open-overlay")} {:value :open-overlay :label (tr "workspace.options.interaction-open-overlay")}