mirror of
https://github.com/penpot/penpot.git
synced 2025-02-02 04:19:08 -05:00
⚡ Improved performance for layers filtering
This commit is contained in:
alonso.torres
Pablo Alba
parent
d18c96360f
commit
d50299bdbb
2 changed files with 222 additions and 141 deletions
|
|
@ -17,6 +17,7 @@
|
||||||
|
|
||||||
### :sparkles: New features
|
### :sparkles: New features
|
||||||
|
|
||||||
|
- Search and filter layers [Taiga #2564](https://tree.taiga.io/project/penpot/us/2564)
|
||||||
- Constraints are not well assigned when default and multiselection [Taiga #3069](https://tree.taiga.io/project/penpot/issue/3069)
|
- Constraints are not well assigned when default and multiselection [Taiga #3069](https://tree.taiga.io/project/penpot/issue/3069)
|
||||||
- Exporting big files flow [Taiga #2218](https://tree.taiga.io/project/penpot/us/2218)
|
- Exporting big files flow [Taiga #2218](https://tree.taiga.io/project/penpot/us/2218)
|
||||||
- Multiexport from main menu [Taiga #520](https://tree.taiga.io/project/penpot/us/28541)
|
- Multiexport from main menu [Taiga #520](https://tree.taiga.io/project/penpot/us/28541)
|
||||||
|
|
|
||||||
|
|
@ -20,7 +20,6 @@
|
||||||
[app.util.dom :as dom]
|
[app.util.dom :as dom]
|
||||||
[app.util.i18n :as i18n :refer [tr]]
|
[app.util.i18n :as i18n :refer [tr]]
|
||||||
[app.util.keyboard :as kbd]
|
[app.util.keyboard :as kbd]
|
||||||
[app.util.object :as obj]
|
|
||||||
[app.util.timers :as ts]
|
[app.util.timers :as ts]
|
||||||
[beicon.core :as rx]
|
[beicon.core :as rx]
|
||||||
[cuerdas.core :as str]
|
[cuerdas.core :as str]
|
||||||
|
|
@ -251,86 +250,204 @@
|
||||||
[:> layer-item props])
|
[:> layer-item props])
|
||||||
|
|
||||||
(mf/defc layers-tree
|
(mf/defc layers-tree
|
||||||
{::mf/wrap [#(mf/memo % =)]}
|
{::mf/wrap [#(mf/memo % =)
|
||||||
|
#(mf/throttle % 200)]}
|
||||||
[{:keys [objects] :as props}]
|
[{:keys [objects] :as props}]
|
||||||
(let [selected (mf/deref refs/selected-shapes)
|
(let [selected (mf/deref refs/selected-shapes)
|
||||||
selected (hooks/use-equal-memo selected)
|
selected (hooks/use-equal-memo selected)
|
||||||
root (get objects uuid/zero)]
|
root (get objects uuid/zero)]
|
||||||
[:ul.element-list
|
[:ul.element-list
|
||||||
[:& hooks/sortable-container {}
|
[:& hooks/sortable-container {}
|
||||||
(for [[index id] (reverse (d/enumerate (:shapes root)))]
|
(for [[index id] (reverse (d/enumerate (:shapes root)))]
|
||||||
(when-let [obj (get objects id)]
|
(when-let [obj (get objects id)]
|
||||||
(if (= (:type obj) :frame)
|
(if (= (:type obj) :frame)
|
||||||
[:& frame-wrapper
|
[:& frame-wrapper
|
||||||
{:item obj
|
{:item obj
|
||||||
:selected selected
|
:selected selected
|
||||||
:index index
|
:index index
|
||||||
:objects objects
|
:objects objects
|
||||||
:key id}]
|
:key id}]
|
||||||
[:& layer-item
|
[:& layer-item
|
||||||
{:item obj
|
{:item obj
|
||||||
:selected selected
|
:selected selected
|
||||||
:index index
|
:index index
|
||||||
:objects objects
|
:objects objects
|
||||||
:key id}])))]]))
|
:key id}])))]]))
|
||||||
|
|
||||||
(mf/defc layers-tree-wrapper
|
(mf/defc filters-tree
|
||||||
{::mf/wrap-props false
|
{::mf/wrap [#(mf/memo % =)
|
||||||
::mf/wrap [mf/memo #(mf/throttle % 200)]}
|
#(mf/throttle % 200)]}
|
||||||
[props]
|
[{:keys [objects] :as props}]
|
||||||
(let [search (obj/get props "search")
|
(let [selected (mf/deref refs/selected-shapes)
|
||||||
filters (obj/get props "filters")
|
selected (hooks/use-equal-memo selected)
|
||||||
filters (if (some #{:shape} filters)
|
root (get objects uuid/zero)]
|
||||||
(conj filters :rect :circle :path :bool)
|
[:ul.element-list
|
||||||
filters)
|
(for [[index id] (d/enumerate (:shapes root))]
|
||||||
objects (-> (obj/get props "objects")
|
(when-let [obj (get objects id)]
|
||||||
(hooks/use-equal-memo))
|
[:& layer-item
|
||||||
|
{:item obj
|
||||||
|
:selected selected
|
||||||
|
:index index
|
||||||
|
:objects objects
|
||||||
|
:key id}]))]))
|
||||||
|
|
||||||
;; TODO: Fix performance
|
|
||||||
reparented-objects (d/mapm (fn [_ val]
|
|
||||||
(assoc val :parent-id uuid/zero :shapes nil))
|
|
||||||
objects)
|
|
||||||
|
|
||||||
reparented-shapes (->> reparented-objects
|
(defn calc-reparented-objects
|
||||||
keys
|
[objects]
|
||||||
(filter #(not= uuid/zero %))
|
|
||||||
vec)
|
|
||||||
|
|
||||||
reparented-objects (update reparented-objects uuid/zero assoc :shapes reparented-shapes)
|
(let [reparented-objects
|
||||||
|
(d/mapm (fn [_ val]
|
||||||
search-and-filters (mf/use-callback
|
(assoc val :parent-id uuid/zero :shapes nil))
|
||||||
(mf/deps search filters)
|
objects)
|
||||||
(fn [[id shape]]
|
|
||||||
(or
|
|
||||||
(= uuid/zero id)
|
|
||||||
(and
|
|
||||||
(str/includes? (str/lower (:name shape)) (str/lower search))
|
|
||||||
(or
|
|
||||||
(empty? filters)
|
|
||||||
(and
|
|
||||||
(some #{:component} filters)
|
|
||||||
(contains? shape :component-id))
|
|
||||||
(let [direct_filters (filter #{:frame :rect :circle :path :bool :image :text} filters)]
|
|
||||||
(some #{(:type shape)} direct_filters))
|
|
||||||
(and
|
|
||||||
(some #{:group} filters)
|
|
||||||
(and (= :group (:type shape))
|
|
||||||
(not (contains? shape :component-id))
|
|
||||||
(or (not (contains? shape :masked-group?)) (false? (:masked-group? shape)))))
|
|
||||||
(and
|
|
||||||
(some #{:mask} filters)
|
|
||||||
(true? (:masked-group? shape))))))))
|
|
||||||
|
|
||||||
objects (if (and (= "" search) (empty? filters))
|
|
||||||
objects
|
|
||||||
(into {} (filter search-and-filters
|
|
||||||
reparented-objects)))]
|
|
||||||
|
|
||||||
[:& layers-tree {:objects objects}]))
|
|
||||||
|
|
||||||
|
reparented-shapes
|
||||||
|
(->> reparented-objects
|
||||||
|
keys
|
||||||
|
(filter #(not= uuid/zero %))
|
||||||
|
vec)]
|
||||||
|
(update reparented-objects uuid/zero assoc :shapes reparented-shapes)))
|
||||||
|
|
||||||
;; --- Layers Toolbox
|
;; --- Layers Toolbox
|
||||||
|
|
||||||
|
(defn use-search
|
||||||
|
[page objects]
|
||||||
|
(let [filter-state (mf/use-state {:show-search-box false
|
||||||
|
:show-filters-menu false
|
||||||
|
:search-text ""
|
||||||
|
:active-filters #{}
|
||||||
|
:num-items 100})
|
||||||
|
|
||||||
|
clear-search-text
|
||||||
|
(mf/use-callback
|
||||||
|
(fn []
|
||||||
|
(swap! filter-state assoc :search-text "" :num-items 100)))
|
||||||
|
|
||||||
|
update-search-text
|
||||||
|
(mf/use-callback
|
||||||
|
(fn [event]
|
||||||
|
(let [value (-> event dom/get-target dom/get-value)]
|
||||||
|
(swap! filter-state assoc :search-text value :num-items 100))))
|
||||||
|
|
||||||
|
toggle-search
|
||||||
|
(mf/use-callback
|
||||||
|
(fn []
|
||||||
|
(swap! filter-state assoc :search-text "")
|
||||||
|
(swap! filter-state assoc :active-filters #{})
|
||||||
|
(swap! filter-state assoc :show-filters-menu false)
|
||||||
|
(swap! filter-state assoc :num-items 100)
|
||||||
|
(swap! filter-state update :show-search-box not)))
|
||||||
|
|
||||||
|
toggle-filters
|
||||||
|
(mf/use-callback
|
||||||
|
(fn []
|
||||||
|
(swap! filter-state update :show-filters-menu not)))
|
||||||
|
|
||||||
|
remove-filter
|
||||||
|
(mf/use-callback
|
||||||
|
(mf/deps @filter-state)
|
||||||
|
(fn [key]
|
||||||
|
(fn [_]
|
||||||
|
(swap! filter-state update :active-filters disj key)
|
||||||
|
(swap! filter-state assoc :num-items 100))))
|
||||||
|
|
||||||
|
add-filter
|
||||||
|
(mf/use-callback
|
||||||
|
(mf/deps @filter-state (:show-filters-menu @filter-state))
|
||||||
|
(fn [key]
|
||||||
|
(fn [_]
|
||||||
|
(swap! filter-state update :active-filters conj key)
|
||||||
|
(swap! filter-state assoc :num-items 100)
|
||||||
|
(toggle-filters))))
|
||||||
|
|
||||||
|
active?
|
||||||
|
(and
|
||||||
|
(:show-search-box @filter-state)
|
||||||
|
(or (d/not-empty? (:search-text @filter-state))
|
||||||
|
(d/not-empty? (:active-filters @filter-state))))
|
||||||
|
|
||||||
|
search-and-filters
|
||||||
|
(fn [[id shape]]
|
||||||
|
(let [search (:search-text @filter-state)
|
||||||
|
filters (:active-filters @filter-state)]
|
||||||
|
(or
|
||||||
|
(= uuid/zero id)
|
||||||
|
(and
|
||||||
|
(str/includes? (str/lower (:name shape)) (str/lower search))
|
||||||
|
(or
|
||||||
|
(empty? filters)
|
||||||
|
(and
|
||||||
|
(some #{:component} filters)
|
||||||
|
(contains? shape :component-id))
|
||||||
|
(let [direct_filters (filter #{:frame :rect :circle :path :bool :image :text} filters)]
|
||||||
|
(some #{(:type shape)} direct_filters))
|
||||||
|
(and
|
||||||
|
(some #{:group} filters)
|
||||||
|
(and (= :group (:type shape))
|
||||||
|
(not (contains? shape :component-id))
|
||||||
|
(or (not (contains? shape :masked-group?)) (false? (:masked-group? shape)))))
|
||||||
|
(and
|
||||||
|
(some #{:mask} filters)
|
||||||
|
(true? (:masked-group? shape))))))))
|
||||||
|
|
||||||
|
filtered-objects-total
|
||||||
|
(mf/use-memo
|
||||||
|
(mf/deps objects active? @filter-state)
|
||||||
|
#(when active?
|
||||||
|
;; filterv so count is constant time
|
||||||
|
(filterv search-and-filters objects)))
|
||||||
|
|
||||||
|
filtered-objects
|
||||||
|
(mf/use-memo
|
||||||
|
(mf/deps filtered-objects-total)
|
||||||
|
#(when active?
|
||||||
|
(calc-reparented-objects
|
||||||
|
(into {}
|
||||||
|
(take (:num-items @filter-state))
|
||||||
|
filtered-objects-total))))
|
||||||
|
|
||||||
|
|
||||||
|
handle-show-more
|
||||||
|
(fn []
|
||||||
|
(when (<= (:num-items @filter-state) (count filtered-objects-total))
|
||||||
|
(swap! filter-state update :num-items + 100)))]
|
||||||
|
|
||||||
|
[filtered-objects
|
||||||
|
handle-show-more
|
||||||
|
|
||||||
|
(mf/html
|
||||||
|
(if (:show-search-box @filter-state)
|
||||||
|
[:*
|
||||||
|
[:div.tool-window-bar.search
|
||||||
|
[:span.search-box
|
||||||
|
[:span.filter {:on-click toggle-filters :class (dom/classnames :active active?)} i/icon-filter]
|
||||||
|
[:span
|
||||||
|
[:input {:on-change update-search-text
|
||||||
|
:value (:search-text @filter-state)
|
||||||
|
:auto-focus (:show-search-box @filter-state)
|
||||||
|
:placeholder (tr "workspace.sidebar.layers.search")}]]
|
||||||
|
(when (not (= "" (:search-text @filter-state)))
|
||||||
|
[:span.clear {:on-click clear-search-text} i/exclude])]
|
||||||
|
[:span {:on-click toggle-search} i/cross]]
|
||||||
|
|
||||||
|
[:div.active-filters
|
||||||
|
(for [f (:active-filters @filter-state)]
|
||||||
|
[:span {:on-click (remove-filter f)}
|
||||||
|
(tr f) i/cross])]
|
||||||
|
|
||||||
|
(when (:show-filters-menu @filter-state)
|
||||||
|
[:div.filters-container
|
||||||
|
[:span{:on-click (add-filter :frame)} i/artboard (tr "workspace.sidebar.layers.frames")]
|
||||||
|
[:span{:on-click (add-filter :group)} i/folder (tr "workspace.sidebar.layers.groups")]
|
||||||
|
[:span{:on-click (add-filter :mask)} i/mask (tr "workspace.sidebar.layers.masks")]
|
||||||
|
[:span{:on-click (add-filter :component)} i/component (tr "workspace.sidebar.layers.components")]
|
||||||
|
[:span{:on-click (add-filter :text)} i/text (tr "workspace.sidebar.layers.texts")]
|
||||||
|
[:span{:on-click (add-filter :image)} i/image (tr "workspace.sidebar.layers.images")]
|
||||||
|
[:span{:on-click (add-filter :shape)} i/curve (tr "workspace.sidebar.layers.shapes")]])]
|
||||||
|
|
||||||
|
[:div.tool-window-bar
|
||||||
|
[:span (:name page)]
|
||||||
|
[:span {:on-click toggle-search} i/search]]))]))
|
||||||
|
|
||||||
(mf/defc layers-toolbox
|
(mf/defc layers-toolbox
|
||||||
{:wrap [mf/memo]}
|
{:wrap [mf/memo]}
|
||||||
[]
|
[]
|
||||||
|
|
@ -338,10 +455,30 @@
|
||||||
focus (mf/deref refs/workspace-focus-selected)
|
focus (mf/deref refs/workspace-focus-selected)
|
||||||
objects (hooks/with-focus-objects (:objects page) focus)
|
objects (hooks/with-focus-objects (:objects page) focus)
|
||||||
title (when (= 1 (count focus)) (get-in objects [(first focus) :name]))
|
title (when (= 1 (count focus)) (get-in objects [(first focus) :name]))
|
||||||
filter-state (mf/use-state {:show-search-box false
|
|
||||||
:show-filters-menu false
|
observer-var (mf/use-var nil)
|
||||||
:search-text ""
|
lazy-load-ref (mf/use-ref nil)
|
||||||
:active-filters {}})
|
|
||||||
|
[filtered-objects show-more filter-component] (use-search page objects)
|
||||||
|
|
||||||
|
intersection-callback
|
||||||
|
(fn [entries]
|
||||||
|
(when (and (.-isIntersecting (first entries)) (some? show-more))
|
||||||
|
(show-more)))
|
||||||
|
|
||||||
|
on-render-container
|
||||||
|
(fn [element]
|
||||||
|
(let [options #js {:root element}
|
||||||
|
lazy-el (mf/ref-val lazy-load-ref)]
|
||||||
|
(cond
|
||||||
|
(and (some? element) (not (some? @observer-var)))
|
||||||
|
(let [observer (js/IntersectionObserver. intersection-callback options)]
|
||||||
|
(.observe observer lazy-el)
|
||||||
|
(reset! observer-var observer))
|
||||||
|
|
||||||
|
(and (nil? element) (some? @observer-var))
|
||||||
|
(do (.disconnect @observer-var)
|
||||||
|
(reset! observer-var nil)))))
|
||||||
|
|
||||||
on-scroll
|
on-scroll
|
||||||
(fn [event]
|
(fn [event]
|
||||||
|
|
@ -355,33 +492,7 @@
|
||||||
(dom/remove-class! frame "sticky"))
|
(dom/remove-class! frame "sticky"))
|
||||||
|
|
||||||
(when last-hidden-frame
|
(when last-hidden-frame
|
||||||
(dom/add-class! last-hidden-frame "sticky"))))
|
(dom/add-class! last-hidden-frame "sticky"))))]
|
||||||
clear-search-text #(swap! filter-state assoc :search-text "")
|
|
||||||
update-search-text (fn [event]
|
|
||||||
(let [value (-> event dom/get-target dom/get-value)]
|
|
||||||
(swap! filter-state assoc :search-text value)))
|
|
||||||
toggle-search (fn []
|
|
||||||
(swap! filter-state assoc :search-text "")
|
|
||||||
(swap! filter-state assoc :active-filters {})
|
|
||||||
(swap! filter-state assoc :show-filters-menu false)
|
|
||||||
(swap! filter-state update :show-search-box not))
|
|
||||||
toggle-filters #(swap! filter-state update :show-filters-menu not)
|
|
||||||
|
|
||||||
|
|
||||||
remove-filter
|
|
||||||
(mf/use-callback
|
|
||||||
(mf/deps @filter-state)
|
|
||||||
(fn [key]
|
|
||||||
(fn [_]
|
|
||||||
(swap! filter-state update :active-filters dissoc key))))
|
|
||||||
|
|
||||||
add-filter
|
|
||||||
(mf/use-callback
|
|
||||||
(mf/deps @filter-state (:show-filters-menu @filter-state))
|
|
||||||
(fn [key value]
|
|
||||||
(fn [_]
|
|
||||||
(swap! filter-state update :active-filters assoc key value)
|
|
||||||
(toggle-filters))))]
|
|
||||||
|
|
||||||
|
|
||||||
[:div#layers.tool-window
|
[:div#layers.tool-window
|
||||||
|
|
@ -394,48 +505,17 @@
|
||||||
[:span (or title (tr "workspace.focus.selection"))]
|
[:span (or title (tr "workspace.focus.selection"))]
|
||||||
[:div.focus-mode (tr "workspace.focus.focus-mode")]]]
|
[:div.focus-mode (tr "workspace.focus.focus-mode")]]]
|
||||||
|
|
||||||
|
filter-component)
|
||||||
|
|
||||||
(if (:show-search-box @filter-state)
|
(when (some? filtered-objects)
|
||||||
[:*
|
[:div.tool-window-content {:ref on-render-container :key "filters"}
|
||||||
[:div.tool-window-bar.search
|
[:& filters-tree {:objects filtered-objects
|
||||||
[:span.search-box
|
:key (dm/str (:id page))}]
|
||||||
[:span.filter {:on-click toggle-filters
|
[:div.lazy {:ref lazy-load-ref
|
||||||
:class (dom/classnames :active (or
|
:key "lazy-load"
|
||||||
(:show-filters-menu @filter-state)
|
:style {:min-height 16}}]])
|
||||||
(not-empty (:active-filters @filter-state))))}
|
|
||||||
i/icon-filter]
|
|
||||||
[:span
|
|
||||||
[:input {:on-change update-search-text
|
|
||||||
:value (:search-text @filter-state)
|
|
||||||
:auto-focus (:show-search-box @filter-state)
|
|
||||||
:placeholder (tr "workspace.sidebar.layers.search")}]]
|
|
||||||
(when (not (= "" (:search-text @filter-state)))
|
|
||||||
[:span.clear {:on-click clear-search-text} i/exclude])]
|
|
||||||
[:span {:on-click toggle-search} i/cross]
|
|
||||||
]
|
|
||||||
[:div.active-filters
|
|
||||||
(for [f (:active-filters @filter-state)]
|
|
||||||
[:span {:on-click (remove-filter (key f))}
|
|
||||||
(tr (val f)) i/cross])
|
|
||||||
]
|
|
||||||
|
|
||||||
|
[:div.tool-window-content {:on-scroll on-scroll
|
||||||
(when (:show-filters-menu @filter-state)
|
:style {:display (when (some? filtered-objects) "none")}}
|
||||||
[:div.filters-container
|
[:& layers-tree {:objects objects
|
||||||
[:span{:on-click (add-filter :frame "workspace.sidebar.layers.frames")} i/artboard (tr "workspace.sidebar.layers.frames")]
|
:key (dm/str (:id page))}]]]))
|
||||||
[:span{:on-click (add-filter :group "workspace.sidebar.layers.groups")} i/folder (tr "workspace.sidebar.layers.groups")]
|
|
||||||
[:span{:on-click (add-filter :mask "workspace.sidebar.layers.masks")} i/mask (tr "workspace.sidebar.layers.masks")]
|
|
||||||
[:span{:on-click (add-filter :component "workspace.sidebar.layers.components")} i/component (tr "workspace.sidebar.layers.components")]
|
|
||||||
[:span{:on-click (add-filter :text "workspace.sidebar.layers.texts")} i/text (tr "workspace.sidebar.layers.texts")]
|
|
||||||
[:span{:on-click (add-filter :image "workspace.sidebar.layers.images")} i/image (tr "workspace.sidebar.layers.images")]
|
|
||||||
[:span{:on-click (add-filter :shape "workspace.sidebar.layers.shapes")} i/curve (tr "workspace.sidebar.layers.shapes")]])]
|
|
||||||
|
|
||||||
[:div.tool-window-bar
|
|
||||||
[:span (:name page)]
|
|
||||||
[:span {:on-click toggle-search} i/search]]))
|
|
||||||
|
|
||||||
[:div.tool-window-content {:on-scroll on-scroll}
|
|
||||||
[:& layers-tree-wrapper {:objects objects
|
|
||||||
:key (dm/str (:id page))
|
|
||||||
:search (:search-text @filter-state)
|
|
||||||
:filters (keys (:active-filters @filter-state))}]]]))
|
|
||||||
|
|
|
||||||
Loading…
Add table
Reference in a new issue