Penpot/penpot
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-03-19 11:11:21 -05:00
Code Issues Activity

🐛 Fix problem with auto in grid and min sizes

Browse source
This commit is contained in:
alonso.torres 2024-01-05 13:18:28 +01:00 • committed by Andrey Antukh
parent d0244e0bef
commit cf3c3cf989
2 changed files with 48 additions and 42 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
common/src/app/common/geom/shapes/grid_layout/layout_data.cljc
View file

@ -62,14 +62,14 @@
(defn child-min-width
[child child-bounds bounds objects]
(+ (ctl/child-width-margin child)
(-child-min-width child child-bounds bounds objects)))
(-child-min-width child child-bounds bounds objects true)))
(def -child-min-height nil)
(defn child-min-height
[child child-bounds bounds objects]
(+ (ctl/child-height-margin child)
(-child-min-height child child-bounds bounds objects)))
(-child-min-height child child-bounds bounds objects true)))
(defn layout-bounds
[parent shape-bounds]

86
common/src/app/common/geom/shapes/min_size_layout.cljc
View file

@ -16,54 +16,60 @@
[app.common.types.shape.layout :as ctl]))
(defn child-min-width
[child child-bounds bounds objects]
(cond
(and (ctl/fill-width? child) (ctl/flex-layout? child))
(ctl/child-min-width child)
;; Uncomment this to activate "auto" as min size
#_(let [children (cfh/get-immediate-children objects (dm/get-prop child :id) {:remove-hidden true})]
(max (ctl/child-min-width child)
(gpo/width-points (fb/layout-content-bounds bounds child children objects))))
([child child-bounds bounds objects]
(child-min-width child child-bounds bounds objects false))
([child child-bounds bounds objects strict?]
(cond
(and (not strict?) (ctl/fill-width? child) (ctl/flex-layout? child))
(ctl/child-min-width child)
(and (ctl/fill-width? child)
(ctl/grid-layout? child))
(let [children
(->> (cfh/get-immediate-children objects (:id child) {:remove-hidden true})
(map #(vector @(get bounds (:id %)) %)))
layout-data (gd/calc-layout-data child @(get bounds (:id child)) children bounds objects true)]
(max (ctl/child-min-width child)
(gpo/width-points (gb/layout-content-bounds bounds child layout-data))))
(and strict? (ctl/fill-width? child) (ctl/flex-layout? child))
(let [children (cfh/get-immediate-children objects (dm/get-prop child :id) {:remove-hidden true})]
(max (ctl/child-min-width child)
(gpo/width-points (fb/layout-content-bounds bounds child children objects))))
(ctl/fill-width? child)
(ctl/child-min-width child)
(and (ctl/fill-width? child)
(ctl/grid-layout? child))
(let [children
(->> (cfh/get-immediate-children objects (:id child) {:remove-hidden true})
(map #(vector @(get bounds (:id %)) %)))
layout-data (gd/calc-layout-data child @(get bounds (:id child)) children bounds objects true)]
(max (ctl/child-min-width child)
(gpo/width-points (gb/layout-content-bounds bounds child layout-data))))
:else
(gpo/width-points child-bounds)))
(ctl/fill-width? child)
(ctl/child-min-width child)
:else
(gpo/width-points child-bounds))))
(defn child-min-height
[child child-bounds bounds objects]
(cond
(and (ctl/fill-height? child) (ctl/flex-layout? child))
;; Uncomment this to activate "auto" as min size
(ctl/child-min-height child)
#_(let [children (cfh/get-immediate-children objects (dm/get-prop child :id) {:remove-hidden true})]
(max (ctl/child-min-height child)
(gpo/height-points (fb/layout-content-bounds bounds child children objects))))
([child child-bounds bounds objects]
(child-min-height child child-bounds bounds objects false))
([child child-bounds bounds objects strict?]
(cond
(and (not strict?) (ctl/fill-height? child) (ctl/flex-layout? child))
(ctl/child-min-height child)
(and (ctl/fill-height? child) (ctl/grid-layout? child))
(let [children
(->> (cfh/get-immediate-children objects (dm/get-prop child :id) {:remove-hidden true})
(map (fn [child] [@(get bounds (:id child)) child])))
layout-data (gd/calc-layout-data child (:points child) children bounds objects true)
auto-bounds (gb/layout-content-bounds bounds child layout-data)]
(max (ctl/child-min-height child)
(gpo/height-points auto-bounds)))
(and strict? (ctl/fill-height? child) (ctl/flex-layout? child))
(let [children (cfh/get-immediate-children objects (dm/get-prop child :id) {:remove-hidden true})]
(max (ctl/child-min-height child)
(gpo/height-points (fb/layout-content-bounds bounds child children objects))))
(ctl/fill-height? child)
(ctl/child-min-height child)
(and (ctl/fill-height? child) (ctl/grid-layout? child))
(let [children
(->> (cfh/get-immediate-children objects (dm/get-prop child :id) {:remove-hidden true})
(map (fn [child] [@(get bounds (:id child)) child])))
layout-data (gd/calc-layout-data child (:points child) children bounds objects true)
auto-bounds (gb/layout-content-bounds bounds child layout-data)]
(max (ctl/child-min-height child)
(gpo/height-points auto-bounds)))
:else
(gpo/height-points child-bounds)))
(ctl/fill-height? child)
(ctl/child-min-height child)
:else
(gpo/height-points child-bounds))))
#?(:cljs
(do (set! fd/-child-min-width child-min-width)